D11848: [Kickoff] Reduce hover delay before switching tabs

2018-03-31 Thread Christoph Feck
cfeck added a comment. I didn't say it is a problem. I just asked if we know it isn't a problem for them. There must have been a reason the delay was added in the first place. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11848 To: ngraham, #plasma,

D11855: By default, sort app lists by rating again

2018-03-31 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The change to sort app lists by released

D11848: [Kickoff] Reduce hover delay before switching tabs

2018-03-31 Thread Nathaniel Graham
ngraham added a comment. Why is it a problem if the tabs change when you overshoot the target? Not doing this makes Kickoff feel slow and ponderous. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11848 To: ngraham, #plasma, davidedmundson, abetts Cc: cfeck,

D11848: [Kickoff] Reduce hover delay before switching tabs

2018-03-31 Thread Christoph Feck
cfeck added a comment. If they accidentally shoot too far, and want to move back without the tabs changing in between. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11848 To: ngraham, #plasma, davidedmundson, abetts Cc: cfeck, plasma-devel, ragreen, Pitel,

D11848: [Kickoff] Reduce hover delay before switching tabs

2018-03-31 Thread Nathaniel Graham
ngraham added a comment. Since the tabs are immediately below the content area that they affect, I have trouble understanding what possible usability concern would come into play here. If someone moves their cursor very slowly across tabs and makes the view change multiple times,

D11848: [Kickoff] Reduce hover delay before switching tabs

2018-03-31 Thread Christoph Feck
cfeck added a comment. Do we have studies from users that did not complain, because they need the delay? I am thinking about touchpad or trackball users, that cannot move as fast a regular mouse. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11848 To:

D11852: [colors] add corresponding CMakeLists.txt

2018-03-31 Thread Vlad Zagorodniy
zzag created this revision. zzag added a reviewer: Breeze. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R31 Breeze BRANCH colors-cmake REVISION DETAIL

D11533: [kstyle] create shadow tiles more explicitly

2018-03-31 Thread Vlad Zagorodniy
zzag added a comment. Ping. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11533 To: zzag, #breeze, hpereiradacosta Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11850: modernize: use auto

2018-03-31 Thread Vlad Zagorodniy
zzag created this revision. zzag added a reviewer: Breeze. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R31 Breeze BRANCH modernize-use-auto REVISION DETAIL

D11849: [kdecoration] properly compare opacity values

2018-03-31 Thread Vlad Zagorodniy
zzag created this revision. zzag added a reviewer: Breeze. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R31 Breeze BRANCH properly-compare-opacity REVISION DETAIL

D11848: [Kickoff] Reduce hover delay before switching tabs

2018-03-31 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Plasma, davidedmundson, abetts. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY the 250ms delay before switching tabs on

D11847: [kdecoration] delete unused m_buttons field

2018-03-31 Thread Vlad Zagorodniy
zzag created this revision. zzag added a reviewer: Breeze. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R31 Breeze BRANCH kdecoration-unused-field REVISION DETAIL

D11842: Remove categories from app delegates

2018-03-31 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch removes category labels from the

D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI

2018-03-31 Thread Roman Gilg
This revision was automatically updated to reflect the committed changes. romangg marked an inline comment as done. Closed by commit R119:6bb8cde96083: [Mouse KCM] Add X11 libinput exclusive backend and UI (authored by romangg). CHANGED PRIOR TO COMMIT

D11468: [Mouse KCM] Add KWin Wayland backend

2018-03-31 Thread Roman Gilg
This revision was automatically updated to reflect the committed changes. Closed by commit R119:4f06b7cce421: [Mouse KCM] Add KWin Wayland backend (authored by romangg). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11468?vs=29863=31037#toc REPOSITORY R119 Plasma Desktop CHANGES

D11410: [RFC] Add option to make applet fixed width

2018-03-31 Thread Radek Hušek
Pitel updated this revision to Diff 31036. Pitel added a comment. Fix tooltip text. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11410?vs=30728=31036 BRANCH fixedSizeOverride REVISION DETAIL https://phabricator.kde.org/D11410 AFFECTED FILES

D11808: [weather dataengine] Fix BBC provider to adapt to change RSS feed

2018-03-31 Thread Friedrich W . H . Kossebau
This revision was automatically updated to reflect the committed changes. kossebau marked an inline comment as done. Closed by commit R120:558a29efc4c9: [weather dataengine] Fix BBC provider to adapt to change RSS feed (authored by kossebau). CHANGED PRIOR TO COMMIT

D11832: Update kfontview docbook to 5.12

2018-03-31 Thread Burkhard Lück
lueck created this revision. lueck added reviewers: Plasma, Documentation. Restricted Application added a project: Plasma. Restricted Application added subscribers: kde-doc-english, plasma-devel. lueck requested review of this revision. REVISION SUMMARY bump date + releaseinfo remove obsolete

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

2018-03-31 Thread Elvis Angelaccio
elvisangelaccio added a comment. I'd just remove the code and explain why in the commit message. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D4193 To: arichardson, #plasma, elvisangelaccio Cc: ngraham, krzyc, anthonyfieroni,

D11831: Update fontinst docbook to 5.12

2018-03-31 Thread Burkhard Lück
lueck created this revision. lueck added reviewers: Plasma, Documentation. Restricted Application added a project: Plasma. Restricted Application added subscribers: kde-doc-english, plasma-devel. lueck requested review of this revision. REVISION SUMMARY bump date + releaseinfo remove

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

2018-03-31 Thread Alex Richardson
arichardson added a comment. I'll update and test this again when I get back to my work computer on Tuesday. Should I just remove the code or add a comment that since qt 5.8 it is no longer necessary to set the directory as well? REPOSITORY R135 Integration for Qt applications in Plasma

D11807: AbstractModel: Check if index is valid in setData

2018-03-31 Thread David Rosca
This revision was automatically updated to reflect the committed changes. Closed by commit R115:0284a425f3db: AbstractModel: Check if index is valid in setData (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE