D12116: Use const'ref here too

This revision was automatically updated to reflect the committed changes. Closed by commit R104:58f9e46b1dad: Use const'ref here too (authored by mlaurent). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12116?vs=31895&id=31949 REVISION DETAIL https://phabr

D12102: Port Language KCM to Qt Quick

safaalfulaij added inline comments. INLINE COMMENTS > translationsmodel.cpp:124 > + > +QString TranslationsModel::languageCodeToName(const QString& languageCode) > const > +{ About this and the fact the Qt doesn't still have an API for returning the language according to the current locale, ma

D12102: Port Language KCM to Qt Quick

abetts added a comment. Would it be hard to include a checkbox to the left of each list item that shows a selection when tapped? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: abetts, ngraham, plasma-devel, ragreen, Pitel,

D12137: Use consistent spacing and units for suffixes in spinboxes

kossebau added a comment. Is there any mention about unit symbols appending in the HIG? Would be interesting to know what for consistent UI is recommended e.g. for "days", where some are used to "d" as unit, while the mere mortal might be more familiar/comfortable with "days" in the UI of th

D12137: Use consistent spacing and units for suffixes in spinboxes

kossebau created this revision. kossebau added reviewers: Plasma, kde-i18n-doc. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY As specified by the International System of Units

D12134: [mediaframe applet] Fix broken selection of fill mode

kossebau added a comment. Target: 5.12 branch. D10618 also handled this, though only for master and by some long explicit if-else method instead of using the model & index. I would propose to change master to also use the old model with this fix inst

D12134: [mediaframe applet] Fix broken selection of fill mode

kossebau created this revision. kossebau added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY "comboBoxItems" does not reference anything, at

KDE CI: Plasma discover kf5-qt5 SUSEQt5.9 - Build # 393 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.9/393/ Project: Plasma discover kf5-qt5 SUSEQt5.9 Date of build: Wed, 11 Apr 2018 23:27:07 + Build duration: 1 min 21 sec and counting CONSOLE OUTPUT [...trun

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 222 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/222/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 11 Apr 2018 23:27:07 + Build duration: 1 min 32 sec and counting CONSOLE OUTPUT [.

D12103: Support snap permissions in Discover

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:0376a9727e53: Support snap permissions in Discover (authored by apol). REPOSITORY R134 Discover Software Store CHAN

D12041: [WIP] Add "Get Wallpaper Plugins..." button to Config Desktop dialog

davidedmundson added a comment. Is this still a WIP or ready for review? Please update the title when it is ready. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12041 To: Zren, #plasma Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesl

D12102: Port Language KCM to Qt Quick

hein planned changes to this revision. hein added a comment. Still not meant for review. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensr

D12102: Port Language KCM to Qt Quick

hein updated this revision to Diff 31923. hein added a comment. Use ListViews REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12102?vs=31843&id=31923 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12102 AFFECTED FILES kcms/CMakeLi

D12103: Support snap permissions in Discover

apol updated this revision to Diff 31911. apol added a comment. Address issues by upstreap snapdqt maintainer Robert Ancell. Change to show a check box instead of the slider. REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12103?vs=31847&id

D12117: handle in the top toolbar

apol added a comment. Sounds like a brilliant idea. +1 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12117 To: mart, #kirigami Cc: apol, plasma-devel, davidedmundson, mart, hein

D12088: port the ksplash kcm to the new design

davidedmundson added inline comments. INLINE COMMENTS > mart wrote in main.qml:60 > > You shouldn't have told me that :) > > I have one consistent rule about working round Qt bugs, it needs an > > upstream report and a link in the code. > > I am not completely sure is actually a Qt bug... not s

D12118: Only install translations if they are available

heikobecker created this revision. heikobecker added reviewers: Plasma, graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY Otherwise an empty directory might get insta

D12088: port the ksplash kcm to the new design

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:60 > You shouldn't have told me that :) > > I have one consistent rule about working round Qt bugs, it needs an upstream > report and a link in the code. > > - > > but in any case, your comment doesn't explain

D12088: port the ksplash kcm to the new design

mart updated this revision to Diff 31901. mart added a comment. - remove one redundant setcurrentindex REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12088?vs=31819&id=31901 BRANCH phab/ksplashredesign REVISION DETAIL https://phabricator.kde.or

D12090: port the look and feel kcm to new design

mart updated this revision to Diff 31900. mart added a comment. - remove one redundant setCurrentIndex REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12090?vs=31821&id=31900 BRANCH phab/lookandfeelredesign REVISION DETAIL https://phabricator.kd

D12117: handle in the top toolbar

mart added a comment. F5804379: Spectacle.i12765.png F5804381: Spectacle.q12765.png F5804383: Spectacle.n12765.png F5804386: Spectacle.r12765.png

D12117: handle in the top toolbar

mart created this revision. mart added a reviewer: Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY on desktop when using ToolbarApplicationHeader put the drawer handles

D12116: Use const'ref here too

mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mlaurent requested review of this revision. TEST PLAN compile REPOSITORY R104 KScreen BRANCH use_const_ref REVISION DETAIL https://phabricator.kde.org

D12113: Use nullptr. Use const/ref.

This revision was automatically updated to reflect the committed changes. Closed by commit R104:5dbe76009828: Use nullptr. Use const/ref. (authored by mlaurent). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12113?vs=31880&id=31892 REVISION DETAIL https://

D12110: Extract i18n from qml too

This revision was automatically updated to reflect the committed changes. Closed by commit R104:31b72f4ad003: Extract i18n from qml too (authored by mlaurent). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12110?vs=31876&id=31881 REVISION DETAIL https://ph

D12111: Remove unused code.

This revision was automatically updated to reflect the committed changes. Closed by commit R104:0cc080688be5: Remove unused code. (authored by mlaurent). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12111?vs=31877&id=31882 REVISION DETAIL https://phabricat

D12113: Use nullptr. Use const/ref.

mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mlaurent requested review of this revision. TEST PLAN Build REPOSITORY R104 KScreen BRANCH clean_code REVISION DETAIL https://phabricator.kde.org/D121

D10747: Implement zwp_linux_dmabuf_v1

fredrik added a comment. In D10747#237235 , @romangg wrote: > Regarding the "drm_fourcc.h" file: do we want to copy it in KWayland's code base or could we use the system one? It's only available on Linux? In this case could we include it as a du

D12111: Remove unused code.

mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mlaurent requested review of this revision. REPOSITORY R104 KScreen BRANCH remove_unused_plasma REVISION DETAIL https://phabricator.kde.org/D12111 AFFEC

D12110: Extract i18n from qml too

mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mlaurent requested review of this revision. REVISION SUMMARY i18n from qml was not extracted REPOSITORY R104 KScreen BRANCH fix_extract_message REVISION

D12109: Fix clone action (typo in enum)

This revision was automatically updated to reflect the committed changes. Closed by commit R104:c17c08526424: Fix clone action (typo in enum) (authored by mlaurent). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12109?vs=31874&id=31875 REVISION DETAIL http

D12109: Fix clone action (typo in enum)

mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mlaurent requested review of this revision. REVISION SUMMARY We can't clone screen (typo in enum action) TEST PLAN Plug another screen and try to unify it.

D12081: Fix warning

mart added a comment. this actually breaks correct reparenting of items in pages, the sheet in the button gallery goes now on top of the action button. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12081 To: apol, #kirigami, mart Cc: plasma-devel, apol, davidedmu

D12092: Add plasmashell --replace

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e275ca733bb8: Add plasmashell --replace (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12092?vs=31826&id=31863#toc REPOSITORY R120 Plasma Workspace CHANGES SIN

D12086: [OSD] Enforce plain text

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d5a98be7b642: [OSD] Enforce plain text (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12086?vs=31817&id=31862 REVISION DETAIL htt

D12086: [OSD] Enforce plain text

broulik added a comment. > Worth changing, but not cve and urgent release worthy. Agreed. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12086 To: broulik, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

Re: Upcoming CI changes - service disruption

On Tue, Apr 10, 2018 at 10:42 PM, Ben Cooksley wrote: > Hi all, Hi everyone, > > In order to allow for two replacement physical build hosts to be > rotated in and the old ones to be decommissioned, i'm scheduling some > downtime for both the CI system and the Binary Factory tomorrow. > > Assumin

D12088: port the ksplash kcm to the new design

davidedmundson added inline comments. INLINE COMMENTS > mart wrote in main.qml:60 > the onCountChanged connection thinghie it's an hack that serves at startup: > we don't have a signal from listview "i'm done populating" which happens way > after component.oncompleted, so the only way we have i

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 - Build # 238 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.9/238/ Project: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 11 Apr 2018 08:59:12 + Build duration: 3 min 18 sec and counting JUnit

D12088: port the ksplash kcm to the new design

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:60 > redundant given the onCurrentIndexChanged binding above the onCountChanged connection thinghie it's an hack that serves at startup: we don't have a signal from listview "i'm done populating" which happens way af

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 - Build # 237 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.9/237/ Project: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 11 Apr 2018 08:39:12 + Build duration: 9 min 15 sec and counting CONSOLE

D6183: [Digital Clock] Allow copying current date and time to clipboard

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ffa23acf440b: [Digital Clock] Allow copying current date and time to clipboard (authored by bschiffner, committed by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6183?vs=31690&id=31

D12086: [OSD] Enforce plain text

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. All those require locally running code or obviously weird user input to set. So in terms of security its not like the notification issue. Worth changing, but not cve and