D11964: [potd dataengine] Enable development of 3rd-party potd provider plugins

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:da8905fdf2de: [potd dataengine] Enable development of 3rd-party potd provider plugins (authored by kossebau).

D11954: [potd dataengine] Turn prodiver plugin metadata into json files

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:7f9d71b74793: [potd dataengine] Turn prodiver plugin metadata into json files (authored by kossebau). REPOSITORY

D11957: [potd dataengine] De-pimplify potd providers for more simple code

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:4d798e1ba604: [potd dataengine] De-pimplify potd providers for more simple code (authored by kossebau). CHANGED PRIOR

D11978: [potd dataengine] Fix Wikimedia Picture of the Day provider

This revision was automatically updated to reflect the committed changes. Closed by commit R114:9eeba3dc8516: [potd dataengine] Fix Wikimedia Picture of the Day provider (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11978?vs=31440=32019#toc REPOSITORY R114

D12148: update the wallpaper dialog to the new design

broulik added a comment. Now I don't see any wallpapers in the list GridDelegate.qml:63: ReferenceError: view is not defined I did update kdeclarative and kirigami before REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12148 To: mart, #plasma,

D12151: Position output identifiers with respect to scaling factors

This revision was automatically updated to reflect the committed changes. Closed by commit R104:dec95688de59: Position output identifiers with respect to scaling factors (authored by romangg). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D12161: [Kickoff] Support non-square icons

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c8080e5c95a8: [Kickoff] Support non-square icons (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12161?vs=31997=32003 REVISION DETAIL

D12161: [Kickoff] Support non-square icons

ngraham added a comment. How could the VDG ever, //ever// disapprove of an image like that? :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12161 To: broulik, #plasma, #vdg, Fuchs, davidedmundson Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot,

D12161: [Kickoff] Support non-square icons

Fuchs added a comment. happy fox now happy, says thanks :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12161 To: broulik, #plasma, #vdg, Fuchs, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D12161: [Kickoff] Support non-square icons

broulik created this revision. broulik added reviewers: Plasma, VDG, Fuchs. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY You can load custom icons through icon dialog, so

D12151: Position output identifiers with respect to scaling factors

romangg updated this revision to Diff 31984. romangg added a comment. - No scale correction on Wayland - Rename variables REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12151?vs=31978=31984 BRANCH identifierPlacement REVISION DETAIL

D12151: Position output identifiers with respect to scaling factors

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > Is it maybe not necessary at all on Wayland to respect the output scaling factors for the placement? It is not necessary to do anything with scaling on

D12137: Use consistent spacing and units for suffixes in spinboxes

aacid added a comment. is appendix something people would understand? because for me is "the things that kills you if you're unlucky", "the end chapter of a book". REPOSITORY R114 Plasma Addons BRANCH fixsecondssuffix REVISION DETAIL https://phabricator.kde.org/D12137 To: kossebau,

D12151: Position output identifiers with respect to scaling factors

romangg added a comment. Is it maybe not necessary at all on Wayland to respect the output scaling factors for the placement? It's difficult to test because the center placement is not possible anyways. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D12151 To:

D12151: Position output identifiers with respect to scaling factors

romangg created this revision. romangg added reviewers: davidedmundson, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Respect scaling factors for calculation of screen

D12088: port the ksplash kcm to the new design

ngraham added a comment. If the buttons are bound to the edges of the chooser thingy, doesn't that make them jump around and have different positions when the window is horizontally resized? https://bugs.kde.org/show_bug.cgi?id=391910 strikes again... REPOSITORY R119 Plasma Desktop

D12088: port the ksplash kcm to the new design

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > somethign something centre buttons Alternative is to maximise the viewport. There was bug report on the cursors KCM about that, but I can't remember what happened.

D12088: port the ksplash kcm to the new design

mart added a comment. like that, tough i don't like how it makes the code become F5805476: Spectacle.b10847.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12088 To: mart, #plasma, #vdg Cc: abetts, davidedmundson,

D12137: Use consistent spacing and units for suffixes in spinboxes

kossebau added a comment. @davidedmundson Thanks for review. Delaying push of this patch though for now a little, until https://marc.info/?l=kde-i18n-doc=152354758527289=2 ("RFC: Notation of numbers with (physical) units/symbols") has been discussed with a result REPOSITORY R114 Plasma

D12088: port the ksplash kcm to the new design

abetts added a comment. Is there a way that the additional buttons are centered along the bottom edge of the preview? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12088 To: mart, #plasma, #vdg Cc: abetts, davidedmundson, plasma-devel, ragreen, Pitel,

D12148: update the wallpaper dialog to the new design

abetts added a comment. Looks good to me! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12148 To: mart, #plasma, #vdg Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12148: update the wallpaper dialog to the new design

mart added a comment. F5805373: Spectacle.H23326.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12148 To: mart, #plasma, #vdg Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D12148: update the wallpaper dialog to the new design

mart created this revision. mart added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY update the wallpaper dialog to the same design as the new KCMS for

D12146: [Window List] Show pin icon only when in panel

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 391145 FIXED-IN: 5.12.5 TEST PLAN Put window list in

D12090: port the look and feel kcm to new design

mart updated this revision to Diff 31959. mart added a comment. - remove all the useless currentIndex sync REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12090?vs=31900=31959 BRANCH phab/lookandfeelredesign REVISION DETAIL

D12088: port the ksplash kcm to the new design

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:60 > > ou can never be sure that the representation is "completed" as the model > > can change at any moment? > > It must know internally as it has that separate populate and add transition. > > It shouldn't need

D12088: port the ksplash kcm to the new design

mart updated this revision to Diff 31958. mart added a comment. - fix minor warnings REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12088?vs=31956=31958 BRANCH phab/ksplashredesign REVISION DETAIL https://phabricator.kde.org/D12088 AFFECTED

D12088: port the ksplash kcm to the new design

mart updated this revision to Diff 31956. mart added a comment. - remove one redundant setcurrentindex REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12088?vs=31901=31956 BRANCH phab/ksplashredesign REVISION DETAIL

D12137: Use consistent spacing and units for suffixes in spinboxes

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Seems we do this in designer files for QWidget spinboxes too. REPOSITORY R114 Plasma Addons BRANCH fixsecondssuffix REVISION DETAIL