D12173: [Workspace Scripting] Turn "gridUnit" into a property getter function

2018-04-15 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:2082cfcbfa33: [Workspace Scripting] Turn gridUnit into a property getter function (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

2018-04-15 Thread Chris Holland
Zren added a comment. I'm still unsure how to update the dropdown after you download a new plugin. I've moved the "open GHNS window" function in plasma-workspace to `components/shellprivate/wallpaperplugin`, but I've just noticed the dropdown is populated by

D12040: [WIP] Add wallpaperplugin.knsrc + QML function to open GHNS dialog

2018-04-15 Thread Chris Holland
Zren updated this revision to Diff 32247. Zren edited the summary of this revision. Zren added a comment. Move open GHNS window function from Wallpaper.Image to ShellPrivate.WallpaperPlugin REPOSITORY R131 Plasma Wallpapers CHANGES SINCE LAST UPDATE

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

2018-04-15 Thread Chris Holland
Zren updated this revision to Diff 32246. Zren retitled this revision from "[WIP] Add "Get Wallpaper Plugins..." button to Config Desktop dialog" to "Add "Get Wallpaper Plugins..." button to Config Desktop dialog". Zren edited the summary of this revision. Zren added a comment. Change from

D12055: Remove border around menubars

2018-04-15 Thread Nathaniel Graham
ngraham added a comment. In fact, please re-open this. Let's have an actual discussion about this, and sorry for the silence so far... REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D12055 To: zzag, #breeze Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot,

D12055: Remove border around menubars

2018-04-15 Thread Nathaniel Graham
ngraham added a comment. I didn't want to kill this revision, sorry! Just wanted to throw that out there for discussion purposes. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D12055 To: zzag, #breeze Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot,

D12055: Remove border around menubars

2018-04-15 Thread Vlad Zagorodniy
zzag abandoned this revision. zzag added a comment. In D12055#246990 , @ngraham wrote: > In fact, we've got an open request to //add// this line to the Breeze theme for Qt apps... > > https://bugs.kde.org/show_bug.cgi?id=386306 OK, I

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

2018-04-15 Thread Nathaniel Graham
ngraham created this revision. ngraham added a reviewer: Frameworks. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Save the view settings when the user closes the dialog using

D12055: Remove border around menubars

2018-04-15 Thread Nathaniel Graham
ngraham added a comment. In fact, we've got an open request to //add// this line to the Breeze theme for Qt apps... https://bugs.kde.org/show_bug.cgi?id=386306 REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D12055 To: zzag, #breeze Cc: ngraham,

D12055: Delete border around menubars

2018-04-15 Thread Vlad Zagorodniy
zzag added a comment. Ping. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D12055 To: zzag, #breeze Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11909: properly use kpackage_install_package

2018-04-15 Thread Vlad Zagorodniy
zzag added a comment. Ping. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11909 To: zzag, #breeze Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: String freeze exception for Plasma/5.12 (documentation)

2018-04-15 Thread Burkhard Lück
Am Dienstag, 10. April 2018, 23:13:43 CEST schrieb Luigi Toscano: > Hi, > > I'd like to request an exception for the documentation of kcmsmserver in > Plasma/5.12, and namely the backport of this review: > https://phabricator.kde.org/D11817 > > which fixes various references to Plasma instead of

D8626: DDCUtil: Improved DDCUtil support for brightness control

2018-04-15 Thread Dorian Vogel
dvogel updated this revision to Diff 32187. dvogel marked 5 inline comments as done. dvogel added a comment. Applied changes suggested by broulik. CMake fixed, using the checkbox for WITH_DDCUTIL in Kdevelop now works. I must appologise for the long time this is taking. The diff is based