D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

This revision was automatically updated to reflect the committed changes. Closed by commit R135:7b742db8ddfd: Save the dialog view settings when closing the dialog without hitting the… (authored by ngraham). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

sharvey added inline comments. INLINE COMMENTS > davidedmundson wrote in SettingsBase.cpp:82 > > qreal factor = qBound(1.0, > > QGuiApplication::primaryScreen()->devicePixelRatio()/96., 3.0); > > I know you were told to change to this, but don't do that. > > Qt will scale the size you give it

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

sharvey added a comment. In D12252#248478 , @cfeck wrote: > OMG, for whatever reason, I was assuming this is about the file dialog window size. You are working on too many things at once, Nathan :) And don't forget about poor, poor, pitif

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

ngraham added a comment. In D12252#248478 , @cfeck wrote: > OMG, for whatever reason, I was assuming this is about the file dialog window size. You are working on too many things at once, Nathan :) Hehe, if you want to review some of thos

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

cfeck added a comment. OMG, for whatever reason, I was assuming this is about the file dialog window size. You are working on too many things at once, Nathan :) REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D12252 To: sharvey, ngraham, mart, davidedmundson

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > zzag wrote in SettingsBase.cpp:82 > You forgot `const`. > > Also, you could multiply whole QSize by `factor` so Qt will round width and > hei

D12137: Use consistent spacing and units for suffixes in spinboxes

kossebau updated this revision to Diff 32427. kossebau added a comment. try other context pattern: spacing to number + unit REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12137?vs=31945&id=32427 BRANCH fixsecondssuffix REVISION DETAIL https://ph

D12137: Use consistent spacing and units for suffixes in spinboxes

kossebau added a comment. In D12137#245104 , @aacid wrote: > is appendix something people would understand? because for me is "the things that kills you if you're unlucky", "the end chapter of a book". Good question. I run chance of creat

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

ngraham added a comment. In D12252#248458 , @cfeck wrote: > I still object to enforce a minimum size. On my main system, I use a 4K screen, and having a file dialog span nearly the complete screen is irritating, and mostly unusable because I hav

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

cfeck added a comment. I still object to enforce a minimum size. On my main system, I use a 4K screen, and having a file dialog span nearly the complete screen is irritating, and mostly unusable because I have to travel a lot to reach buttons. What is wrong with offering a good default s

D12288: [mediaframe applet] Support creation of widget on file drop on containment

This revision was automatically updated to reflect the committed changes. Closed by commit R114:bf365c818e92: [mediaframe applet] Support creation of widget on file drop on containment (authored by kossebau). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D12287: [mediaframe applet] Fix defunct adding of new files/folder per DnD

This revision was automatically updated to reflect the committed changes. Closed by commit R114:7a0b14bf1313: [mediaframe applet] Fix defunct adding of new files/folder per DnD (authored by kossebau). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12287?

D12288: [mediaframe applet] Support creation of widget on file drop on containment

kossebau created this revision. kossebau added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Depends: D12287 TEST PLAN

D12287: [mediaframe applet] Fix defunct adding of new files/folder per DnD

kossebau added a comment. Target: 5.12 branch (drop not working is a regression compared to plasma4 version, also does applet indicate it supports the drop on hover) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D12287 To: kossebau, #plasma Cc: plasma-devel,

D12287: [mediaframe applet] Fix defunct adding of new files/folder per DnD

kossebau created this revision. kossebau added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY It was broken for 2 reasons: - usage of since-renamed Medi

D12134: [mediaframe applet] Fix broken selection of fill mode

This revision was automatically updated to reflect the committed changes. Closed by commit R114:faa26503b68f: [mediaframe applet] Fix broken selection of fill mode (authored by kossebau). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12134?vs=31941&id=3

D12278: WIP: [Colors KCM] Port to new design

abetts added a comment. Could it be possible, just to agree with the team, to have a small preview of a sample window showing the colors? Something like this: https://macgui.com/downloads/?cat_id=10 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12278 T

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

zzag added a comment. In D12256#248144 , @broulik wrote: > This is master-only code, right? Yes, it's master-only. > The upcoming Plasma 5.13 will depend on KF 5.46 so this should be fine. So, given that, should I bump version or

D12278: WIP: [Colors KCM] Port to new design

ngraham added a comment. > Make the "apply to non Qt apps" checkbox work (no idea why anyone would want to uncheck this, though) Does this setting even still work? I believe support for it is spotty to nonexistent in today's GTK3 apps. I would be in favor of removing the control fro

D12278: WIP: [Colors KCM] Port to new design

ngraham added a comment. It would be really cool if the delegates would show a little preview of a window actually using these colors, instead of the current grid of colored squares. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12278 To: broulik, #plasma,

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

broulik added a comment. This is master-only code, right? The upcoming Plasma 5.13 will depend on KF 5.46 so this should be fine. REPOSITORY R31 Breeze BRANCH drop-QStyleOptionProgressBarV2 REVISION DETAIL https://phabricator.kde.org/D12256 To: zzag, #breeze, hpereiradacosta Cc: davi

D12278: WIP: [Colors KCM] Port to new design

davidedmundson added a comment. > Not too fond of this "Current" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12278 To: broulik, #plasma, #vdg Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D10112: watch the tabletMode from KWin

This revision was automatically updated to reflect the committed changes. Closed by commit R169:ad404dd92962: watch the tabletMode from KWin (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10112?vs=32380&id=32381#toc REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDAT

D10112: watch the tabletMode from KWin

mart updated this revision to Diff 32380. mart added a comment. - Merge branch 'master' into mart/tabletMode - separe isMobile and tabletmode concepts - Merge branch 'master' into mart/tabletMode - use tabletMode instead of isMobile where needed - new env var KDE_KIRIGAMI_TABLET_MODE

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

zzag added subscribers: ngraham, broulik, davidedmundson. zzag added a comment. @davidedmundson @broulik @ngraham Do you have any objections to bumping minimum required version of KF5FrameworkIntegration? //We need at least KF 5.45 so KCapacityBar and co have QStyle::State_Hor

D12277: Fix build with Qt 4

jriddell added a comment. This is to stop the build failure we get on Neon https://build.neon.kde.org/job/xenial_unstable_kde_breeze_bin_amd64/209/console REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D12277 To: fvogt, #breeze, davidedmundson Cc: jriddell, zzag, p

D12278: WIP: [Colors KCM] Port to new design

broulik created this revision. broulik added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Pretty much WIP What works: - Grid layout with crappy t

D12275: FunnelModel: fix invalid model API usage.

dfaure closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12275 To: dfaure, hein, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12277: Fix build with Qt 4

zzag added a comment. OK, nvmd. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D12277 To: fvogt, #breeze, davidedmundson Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12277: Fix build with Qt 4

zzag added a comment. Oh, God, I forgot to check Q_CC_CLANG in Qt 4. Also, that's weird Q_CC_GNU has no value in Qt 4.. http://doc.qt.io/archives/qt-4.8/qtglobal.html#Q_CC_GNU REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D12277 To: fvogt, #breeze, davidedmundso

D12277: Fix build with Qt 4

This revision was automatically updated to reflect the committed changes. Closed by commit R31:f4f7b599aff5: Fix build with Qt 4 (authored by fvogt). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12277?vs=32373&id=32374 REVISION DETAIL https://phabricator.kde

D12277: Fix build with Qt 4

fvogt created this revision. fvogt added a reviewer: Breeze. Restricted Application added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY In Qt 4, the compiler detection macros have no value, so they can't be compared against. So just use the compiler-specific one

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

zzag added a comment. In D12256#247950 , @ltoscano wrote: > Don't you need to raise the requirement to a new Frameworks version, or #ifdefs if it's not possible (as it should probably be coordinated with the rest of the Plasma team)? Is

D12275: FunnelModel: fix invalid model API usage.

dfaure created this revision. dfaure added a reviewer: hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. dfaure requested review of this revision. REVISION SUMMARY The new asserts added in qtbase in commit 00c09e752f (Qt 5.11) are trig

D12274: Add pulleyitem for quick fav feature

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R846:8f804a11d0fc: Add pulleyitem for quick fav feature (authored by Aiix). REPOSITORY R846 Mycroft Plasma integration C

D12274: Add pulleyitem for quick fav feature

Aiix created this revision. Aiix added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Aiix requested review of this revision. REVISION SUMMARY Ref T7175 , T8175

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

sharvey updated this revision to Diff 32368. sharvey added a comment. - Add checking & sizing calc for smaller or rotated screens `availableSize()` returns size minus any size reserved by the window manager for taskbars, etc. Multiply by 0.9 to prevent systemsettings from going "full scr

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

ltoscano added a comment. Don't you need to raise the requirement to a new Frameworks version, or #ifdefs if it's not possible (as it should probably be coordinated with the rest of the Plasma team)? REPOSITORY R31 Breeze BRANCH drop-QStyleOptionProgressBarV2 REVISION DETAIL https://

D12263: [kstyle] don't suppress deprecation warnings

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Hopping I did not miss any dependent revisions. Thanks for cleaning this up . REPOSITORY R31 Breeze BRANCH dont-suppress-deprecated-warnings REVISION DETAIL http

D12261: [kstyle] drop QStyleOptionFrameV3 in Qt 5 style plugin

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Thanks ! REPOSITORY R31 Breeze BRANCH drop-QStyleOptionFrameV3 REVISION DETAIL https://phabricator.kde.org/D12261 To: zzag, #breeze, hpereiradacosta Cc: plasma-dev

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. thanks ! REPOSITORY R31 Breeze BRANCH drop-QStyleOptionProgressBarV2 REVISION DETAIL https://phabricator.kde.org/D12256 To: zzag, #breeze, hpereiradacosta Cc: plas

D12257: [kstyle] drop QStyleOptionTabV3 in Qt 5 style plugin

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Thanks ! REPOSITORY R31 Breeze BRANCH drop-QStyleOptionTabV3 REVISION DETAIL https://phabricator.kde.org/D12257 To: zzag, #breeze, hpereiradacosta Cc: plasma-devel

D12258: [kstyle] drop QStyleOptionTabWidgetFrameV2 in Qt 5 style plugin

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. thanks ! REPOSITORY R31 Breeze BRANCH drop-QStyleOptionTabWidgetFrameV2 REVISION DETAIL https://phabricator.kde.org/D12258 To: zzag, #breeze, hpereiradacosta Cc: p

D12259: [kstyle] drop QStyleOptionViewItemV4 in Qt 5 style plugin

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Thanks ! REPOSITORY R31 Breeze BRANCH drop-QStyleOptionViewItemV4 REVISION DETAIL https://phabricator.kde.org/D12259 To: zzag, #breeze, hpereiradacosta Cc: plasma-

D12262: [kstyle] drop QStyleOptionDockWidgetV2 in Qt 5 style plugin

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Thanks ! REPOSITORY R31 Breeze BRANCH drop-QStyleOptionDockWidgetV2 REVISION DETAIL https://phabricator.kde.org/D12262 To: zzag, #breeze, hpereiradacosta Cc: plasm