D13030: Always display brightness OSD even when at maximum

thsurrel created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY When the brightness is already at the maximum value, hitting the keyboard shortcut to increase i

KDE CI: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 - Build # 5 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/5/ Project: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 22 May 2018 05:48:01 + Build duration: 47 sec and counting CONSOLE

D12973: Workspace KCM Redesign Using Kirigami

ngraham added a comment. Looks gorgeous! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12973 To: furkantokac, ngraham, romangg, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-vault kf5-qt5 FreeBSDQt5.10 - Build # 8 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/8/ Project: Plasma plasma-vault kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 22 May 2018 03:38:36 + Build duration: 6 min 7 sec and counting CONSOLE OUTPUT

D12974: Workspace KCM Code Improvement

davidedmundson added inline comments. INLINE COMMENTS > workspaceoptions.cpp:97 > + > +config->sync(); > } We want to batch our syncs to plasmarc, which the old code did better. I wouldn't bother trying to be clever with checking if it's the original state or not here, as KConfig

D12973: Workspace KCM Redesign Using Kirigami

This revision was automatically updated to reflect the committed changes. Closed by commit R119:78cd8bb31ea3: Workspace KCM Redesign Using Kirigami (authored by furkantokac). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12973?vs=34500&id=34616 REVISI

D13013: Small fixes for execute_kwallet

aacid updated this revision to Diff 34615. aacid added a comment. free fullSocket REPOSITORY R107 KWallet PAM Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13013?vs=34570&id=34615 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13013 AFFECTED FILES

D13013: Small fixes for execute_kwallet

aacid added a comment. In D13013#265868 , @fvogt wrote: > fullSocket was malloc'd by the parent process. free()-ing it is pointless. it's not pointless, it's "unneeded" since the child process will exit on the "cleanup" goto and then all

D12976: Check cmake _FOUND variables for existance

This revision was automatically updated to reflect the committed changes. Closed by commit R838:659ae5f5981c: Check cmake _FOUND variables for existance (authored by heikobecker). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.k

D13001: Handle children of added nodes as well

fvogt added a comment. In D13001#265923 , @lbeltrame wrote: > What's the easiest way to test this? I might just patch the package and see what happens. git clone the repo and load an unpacked extension at the /extension (deactivate/unin

D13001: Handle children of added nodes as well

fvogt updated this revision to Diff 34606. fvogt added a comment. We've officially arrived in callback hell. REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13001?vs=34531&id=34606 BRANCH Plasma/5.13 REVISION DETAIL https://phabricat

D11175: [kstyle] refine shadows

zzag updated this revision to Diff 34595. zzag added a comment. Rebase REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11175?vs=31810&id=34595 BRANCH refine-shadows REVISION DETAIL https://phabricator.kde.org/D11175 AFFECTED FILES kstyle/CMakeLists.tx

D11069: [kdecoration] refine shadows

zzag updated this revision to Diff 34594. zzag added a comment. Rebase REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11069?vs=31809&id=34594 REVISION DETAIL https://phabricator.kde.org/D11069 AFFECTED FILES kdecoration/CMakeLists.txt kdecoration/bree

D11198: [libbreezecommon] add box shadow helper

zzag updated this revision to Diff 34593. zzag added a comment. Rebase REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11198?vs=32789&id=34593 REVISION DETAIL https://phabricator.kde.org/D11198 AFFECTED FILES CMakeLists.txt cmake/Modules/FindFFTW.cmake

D13022: add workspaceoptions docbook

lueck created this revision. lueck added reviewers: Plasma, Documentation. Restricted Application added projects: Plasma, Documentation. Restricted Application added subscribers: kde-doc-english, plasma-devel. lueck requested review of this revision. REVISION SUMMARY in systemsettings it is not

D12990: update mouse kcm docbook to 5.13

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5c1b125ce192: update mouse kcm docbook to 5.13 (authored by lueck). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12990?vs=34564&id=34591 REVISION DETAIL

D12760: Improve single-instance application behavior

volkov closed this revision. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D12760 To: volkov, #plasma, mart Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12960: Drag handle to reorder items in a ListView

mart added a comment. In D12960#265012 , @alex-l wrote: > I tried with arrows too, but I think the fifth one looks better... my second choice is the third one. > > F5858203: immagine.png i like t

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

ngraham closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12969 To: ngraham, #plasma, mart Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D13001: Handle children of added nodes as well

lbeltrame added a comment. What's the easiest way to test this? I might just patch the package and see what happens. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D13001 To: fvogt, #plasma, broulik, davidedmundson Cc: lbeltrame, plasma-devel, rag

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. now became 5.14 for sure, but i think it's safe to go REPOSITORY R119 Plasma Desktop BRANCH no-add-to-panel-as-widget-when-theres-a-task-manager (branched from Plasma/5.13) REVISION DETAI

D13001: Handle children of added nodes as well

broulik added inline comments. INLINE COMMENTS > content-script.js:355 > mutation.addedNodes.forEach(function (node) { > -if (node.tagName === "VIDEO" || node.tagName === "AUDIO") { > -registerPlayer(node); > -} > +i

D12996: Register players when tab becomes audible

broulik abandoned this revision. broulik added a comment. I like Fabian's approach better REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D12996 To: broulik, #plasma, davidedmundson, fvogt Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-m

D13001: Handle children of added nodes as well

broulik added a subscriber: lbeltrame. broulik added a comment. Sweet! I think it used to have this but it caused trouble due to DOM traversal with complex sites. The old code walked the entire DOM every time whereas you just query the node that changed, so shouldn't have that big of an

D13015: use explicit_bzero() if it is present

dakon created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. dakon requested review of this revision. REPOSITORY R107 KWallet PAM Integration REVISION DETAIL https://phabricator.kde.org/D13015 AFFECTED FILES CMakeList

D13013: Small fixes for execute_kwallet

fvogt added a comment. fullSocket was malloc'd by the parent process. free()-ing it is pointless. REPOSITORY R107 KWallet PAM Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D13013 To: aacid, fvogt Cc: anthonyfieroni, mgerstner, fvogt, plasma-devel, ragreen, Pite

D13013: Small fixes for execute_kwallet

anthonyfieroni added inline comments. INLINE COMMENTS > pam_kwallet.c:392 > if (drop_privileges(userInfo) < 0) { > syslog(LOG_ERR, "%s: could not set gid/uid/euid/egit for kwalletd", > logPrefix); > goto cleanup; fullSocket is not free'd. > pam_kwallet.c:398 > if ((

Minutes meeting week 21

Hello, Super small meeting due to some people being off for holiday. Present: notmart, d_ed, romangg, bshah notmart: * some bug triaging * more work on list items drag and drop D12960 (just needs icons now) * fix kirigami build on macos * more work on multi page KCMs * early experiments on

D13013: Small fixes for execute_kwallet

aacid created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY Don't return on error conditions, exit instead. It's a child process we need to finish it Don't use

D13012: Activity switcher auto-hide when using Meta-Tab

thsurrel created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY Commit 174aa217180434ab93b899d9c7cf967bd2daff7e

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

davidedmundson added a comment. Please also fill in the testing done field. INLINE COMMENTS > tooltip.cpp:162 > +dlg->SetAutoShowHide(m_autoShowHide); > +connect(dlg, &ToolTipDialog:.containtsMouseChanged, this, > &ToolTip::toolTipWindowContainsMouseChangedSlot); > dlg->setVisib

D12991: Ensure the salt file is indeed a regular file

aacid closed this revision. REPOSITORY R107 KWallet PAM Integration REVISION DETAIL https://phabricator.kde.org/D12991 To: aacid, fvogt, mgerstner Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

aacid requested changes to this revision. aacid added a comment. This revision now requires changes to proceed. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. The code doesn't merge, and after fixing that manually that the code doesn't build becau

D12990: update mouse kcm docbook to 5.13

lueck updated this revision to Diff 34564. lueck added a comment. add note where to find the setting for click behavior in 5.13 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12990?vs=34506&id=34564 REVISION DETAIL https://phabricator.kde.org/D129

D12991: Ensure the salt file is indeed a regular file

aacid updated this revision to Diff 34563. aacid added a comment. free path REPOSITORY R107 KWallet PAM Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12991?vs=34508&id=34563 BRANCH arcpatch-D12991 REVISION DETAIL https://phabricator.kde.org/D12991 AFFECTED FILE