D13013: Small fixes for execute_kwallet

anthonyfieroni added a comment. It's ok to me. REPOSITORY R107 KWallet PAM Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D13013 To: aacid, fvogt Cc: anthonyfieroni, mgerstner, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterber

D13051: Fix Font KCM force font DPI checkbox

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Fixes numerous issues: 1. the default be

D13050: Allow typing in font DPI spinbox

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Otherwise keyboard use is hard, this fixes a

D13049: It turns out the flickable in a scrollview is the contentItem

apol created this revision. apol added a reviewer: Kirigami. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. TEST PLAN Discover, the gallery still work REPOSITORY R858 Qt Quick Controls 2: Desktop

D12982: Make the new KCMs with QtQuick translatable

aacid added a comment. Plasma people any hint of what are your preferences on fixing this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12982 To: yurchor, #plasma, kde-i18n-doc, ltoscano Cc: aacid, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai

D13013: Small fixes for execute_kwallet

aacid added a comment. @fvogt @anthonyfieroni happy with this new revision? REPOSITORY R107 KWallet PAM Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D13013 To: aacid, fvogt Cc: anthonyfieroni, mgerstner, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezha

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

ngraham added a comment. @lshoravi are you willing and able to address the above-mentioned issues, or should someone else comandeer the revision and do it themselves? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10305 To: lshoravi, #plasma, #pl

D13012: Activity switcher auto-hide when using Meta-Tab

ngraham closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13012 To: thsurrel, mart, ngraham Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 34671. croick marked an inline comment as done. croick added a comment. - check size of socket path REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=34670&id=34671 BRANCH ptracer REVISION DETAIL https://phab

D13012: Activity switcher auto-hide when using Meta-Tab

ngraham accepted this revision. ngraham added a comment. Nice fix. Works for me too. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13012 To: thsurrel, mart, ngraham Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick marked 6 inline comments as done. croick added a comment. Thank you for your comments, totally forgot about licensing. INLINE COMMENTS > maximilianocuria wrote in queryptrace.cpp:26 > Please honour TMPDIR or, even better, use QTemporaryDir (this will also make > the generated path unp

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 34670. croick added a comment. - add license text - use `QDir::tempPath()` - ifdefs to definition REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=30979&id=34670 BRANCH ptracer REVISION DETAIL https://ph

D13015: use explicit_bzero() if it is present

aacid accepted this revision. aacid added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > pam_kwallet.c:181 > > -size_t len; > +size_t len = strlen (str); > +#if HAVE_EXPLICIT_BZERO make it const? REPOSITORY R107 KWallet PAM Integration REVISION

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. @jgrulich @alexeymin please review new framebuffer approach This is the first draft of the implementation. I intend to add more features and fix review comments in the process. Missing features: - Only knows about first screen for now - Doesn't fail

D13030: Always display brightness OSD even when at maximum

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works great for me! @broulik? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D13030 To: thsurrel, ngraham Cc: ngraham, broulik, plasma-devel, ragreen, Pitel,

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias updated this revision to Diff 34665. Kanedias edited the summary of this revision. Kanedias added a comment. Rewrite everything from scratch with Pipewire connectivity in mind REPOSITORY R437 Desktop Sharing CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6096?vs=15147&id=

[Powerdevil] [Bug 362830] Allow lowest brightness when using the brightness down/up buttons

https://bugs.kde.org/show_bug.cgi?id=362830 Nate Graham changed: What|Removed |Added Severity|normal |wishlist CC|

D13031: [ProcessModel] Center more column headings

ngraham added a comment. +1 from me. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D13031 To: broulik, #plasma Cc: ngraham, alex-l, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12974: Workspace KCM Code Improvement

furkantokac updated this revision to Diff 34656. furkantokac added a comment. .qrc file is cancelled. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12974?vs=34652&id=34656 BRANCH kcmworkspace-CodeFormatting REVISION DETAIL https://phabricator.

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

hein added a comment. > The purpose of this patch was to simply hide the standalone launcher functionality a little Isn't it more than "a little" though? What other way to add apps to the panel now remains other than DND, which many people never attempt? > Hmm, I don't see them in g

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

ngraham added a comment. In D12969#266528 , @hein wrote: > Widget-based launchers do have jump lists, fwiw Hmm, I don't see them in git master or in any other version of Plasma that I've ever used. F5864058: No jump list.png

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

hein added a comment. Widget-based launchers do have jump lists, fwiw REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12969 To: ngraham, #plasma, mart Cc: sharvey, Fuchs, hein, mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-moham

D13042: Do not show activity switcher during fast switches

thsurrel created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY When using the keyboard global shortcut to switch quickly between two activities, it does not ma

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

ngraham added a comment. The idea was that nobody who uses a task manager would actually want to create launchers instead of pinning their apps to it. Perhaps that was not totally true, but with Christian's patch, I think it can become even more true, because the patch addresses the case whe

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

Fuchs added a comment. In D12969#266503 , @hein wrote: > > In that case I would honestly argument for dropping Task Manager pinning entirely: I've never entirely liked that it complicates the Task Manager toward doing multiple thin

D12974: Workspace KCM Code Improvement

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > resources.qrc:1 > + > + I don't want this kcm done differently from all the others, i want all modules using the same structure, on disk REPOSITORY R119

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

hein added a comment. > And personally I consider pinning to be activity dependant way more complicated than having both options to pin and have a launcher I'm also very unhappy with this hyper-complicated context menu. It made it in because everyone was getting impatient on this feature

D12974: Workspace KCM Code Improvement

furkantokac updated this revision to Diff 34652. furkantokac added a comment. Changes are done according to feedbacks. For detailed information, please check the commit message. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12974?vs=34499&id=34652

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

sharvey added a comment. As a side note, usage of the terms "kicker" and/or "kickoff" aren't user-friendly at all. They're basically internal names and aren't mentioned in any user-facing text. I'm not trying to hijack the issue; this is just one of those barriers to entry we should try to k

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

ngraham added a comment. Christian's patch allows pinned Task Manager icons to be always visible, yeah. However, if we merge that but reject this, IMHO the situation becomes even more confusing for the average user. I think we really need to focus on the "Simple by default" side of the equat

D12974: Workspace KCM Code Improvement

furkantokac marked 8 inline comments as done. furkantokac added inline comments. INLINE COMMENTS > davidedmundson wrote in workspaceoptions.cpp:97 > We want to batch our syncs to plasmarc, which the old code did better. > > I wouldn't bother trying to be clever with checking if it's the original

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

Fuchs added a comment. Maybe we need to discuss things, especially also with https://phabricator.kde.org/D12463 where I have an interest in, on a broader scale. I agree that both need to exist and have different use cases, personally I think I'd only show the task manager pin in the con

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

hein added a comment. > That's disappointing to hear and a bit frustrating considering that it never came up in the Bugzilla ticket I filed months 3 ago I've never seen that ticket because it was filed against the wrong component and I wasn't CC'd on it. Making sure the relevant maintain

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

ngraham added a comment. That's disappointing to hear and a bit frustrating considering that it never came up in the Bugzilla ticket I filed months 3 ago, and the patch was approved by one Plasma developer and not objected to by another. Can I try to explain my reasoning before we revert it?

D12928: Make Apply/Discard settings prompt consistent with rest of settings

This revision was automatically updated to reflect the committed changes. Closed by commit R101:ac133254b761: Make Apply/Discard settings prompt consistent with rest of settings (authored by broulik). REPOSITORY R101 KHotKeys CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12928?vs=34

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

hein added a comment. I veto this patch, sorry. These are different features and they're both intended to be there. Task Manager pinning is not a replacement for permanent launchers. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12969 To: ngraham, #plasma,

D12957: Show focus rect when CheckBox or RadioButton are focused

broulik closed this revision. broulik added a comment. https://cgit.kde.org/qqc2-desktop-style.git/commit/?id=33681939bde3dbe46ceb225e615ba92d8420db9a REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D12957 To: broulik, #plasma, #vdg, mart,

D11235: [DrKonqi] Request change of ptrace scope from KCrash

maximilianocuria added inline comments. INLINE COMMENTS > queryptrace.cpp:26 > +server.sun_family = AF_UNIX; > +sprintf(server.sun_path, "/tmp/kcrash_%lld", > QCoreApplication::applicationPid()); > +if (::connect(sfd, (struct sockaddr *)&server, sl) == 0) { Please honour TMPDIR or,

D11235: [DrKonqi] Request change of ptrace scope from KCrash

adridg added a comment. Comments directed at licensing and non-Linux cases. INLINE COMMENTS > queryptrace.cpp:1 > +#include > + Missing file header / license bits > queryptrace.cpp:49 > + > +#endif For non-Linuxen, include a null implementation here. > queryptrace.h:1 > +#ifndef QUERYPTR

D12974: Workspace KCM Code Improvement

romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in workspaceoptions.cpp:97 > We want to batch our syncs to plasmarc, which the old code did better. > > I wouldn't bother trying to be clever with checking if it's the original > state or not here, as KConfig will do all of t

D13031: [ProcessModel] Center more column headings

alex-l added a comment. Please provide screenshots when tagging VDG REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D13031 To: broulik, #plasma, #vdg Cc: alex-l, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

[Powerdevil] [Bug 362830] Allow lowest brightness when using the brightness down/up buttons

https://bugs.kde.org/show_bug.cgi?id=362830 Thomas Surrel changed: What|Removed |Added CC||thomas.sur...@protonmail.co |

D13031: [ProcessModel] Center more column headings

broulik created this revision. broulik added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Also horizontally center TTY, Relative Start Time, and CPU Tim

D13001: Handle children of added nodes as well

This revision was automatically updated to reflect the committed changes. Closed by commit R856:0db2416dc351: Handle children of added nodes as well (authored by fvogt). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13001?vs=34606&id=34625

D13030: Always display brightness OSD even when at maximum

thsurrel marked an inline comment as done. thsurrel added inline comments. INLINE COMMENTS > broulik wrote in powerdevilupowerbackend.cpp:406 > Can we be sure that the `currentBrightness` is always up-to-date? We must > still be able to force a new brightness if the hardware forgot to tell us or

D13030: Always display brightness OSD even when at maximum

thsurrel updated this revision to Diff 34624. REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13030?vs=34622&id=34624 REVISION DETAIL https://phabricator.kde.org/D13030 AFFECTED FILES daemon/powerdevilbrightnesslogic.cpp To: thsurrel Cc: broulik, plasm

D13030: Always display brightness OSD even when at maximum

broulik added inline comments. INLINE COMMENTS > powerdevilupowerbackend.cpp:406 > > -setBrightness(newBrightness, controlType); > +if (newBrightness != currentBrightness) { > +setBrightness(newBrightness, controlType); Can we be sure that the `currentBrightness` is always up-t