KDE CI: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.10 - Build # 29 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20FreeBSDQt5.10/29/ Project: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 31 May 2018 04:48:42 + Build duration: 44 sec and counting

D12982: Make the new KCMs with QtQuick translatable

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:738da689cbd2: Make the new KCMs with QtQuick translatable (authored by yurchor). CHANGED PRIOR TO COMMIT

D13178: Compress calls to configuration slots upon new connections

jacopods added a comment. In D13178#270671 , @mart wrote: > are configureKeyboard configureMouse etc doing an immediate write to disk? (like KConfig::sync() Hey notmart, long time no see! The configureKeyboard() method is calling

D13225: Move methods to private class

nicolasfella created this revision. nicolasfella added reviewers: drosca, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R994 Pulseaudio Qt Bindings BRANCH private

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

ngraham added a comment. Indeed, It's nice when we can make everyone happy instead of having someone come away upset. Now if only we could teach this to politicians... REPOSITORY R119 Plasma Desktop BRANCH kickoff_triangle_filter REVISION DETAIL https://phabricator.kde.org/D13192

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

rkflx added a comment. FWIW, testing with users affected by this change, they are happy now. Therefore +1 for how it works. Thanks for implementing this on such short notice. REPOSITORY R119 Plasma Desktop BRANCH kickoff_triangle_filter REVISION DETAIL

D12982: Make the new KCMs with QtQuick translatable

davidedmundson added a comment. > That's different: I see KCMs are libraries, > I think it would be acceptable to use KLocalizedString::setApplicationDomain, even if introduces an exception, but at least not *another* way to set the translation domain. I don't think so for

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. @alexeymin This is a working version but I plan on adding stuff in the coming weekends. Just wanted to make sure there's someone motivated to review and merge this. Thanks for looking at my diffs. REPOSITORY R437 Desktop Sharing REVISION DETAIL

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. 1. Make sure you have latest versions of KWin, XDG-KDE and Pipewire installed 2. Services should be started by DBus-activation, if that doesn't happen by whatever reason, first start `$ pipewire`, then `$ /usr/lib(exec)/xdg-desktop-portal`, it should in turn start

D6096: Add Wayland RemoteAccess capabilities to KRfb

alexeymin added a comment. How exactly I can test if something works? And what are the requirements? PipeWire? Something else? REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson, graesslin, #plasma, #kde_applications Cc:

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

hein added a comment. I'll push after @davidedmundson gives his accept, as the code was reformatted a bit since he last spoke up. REPOSITORY R119 Plasma Desktop BRANCH kickoff_triangle_filter REVISION DETAIL https://phabricator.kde.org/D13192 To: hein, ngraham, davidedmundson,

D13095: Scren brightness follow a quatratic progression

ngraham added a comment. My backlight turns on at 6. It's off at 5. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D13095 To: thsurrel, #plasma, broulik, ngraham Cc: zzag, ngraham, romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D13194: Use the new drag handle in the Language KCM

hein updated this revision to Diff 35209. hein removed a subscriber: zzag. hein added a comment. Implement Vlad's code hygiene suggestions. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13194?vs=35208=35209 BRANCH master REVISION DETAIL

D13194: Use the new drag handle in the Language KCM

zzag added inline comments. INLINE COMMENTS > translations.cpp:97 > > -for (const QString& lang : m_translationsModel->missingLanguages()) { > +for (const QString& lang : > m_selectedTranslationsModel->missingLanguages()) { > m_configuredLanguages.removeOne(lang); Maybe,

D13194: Use the new drag handle in the Language KCM

hein added a comment. Screenshot: F5878558: Screenshot_20180531_030134.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13194 To: hein, mart, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D13194: Use the new drag handle in the Language KCM

hein added a comment. This is now ready for review. With the use of DelegateRecycler, I get many ReferenceErrors from particular the sheet list delegate during scroll: kcmshell5(8088)/default unknown:

D13194: Use the new drag handle in the Language KCM

hein updated this revision to Diff 35208. hein edited the summary of this revision. hein added a comment. Mention the use of DelegateRecycler in the message. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13194?vs=35207=35208 BRANCH master

D13194: Use the new drag handle in the Language KCM

hein updated this revision to Diff 35207. hein edited the summary of this revision. hein added a reviewer: davidedmundson. hein added a comment. - Rewrite model backend to make list drag handle happy. - Use QCollator for available languages. - Code cleanup. REPOSITORY R119 Plasma

D12055: Remove border around menubars

zzag added a comment. In D12055#270987 , @ngraham wrote: > In D12055#270986 , @zzag wrote: > > > @ngraham Also, who maintains Breeze GTK theme? > > > @jackg does, IIRC. Thanks.

D12055: Remove border around menubars

ngraham added a subscriber: jackg. ngraham added a comment. In D12055#270986 , @zzag wrote: > @ngraham Also, who maintains Breeze GTK theme? @jackg does, IIRC. REPOSITORY R98 Breeze for Gtk BRANCH menubar-border REVISION DETAIL

D12055: Remove border around menubars

zzag added a comment. @ngraham Also, who maintains Breeze GTK theme? REPOSITORY R98 Breeze for Gtk BRANCH menubar-border REVISION DETAIL https://phabricator.kde.org/D12055 To: zzag, #breeze, ngraham Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D12055: Remove border around menubars

zzag updated this revision to Diff 35206. zzag added a comment. Delete redundant `border: none;` rules REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12055?vs=31705=35206 BRANCH menubar-border REVISION DETAIL https://phabricator.kde.org/D12055

D12055: Remove border around menubars

ngraham added a comment. I wasn't planning to. :) REPOSITORY R98 Breeze for Gtk BRANCH menubar-border REVISION DETAIL https://phabricator.kde.org/D12055 To: zzag, #breeze, ngraham Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D12055: Remove border around menubars

zzag added a comment. Please, don't land it yet. REPOSITORY R98 Breeze for Gtk BRANCH menubar-border REVISION DETAIL https://phabricator.kde.org/D12055 To: zzag, #breeze, ngraham Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D13220: Add .arcconfig

This revision was automatically updated to reflect the committed changes. Closed by commit R98:c2ff497c6381: Add .arcconfig (authored by zzag, committed by ngraham). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13220?vs=35202=35205 REVISION DETAIL

D13220: Add .arcconfig

zzag added a comment. Nate, please land it on my behalf. (I don't have the Developer account right now) REPOSITORY R98 Breeze for Gtk BRANCH add-arcconfig REVISION DETAIL https://phabricator.kde.org/D13220 To: zzag, #breeze, ngraham Cc: plasma-devel, ragreen, Pitel, ZrenBot,

D13220: Add .arcconfig

zzag created this revision. zzag added a reviewer: Breeze. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R98 Breeze for Gtk BRANCH add-arcconfig REVISION DETAIL

D13202: Circular user avatar for Kickoff

sharvey marked 2 inline comments as done. sharvey added a comment. I don't know if I need to edit `user-manager` to emit a signal of some kind, or if some trigger needs to go over the D-Bus... I'm wading into deep water here. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D13202: Circular user avatar for Kickoff

ngraham added a comment. Yes, we had a report of this: https://bugs.kde.org/show_bug.cgi?id=384107 However the issue I've seen is a genuine regression from your patch: changing my avatar from a file on disk to an image from gallery works without your patch, but fails with it. It

D13202: Circular user avatar for Kickoff

sharvey added a comment. F5878497: Screenshot_20180530_121625.png It appears Kickoff had this problem prior to the circles. I changed my avatar, but un-patched Kickoff now shows the default avatar. I'm not clear why `user-manager` removes the

D12055: Remove border around menubars

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Revisiting this, I think there's value in matching how Breeze does it at even if just for simple consistency's sake. If we ever change Breeze, we can change this back. REPOSITORY R98

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1 for functionality. This makes Kickoff feel so much faster and more responsive now! It's amazing what a difference it makes. And the triangle filter works well to prevent unintentional

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

hein updated this revision to Diff 35194. hein added a comment. Remove some overly noisy stating-the-obvious comments. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13192?vs=35193=35194 BRANCH kickoff_triangle_filter REVISION DETAIL

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

hein updated this revision to Diff 35193. hein added a comment. - Reformat code as per Vlad's suggestions. - Fix Kai's issues. oldPos is indeed `var` because I prefer it over construction an unneded point instance. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D12982: Make the new KCMs with QtQuick translatable

ltoscano added a comment. In D12982#270846 , @davidedmundson wrote: > > is this something that needs to be fixed in kdeclarative > > I don't think so. > This patch seems fine, it's no different to our current state of how applet

D12982: Make the new KCMs with QtQuick translatable

mart added a comment. In D12982#270846 , @davidedmundson wrote: > Accepted, sure. But the QtQuick loading is quite separate from the library here, so I'm not sure it's easy. > > If we want to have QtQuick only KCMs (something I think

D12982: Make the new KCMs with QtQuick translatable

davidedmundson added a comment. > is this something that needs to be fixed in kdeclarative I don't think so. This patch seems fine, it's no different to our current state of how applet translations work following a fixed pot schema. > would a patch to fix this (define the

D13193: Rename kcm_input to kcm_mouse

volkov closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13193 To: volkov, #plasma, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

broulik added a comment. Minor code nitpicks. Tab instant switch makes it feel a lot more responsive but I occasionally managed to accidentally activate the "Apps" tab when opening and moving, not sure how much that could happen in "normal use", though. +1 anyway INLINE COMMENTS >

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

davidedmundson added a comment. From a code POV, +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13192 To: hein, ngraham, davidedmundson, rkflx, cfeck Cc: mart, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

hein added a comment. > Could a different approach work here? No change on hover, but just on click? The user controls the entire action. Can you explain what you dislike about my patch enough that makes you think an entirely different approach is in order, or why you think it fails to

D12055: Remove border around menubars

zzag added a comment. Ping. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D12055 To: zzag, #breeze Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

zzag added a comment. KF 5.47 will be released soon enough so I guess that's OK to ship the code as is. Am I right? REPOSITORY R31 Breeze BRANCH drop-QStyleOptionProgressBarV2 REVISION DETAIL https://phabricator.kde.org/D12256 To:

D13199: Move updateDevice to private class

This revision was automatically updated to reflect the committed changes. Closed by commit R994:65bad933c12c: Move updateDevice to private class (authored by nicolasfella). REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13199?vs=35126=35181

D11909: properly use kpackage_install_package

zzag added a comment. Ping. Also, could someone please explain what's wrong with `kpackage_install_bundled_package`? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11909 To: zzag, #breeze Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot,

D11198: [libbreezecommon] Add box shadow helper

zzag added a comment. Ping. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11198 To: zzag, #breeze, #vdg, hpereiradacosta Cc: broulik, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D13207: [lookandfeel/lockscreen] Hide cursor on login controls fade out

romangg planned changes to this revision. romangg added a comment. In D13207#270731 , @davidedmundson wrote: > In the multiscreen case you have two LockScreenUi files altering the same single property, does it work? You are right, there

D13183: Use Control.palette

This revision was automatically updated to reflect the committed changes. Closed by commit R858:b176593771c2: Use Control.palette (authored by apol). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13183?vs=35154=35179 REVISION

D13207: [lookandfeel/lockscreen] Hide cursor on login controls fade out

davidedmundson added a comment. In the multiscreen case you have two LockScreenUi files altering the same single property, does it work? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13207 To: romangg, #plasma Cc: davidedmundson, mart, broulik,

D13210: [Installation Reminder] Watch for service registration and hide

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > browserintegrationreminder.cpp:129 > > +m_watcher = new QDBusServiceWatcher(s_dbusServiceName, bus, > QDBusServiceWatcher::WatchForRegistration,

D13207: [lookandfeel/lockscreen] Hide cursor on login controls fade out

romangg added inline comments. INLINE COMMENTS > mart wrote in LockScreenUi.qml:72 > shouldn't that mousearea cover the whole area? if cursorshape doesn't work > for a thing that appears under the cursor that's definitely a mousearea bug You are right, that it should cover the whole area, if

D13206: Add context property to hide cursor

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. with a comment on why the workaround, is ok for me REPOSITORY R133 KScreenLocker BRANCH hideCursorProperty REVISION DETAIL https://phabricator.kde.org/D13206 To: romangg, #plasma, mart

D13206: Add context property to hide cursor

romangg updated this revision to Diff 35178. romangg added a comment. - Add comment REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13206?vs=35141=35178 BRANCH hideCursorProperty REVISION DETAIL https://phabricator.kde.org/D13206 AFFECTED FILES

D13202: Circular user avatar for Kickoff

sharvey added a comment. In D13202#270585 , @ngraham wrote: > Looks great now! Quite pleasing to the eye. > > I've got a few blockers though: > > - When I change the icon in the user-manager KCM and re-open Kickoff, the new icon isn't

D13210: [Installation Reminder] Watch for service registration and hide

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY In case the browser takes forever to start or user

D13183: Use Control.palette

mart accepted this revision. mart added a comment. awesome! thanks :) REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH master REVISION DETAIL https://phabricator.kde.org/D13183 To: apol, #kirigami, mart Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D13178: Compress calls to configuration slots upon new connections

mart added a comment. are configureKeyboard configureMouse etc doing an immediate write to disk? (like KConfig::sync() where using timers to compress really saves a lot of time, is to compress the actual disk writes. just writing to kconfiggroup is fast, because it doesn't actually

D10297: Add new "Tools" button above System Monitor's process list

gregormi updated this revision to Diff 35172. gregormi added a comment. > The text should use title case: "Kill a Window" DONE > The parentheses look a bit ugly, in normal menus the shortcuts are simply aligned to the right (not sure how that's done, though). DONE: align the

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

mart added a comment. In D13192#270466 , @abetts wrote: > Could a different approach work here? No change on hover, but just on click? The user controls the entire action. i think the whole point of a start menu is to be fast, to require

D13207: [lookandfeel/lockscreen] Hide cursor on login controls fade out

mart added inline comments. INLINE COMMENTS > romangg wrote in LockScreenUi.qml:72 > The problem was that I first had to move the mouse to enter the MouseArea. > I.e. when the Screenlocker is activated by timer the cursor is visible until > first time the mouse is moved and then the fade out

D12982: Make the new KCMs with QtQuick translatable

ltoscano added a comment. I'd really like to have a clear answer to some questions: - is this something that needs to be fixed in kdeclarative, which makes it impossible to have a proper fix it in 5.13? - would a patch to fix this (define the translation domain in the same way as the

D7087: Add "Copy Info" button to the About System KCM

gregormi updated this revision to Diff 35167. gregormi added a comment. - use auto, add comment REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7087?vs=35165=35167 BRANCH arcpatch-D7087_1 REVISION DETAIL https://phabricator.kde.org/D7087 AFFECTED

D7087: Add "Copy Info" button to the About System KCM

gregormi updated this revision to Diff 35165. gregormi marked 4 inline comments as done. gregormi added a comment. - Handle colon (:) problem for translating and fix one label bug REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7087?vs=35163=35165

D7087: Add "Copy Info" button to the About System KCM

gregormi marked an inline comment as done. gregormi added inline comments. INLINE COMMENTS > rkflx wrote in Module.ui:333-338 > Do you need this? Pressing the Reset button for that property in Qt Designer > removes this for me. If I remove that part, the button gets wider; I would prefer to

D7087: Add "Copy Info" button to the About System KCM

gregormi updated this revision to Diff 35163. gregormi marked 3 inline comments as done. gregormi added a comment. - Fix comment - Clean ui file - Shortcut handling REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7087?vs=35158=35163 BRANCH

D7087: Add "Copy Info" button to the About System KCM

gregormi marked 5 inline comments as done. gregormi added inline comments. INLINE COMMENTS > gregormi wrote in Module.cpp:246 > Yes, I also had the list idea in an earlier stage of the patch< but without > reusing the translated label text. I don't expect the information labels to > change

D7087: Add "Copy Info" button to the About System KCM

gregormi updated this revision to Diff 35158. gregormi marked 2 inline comments as done. gregormi added a comment. - Translate the Distro string - Rename button to 'Copy to Clipboard' for more clarity; and consistency with other applications - Use a QList of QPairs to collect labels and

D7087: Add "Copy Info" button to the About System KCM

gregormi marked an inline comment as done. gregormi added inline comments. INLINE COMMENTS > rkflx wrote in Module.cpp:246 > Probably not strictly required for this patch, but it would be nicer to > refactor this in such a way that adding another string to the UI does not > require adding it