D13274: Make drags from the Task Manager less prone to disaster

ngraham added a comment. The fact that TM entries are draggable outside their panel in the first place is a bit odd in many contexts because most of the time you're going to be looking at apps, not your desktop, and there's nothing you would actually want to or be able to drag them to. So

D13275: Teach ContainmentInterface::processMimeData how to handle Task Manager drops

ngraham added a comment. Hmm, this doesn't build for me (Neon dev unstable, deps built from source): /home/dev/repos/plasma-framework/src/scriptengines/qml/plasmoid/containmentinterface.cpp: In member function 'void ContainmentInterface::processMimeData(QMimeData*, int, int,

D13278: Keep default border value in line with KWin's setting

abetts accepted this revision. abetts added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R31 Breeze BRANCH match-new-kwin-default-border-size (branched from master) REVISION DETAIL https://phabricator.kde.org/D13278 To: ngraham, #breeze, abetts Cc:

D13278: Keep default border value in line with KWin's setting

ngraham created this revision. ngraham added a reviewer: Breeze. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The comment says this should match the default border setting in

D12498: Fully remove `Application Name` from Details panel

ngraham added a comment. I feel like if we go with "missing", users will blame us and we'll get bug reports ("If it's missing, why can't you provide it? Duh!"). My preference, if it's possible, would be to simply omit any fields for which we don't have information available. No need to

D12498: Fully remove `Application Name` from Details panel

bruns added a comment. @sharvey can you address the remaining nitpicks? INLINE COMMENTS > sharvey wrote in AuthDialog.cpp:349 > I was checking to see if this was still open, and would like to discuss > "Missing". I considered "Missing" while I was originally coding this, but > thought it

D13274: Make drags from the Task Manager less prone to disaster

hein created this revision. hein added reviewers: davidedmundson, Zren. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY The Task Manager applet previously set a task's launcher URL as generic URL MIME data of drags initiated from it.

[Powerdevil] [Bug 345618] Powerdevil crash from idle desktop.

https://bugs.kde.org/show_bug.cgi?id=345618 Christoph Feck changed: What|Removed |Added CC||skonjic...@gmail.com --- Comment #13 from

D13273: Fix Recent Applications sorting in Kicker and Dashboard.

hein added a comment. It almost seems so :(. I think the only alternative might be overriding sort() and making it noop, if you'd prefer that. The code was written under the assumption that QSFPM would never start sorting unless sort() was called, but it was sorting anyway,so something

D13273: Fix Recent Applications sorting in Kicker and Dashboard.

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Is that really the only way to disable a sort :/ REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D13273 To: hein,

D13237: Show action.main more prominently on the ToolBarApplicationHeader

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:cf62d95943e8: Show action.main more prominently on the ToolBarApplicationHeader (authored by apol). CHANGED PRIOR TO

D10747: Implement zwp_linux_dmabuf_v1

romangg added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. What's the current state of this patch and the KWin one? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10747 To: fredrik, #kwin, #plasma,

D11198: [libbreezecommon] Add box shadow helper

ngraham added a comment. Oh OK never mind then, ignore me... REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11198 To: zzag, #breeze, #vdg, hpereiradacosta Cc: ngraham, broulik, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D13270: [Mouse KCM] Fix writing selected profile value

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7a03d8d3fab0: [Mouse KCM] Fix writing selected profile value (authored by romangg). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13270?vs=35339=35340

D13270: [Mouse KCM] Fix writing selected profile value

romangg created this revision. romangg added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Wrote the default value resulting in no change at all. BUG:

D13269: Prevent the system from logging out if transactions are pending completion

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:d8c69ba2d613: Prevent the system from logging out if transactions are pending completion (authored by apol).

D11198: [libbreezecommon] Add box shadow helper

zzag added a comment. In D11198#272069 , @ngraham wrote: > Instead of using pure black, how about instead using a slightly lighter dark gray color from the standard breeze color scheme, like Shade Black (35,38,39)? > >

D13269: Prevent the system from logging out if transactions are pending completion

apol created this revision. apol added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY BUG: 318415 REPOSITORY R134 Discover Software Store

D11198: [libbreezecommon] Add box shadow helper

ngraham added a comment. Instead of using pure black, how about instead using a slightly lighter dark gray color from the standard breeze color scheme, like Shade Black (35,38,39)? https://community.kde.org/KDE_Visual_Design_Group/HIG/Color I think that might alleviate some of my

D13237: Show action.main more prominently on the ToolBarApplicationHeader

davidedmundson added a comment. Please remove console.log() REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13237 To: apol, #kirigami, mart, ngraham Cc: davidedmundson, ngraham, plasma-devel, apol, mart, hein

D13202: Circular user avatar for Kickoff

sharvey added a comment. @davidedmundson - could use your input here, please. Your circle shader effect detects a user avatar change, partially - it goes blank. But it doesn't reload `squareFace` despite the fact that all three avatar locations (`~.face`,` ~.face.icon`, and

D10291: Add a recursion blocker in Pointer/TouchInputRedirection::update

romangg requested changes to this revision. romangg added a comment. This revision now requires changes to proceed. When you have time please address my comment. I have to say though that I can't reproduce the crash when hovering over close button in Debug console. REPOSITORY R108 KWin

D6313: Support Icon Scale from Icon naming specification 0.13

davidedmundson added a comment. +1 from me, but wait till after this release tagging REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To: broulik, kde-frameworks-devel, #plasma, #vdg Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette,

D6313: Support Icon Scale from Icon naming specification 0.13

broulik updated this revision to Diff 35318. broulik added a comment. … REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6313?vs=35317=35318 REVISION DETAIL https://phabricator.kde.org/D6313 AFFECTED FILES src/kiconengine.cpp src/kiconengine.h

D6313: Support Icon Scale from Icon naming specification 0.13

broulik updated this revision to Diff 35317. broulik added a comment. - Fix rebase REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6313?vs=34781=35317 REVISION DETAIL https://phabricator.kde.org/D6313 AFFECTED FILES src/kiconengine.cpp

D13210: [Installation Reminder] Watch for service registration and hide

This revision was automatically updated to reflect the committed changes. Closed by commit R856:4f5eeec505e8: [Installation Reminder] Watch for service registration and hide (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13210?vs=35175=35316#toc REPOSITORY R856

D13187: Move "click" and "double click" keywords from Mouse to Workspace KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9dfb3b5c3bd9: Move click and double click keywords from Mouse to Workspace KCM (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13187?vs=35077=35315#toc REPOSITORY R119

D13232: introduce Custom color set

broulik added inline comments. INLINE COMMENTS > kirigamiplugin.cpp:172 > > +//qmlRegisterUncreatableType(uri, 2, 5, > "ThemeOverride", "Cannot create objects of type ThemeOverride, use it as an > attached poperty"); > + What's this? > basictheme.cpp:138 > +

D13260: [Slideshow Wallpaper] Ignore hidden files and folders

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b39522e9e925: [Slideshow Wallpaper] Ignore hidden files and folders (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D13260: [Slideshow Wallpaper] Ignore hidden files and folders

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY They are usually hidden for a reason and shouldn't