D13325: Don't bother loading on non-supported platforms

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Chrome syncs installed extensions across com

D13325: Don't bother loading on non-supported platforms

This revision was automatically updated to reflect the committed changes. Closed by commit R856:272f60c7: Don't bother loading on non-supported platforms (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13325?vs=3550

D13232: introduce Custom color set

mart added inline comments. INLINE COMMENTS > broulik wrote in kirigamiplugin.cpp:172 > What's this? gah, sorry, remains of old attempts > broulik wrote in platformtheme.cpp:314 > Can this lead to issues with non-deterministic setting of properties? Ie. say > `Kirigami.Theme.textColor` is eval

D13232: introduce Custom color set

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:bf90602e90ea: remove dead code (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13232?vs=3551

D13232: introduce Custom color set

mart updated this revision to Diff 35516. mart added a comment. - remove dead code REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13232?vs=35243&id=35516 BRANCH mart/customColors REVISION DETAIL https://phabricator.kde.org/D13232 AFFECTED FILES ex

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

miklosm added inline comments. INLINE COMMENTS > mart wrote in cpu.qml:45 > CPU usage should be removed from the context as this is now used for > different things? It's used for the same things as before. The only change is that this function no longer formats the whole label, just returns th

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

ngraham added a comment. Screenshot please! See https://community.kde.org/Infrastructure/Phabricator#Include_some_screenshots REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12857 To: miklosm, #plasma, mart Cc: ngraham, mart, plasma-devel, ragreen, Pitel, Z

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 35527. furkantokac added a comment. Tapping strings are changed. Natural scrolling string is added. If there is only 1 touchpad, device combobox set to insvisible. ScrollablePage is changed with Page. REPOSITORY R119 Plasma Desktop CHANGES SINCE

D13331: Don't overflow around popups

apol created this revision. apol added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. TEST PLAN Saw it overflow when putting a ListView in a Popup, doesn't happen anymore.

D13141: Touchpad KCM Redesign Using Kirigami

romangg requested changes to this revision. romangg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.qml:101 > +enabled: touchpadCount > 1 > +visible: touchpadCount > 1 // Invisible if there is only 1 > touchpad device > +

D13334: When using a different background color, use highlightedText as text color

apol updated this revision to Diff 35531. apol added a comment. Use better logic REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13334?vs=35530&id=35531 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13334 AFFECTED FILES src/controls/pr

D13334: When using a different background color, use highlightedText as text color

apol added a comment. F5889702: buttontextcolor.png F5889704: buttontextcolordark.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13334 To: apol, #kirigami, mart Cc: plasma-devel,

D13334: When using a different background color, use highlightedText as text color

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Make sure we are using a color designed to contrast with a backgro

D13334: When using a different background color, use highlightedText as text color

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Awesome, much better! REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D13334 To: apol, #kirigami, mart, ngraham Cc: ngraham, plasma-devel, apol,

D13334: When using a different background color, use highlightedText as text color

colomar added a comment. Perfect! REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D13334 To: apol, #kirigami, mart, ngraham Cc: colomar, ngraham, plasma-devel, apol, davidedmundson, mart, hein

D13336: Check for option->styleObject before accessing it

broulik created this revision. broulik added reviewers: Plasma, hpereiradacosta, cfeck. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 395028 FIXED-IN: 5.12.6 TEST PLAN

D13334: When using a different background color, use highlightedText as text color

abetts added a comment. Looks great! I don't have any suggestions. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D13334 To: apol, #kirigami, mart, ngraham Cc: abetts, colomar, ngraham, plasma-devel, apol, davidedmundson, mart, hein

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 35545. furkantokac added a comment. Combobox is always visible. Combobox manual resizing is removed. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13141?vs=35527&id=35545 BRANCH arcpatch-D13141 REVISION

D13141: Touchpad KCM Redesign Using Kirigami

ngraham added a comment. If we're keeping the combobox on top, it needs to be wide enough to show the full string. Otherwise it's not only functionally useless 99.99% of the time, it's also uninformative. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13141

D13141: Touchpad KCM Redesign Using Kirigami

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.qml:200 > +id: middleEmulation > +text: i18n("Clicking left and right for middle button") > + "Press left and right buttons for

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 35554. furkantokac added a comment. Combobox is expanded. MiddleEmulayion string is changed. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13141?vs=35545&id=35554 BRANCH arcpatch-D13141 REVISION DETAIL

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

miklosm added a comment. In D12857#273608 , @ngraham wrote: > Screenshot please! See https://community.kde.org/Infrastructure/Phabricator#Include_some_screenshots Screenshots of how the network monitor looks like on a vertical panel: Be

D13141: Touchpad KCM Redesign Using Kirigami

ngraham accepted this revision. ngraham added a comment. Looks grand now! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13141 To: furkantokac, ngraham, romangg, abetts Cc: esedgh, knambiar, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jen

D13141: Touchpad KCM Redesign Using Kirigami

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13141 To: furkantokac, ngraham, romangg, abetts Cc: esedgh, knambiar, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13141: Touchpad KCM Redesign Using Kirigami

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:dd1244d66766: Touchpad KCM Redesign Using Kirigami (authored by furkantokac). REPOSITORY R119 Plasma Desktop CHANGE

Re: Stepping down as maintainer for breeze/oxygen kstyle and deco

El diumenge, 3 de juny de 2018, a les 21:20:29 CEST, Hugo Pereira Da Costa va escriure: > Title says it all. > > No need for long explanations, I am just not enjoying it any more. > Time to move on, sorry. Thanks for all the work you did. Hope you enjoy the next thing :) Cheers, Albert > >

D13334: When using a different background color, use highlightedText as text color

apol updated this revision to Diff 35576. apol added a comment. Don't set the color if it's transparent REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13334?vs=35531&id=35576 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13334 AFFECTED