D13372: Mouse KCM Redesign Using Kirigami

furkantokac added a comment. If everyone is happy and the patch is tested, I'll push the code after a last test for Wayland and Xorg. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13372 To: furkantokac, ngraham, romangg, mart Cc: safaalfulaij, mart,

D13372: Mouse KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 35926. furkantokac added a comment. After a discussion, decided to go back to V0.2 because of some UI issues. Bug reports will be filed about the issues. For now, we'll use qqc1. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D13372: Mouse KCM Redesign Using Kirigami

furkantokac added a comment. Just realized that paddings look bad in QQC2. Any recommendation ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13372 To: furkantokac, ngraham, romangg, mart Cc: safaalfulaij, mart, plasma-devel, ragreen, Pitel, ZrenBot,

D13372: Mouse KCM Redesign Using Kirigami

furkantokac added inline comments. INLINE COMMENTS > main.qml:251 > +id: accelProfileFlat > +Kirigami.FormData.label: i18n("Acceleration profile:") > +text: i18n("Flat") This label doesn't show up. If we put it to Column, it shows up vertically

D13372: Mouse KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 35908. furkantokac added a comment. V0.3 - QtQuickControls version is updated to 2.0. Some code cleaning. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13372?vs=35809=35908 BRANCH arcpatch-D13372

D13255: Make dependency on KF5NetworkManagerQt optional

ivan added a comment. Very nice, thanks. If you want I can accept this (after the `Q_UNUSED` change) and I'll do the UI patch separately. INLINE COMMENTS > service.cpp:53 > +{ > +(void)enabled; > +} You should use `Q_UNUSED` instead. REPOSITORY R845 Plasma Vault

D13255: Make dependency on KF5NetworkManagerQt optional

asturmlechner updated this revision to Diff 35896. asturmlechner added a comment. Update addressing 2/3 points raised REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13255?vs=35291=35896 BRANCH master REVISION DETAIL

D12827: Added process details in the process list context menu

chrisx updated this revision to Diff 35891. chrisx added a comment. F5902596: Screenshot_20180609_224923.png F5902597: Screenshot_20180609_224936.png Added detailed memory information to the new process

D13372: Mouse KCM Redesign Using Kirigami

romangg added inline comments. INLINE COMMENTS > main_deviceless.qml:120 > +id: accelSpeed > +//anchors.verticalCenter: parent.verticalCenter > + rm line if you don't need it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13372 To:

D13372: Mouse KCM Redesign Using Kirigami

furkantokac added a comment. In D13372#275788 , @safaalfulaij wrote: > Small question, why we're not using QQC2-based controls? Thanks! New diff is coming with QQC2-based controls. REPOSITORY R119 Plasma Desktop REVISION DETAIL

KDE CI: Plasma kwin kf5-qt5 SUSEQt5.10 - Build # 42 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20SUSEQt5.10/42/ Project: Plasma kwin kf5-qt5 SUSEQt5.10 Date of build: Sat, 09 Jun 2018 13:24:32 + Build duration: 1 min 55 sec and counting CONSOLE OUTPUT [...truncated

D13433: Introduce ActionToolbar

mart added a comment. In D13433#275932 , @davidedmundson wrote: > Did you fix your binding loop? yeah.. now its size hints are slightly oversized to accomodate the optional extra "..." button, which is not 100% optimal but since buttons