D8267: Correcting symlinks between col- and row-resize and split_v and _hBug 384864

2018-06-14 Thread Jack Ostroff
ostroffjh added a comment. Fixed those two symlinks and updated the diff. Anything else blocking this? REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D8267 To: ostroffjh, #plasma, apol Cc: tfoster, apol, asturmlechner, cfeck, plasma-devel, ragreen, Pitel,

D8267: Correcting symlinks between col- and row-resize and split_v and _hBug 384864

2018-06-14 Thread Jack Ostroff
ostroffjh updated this revision to Diff 36177. ostroffjh added a comment. - Merge branch 'master' into fixlinks - fix cursors/src/symlinks/col-resize and .../row-resize Updating D8267: Correcting symlinks between col- and row-resize and split_v and _h

D12498: Fully remove `Application Name` from Details panel

2018-06-14 Thread Stefan Brüns
bruns added a comment. In D12498#278422 , @ngraham wrote: > Looks good to me, though the string needs to make clear that the bug report should go to the 3rd-party app developer, not to us! Otherwise we'll get a bunch of un-actionable bugs.

D12498: Fully remove `Application Name` from Details panel

2018-06-14 Thread Nathaniel Graham
ngraham added a comment. Looks good to me, though the string needs to make clear that the bug report should go to the 3rd-party app developer, not to us! Otherwise we'll get a bunch of un-actionable bugs. REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL

D12498: Fully remove `Application Name` from Details panel

2018-06-14 Thread Stefan Brüns
bruns added a comment. In D12498#278380 , @ngraham wrote: > Ah yeah, that makes sense. Instead of "Missing", how about "Not available; please file a bug with the developer of this software" ...Or something like that. Somewhat to

D12498: Fully remove `Application Name` from Details panel

2018-06-14 Thread Nathaniel Graham
ngraham added a comment. Ah yeah, that makes sense. Instead of "Missing", how about "Not available; please file a bug with the developer of this software" ...Or something like that. REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D12498 To:

D12278: WIP: [Colors KCM] Port to new design

2018-06-14 Thread Andres Betts
abetts added a comment. Ping? Is this KCM doing alright? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12278 To: broulik, #plasma, #vdg Cc: mart, abetts, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D12498: Fully remove `Application Name` from Details panel

2018-06-14 Thread Stefan Brüns
bruns added a comment. In D12498#278285 , @ngraham wrote: > This concept (and the proposed label) is suitable for a developer audience, not a regular user audience. > > We have the same issue in Discover when upstreams don't ship enough

D12498: Fully remove `Application Name` from Details panel

2018-06-14 Thread Nathaniel Graham
ngraham added a comment. In D12498#278282 , @bruns wrote: > In D12498#272379 , @ngraham wrote: > > > I feel like if we go with "missing", users will blame us and we'll get bug reports ("If it's

D13529: [minimizeAll] Do not try to restore window state on model change

2018-06-14 Thread Anthony Fieroni
anthonyfieroni updated this revision to Diff 36160. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13529?vs=36142=36160 REVISION DETAIL https://phabricator.kde.org/D13529 AFFECTED FILES applets/minimizeall/package/contents/ui/main.qml To:

D12498: Fully remove `Application Name` from Details panel

2018-06-14 Thread Stefan Brüns
bruns added a comment. In D12498#272379 , @ngraham wrote: > I feel like if we go with "missing", users will blame us and we'll get bug reports ("If it's missing, why can't you provide it? Duh!"). Its simple "We can not provide it because

D13095: Scren brightness follow a quatratic progression

2018-06-14 Thread Nathaniel Graham
ngraham added a comment. Lowest setting: $ cat /sys/class/backlight/intel_backlight/actual_brightness 0 Next setting: $ cat /sys/class/backlight/intel_backlight/actual_brightness 2 Same values as `/sys/class/backlight/*/brightness`, in other words. REPOSITORY

D13529: [minimizeAll] Do not try to restore window state on model change

2018-06-14 Thread David Edmundson
davidedmundson added a comment. Sounds better. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D13529 To: anthonyfieroni, davidedmundson, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13529: [minimizeAll] Do not try to restore window state on model change

2018-06-14 Thread Anthony Fieroni
anthonyfieroni added a comment. On previous version onStackingOrderChanged will not restore windows state, it just stops the effect. So onActiveTaskChanged to replace onDataChanged? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D13529 To: anthonyfieroni,

D13433: Introduce ActionToolbar

2018-06-14 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R169:fd8fb834843c: remove the dead code (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13433?vs=35847=36143#toc REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D13529: [minimizeAll] Do not try to restore window state on model change

2018-06-14 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I'm happy to admit there's a bug there, but just removing the code isn't fixing it. Now you're restoring windows as soon as any property, such as a download

D13529: [minimizeAll] Do not try to restore window state on model change

2018-06-14 Thread Anthony Fieroni
anthonyfieroni created this revision. anthonyfieroni added reviewers: davidedmundson, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY onDataChanged: some cases

D13433: Introduce ActionToolbar

2018-06-14 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > ActionToolBar.qml:31 > + * > + * @inherits RowLayout > + * @since 2.5 No it doesn't? REPOSITORY R169 Kirigami BRANCH mart/actiontoolbar REVISION DETAIL https://phabricator.kde.org/D13433 To: mart, #kirigami, hein Cc: apol,

KDE CI: Plasma plasma-desktop kf5-qt5 SUSEQt5.10 - Build # 92 - Still unstable!

2018-06-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20SUSEQt5.10/92/ Project: Plasma plasma-desktop kf5-qt5 SUSEQt5.10 Date of build: Thu, 14 Jun 2018 08:02:24 + Build duration: 16 min and counting JUnit Tests

Re: KDE CI: Dependency Build Extragear kf5-qt5 SUSEQt5.9 - Build # 106 - Failure!

2018-06-14 Thread Ben Cooksley
On Tue, Jun 12, 2018 at 11:12 PM, Ben Cooksley wrote: > Can someone please look into and correct this breakage please? > > We've recently had a Binary Incompatible system update rollout (thanks Qt > private interfaces) so getting this fixed quickly is rather important. > > If Plasma no longer

[kwin] autotests/integration: Disable unit test which fails to compile on the CI system.

2018-06-14 Thread Ben Cooksley
Git commit e6cdf966ff10d875ceaf65c85356ed7732b585a4 by Ben Cooksley. Committed on 14/06/2018 at 08:00. Pushed by bcooksley into branch 'master'. Disable unit test which fails to compile on the CI system. This test is blocking the ability of the CI system to return to service for Extragear

KDE CI: Plasma plasma-desktop kf5-qt5 SUSEQt5.10 - Build # 91 - Still Failing!

2018-06-14 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20SUSEQt5.10/91/ Project: Plasma plasma-desktop kf5-qt5 SUSEQt5.10 Date of build: Thu, 14 Jun 2018 05:58:08 + Build duration: 1 min 59 sec and counting CONSOLE OUTPUT