D13717: Implement Seek() and Seeked()

broulik added inline comments. INLINE COMMENTS > content-script.js:177 > +if (activePlayer) { > +if (!(activePlayer.seekable.length > 0)) { > +console.warn("Got seek command, but player is not seekable"); Please avoid negating a longer statement, this makes the code hard

D13788: Use Pin/Unpin also for window tasks when there's only one activity

broulik added inline comments. INLINE COMMENTS > ContextMenu.qml:486 > > -checkable: true > - > -text: i18nc("Toggle action for showing a launcher button while the > application is not running", "&Pin") > +text: (isPinned ? i18nc("Action for removing the launcher button

D13772: Add AppStream metadata

mak added a comment. In D13772#284459 , @ngraham wrote: > FWIW, @mak, `appstrealcli validate` doesn't like my launchable tag, though I can't see anything wrong with it. > > dev@dev-pc:~/repos/ksysguard$ (appstream-metadata) appstreamcli va

D13788: Use Pin/Unpin also for window tasks when there's only one activity

ngraham added a comment. +1 conceptually, and works fine for me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13788 To: hein, broulik Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13788: Use Pin/Unpin also for window tasks when there's only one activity

hein created this revision. hein added a reviewer: broulik. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Previously it used a checkable/toggle action, while launcher tasks used Pin/Unpin. This is more consistent, and it means there's

D13745: Implement support for virtual desktops on Wayland

hein updated this revision to Diff 36857. hein added a comment. - Make WaylandTasksModel::requestVirtualDesktops treat the passed-in list as exhaustive. - Fix how an empty list is treated. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13745?vs=

D13717: Implement Seek() and Seeked()

mokhtari added a comment. Regarding loops with the Media Player widget, I haven't noticed any (using KDE Neon, 5.13.1). What test would catch this? INLINE COMMENTS > broulik wrote in content-script.js:177 > The `seekable` property isn't an int but a `TimeRanges` object that tells you > whic

D13785: Use i18np for a plural string

This revision was automatically updated to reflect the committed changes. Closed by commit R134:d70256447042: Use i18np for a plural string (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13785?vs=36853&id=36855 REVISION

D13717: Implement Seek() and Seeked()

mokhtari updated this revision to Diff 36854. mokhtari added a comment. Fixed seekable check. REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13717?vs=36634&id=36854 REVISION DETAIL https://phabricator.kde.org/D13717 AFFECTED FILES e

D13785: Use i18np for a plural string

ngraham created this revision. ngraham added a reviewer: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Use `i18np()` even though this string will always

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. @jgrulich thanks a lot! I'll address these on weekend REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson, graesslin, #plasma, #kde_applications Cc: zzag, jgrulich, alexeymin, plasma-devel, ragreen, Pite

D13772: Add AppStream metadata

ngraham added a comment. FWIW, @mak, `appstrealcli validate` doesn't like my launchable tag, though I can't see anything wrong with it. dev@dev-pc:~/repos/ksysguard$ (appstream-metadata) appstreamcli validate gui/org.kde.ksysguard.appdata.xml W - org.kde.ksysguard.appdata.xml:org.

D13772: Add AppStream metadata

ngraham updated this revision to Diff 36839. ngraham marked 6 inline comments as done. ngraham added a comment. Address review comments REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13772?vs=36805&id=36839 BRANCH appstream-metadata (branched from mast

D13742: Make sure d is deleted

This revision was automatically updated to reflect the committed changes. Closed by commit R169:76044af3057d: Make sure d is deleted (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13742?vs=36700&id=36834 REVISION DETAIL https://phabricat

D13776: Move remaining salt file operations into unprivileged processes

fvogt updated this revision to Diff 36827. fvogt added a comment. Fix rebase error REPOSITORY R107 KWallet PAM Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13776?vs=36826&id=36827 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13776 AFFECTED FILES

D13776: Move the salt file existence check into the unprivileged process

fvogt updated this revision to Diff 36826. fvogt added a comment. Rebase on master - this only makes sense with the user privileges salt file reading. REPOSITORY R107 KWallet PAM Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13776?vs=36815&id=36826 BRANCH master

D13772: Add AppStream metadata

apol added inline comments. INLINE COMMENTS > org.kde.ksysguard.appdata.xml:15 > + https://userbase.kde.org/KSysGuard > + type="homepage">https://www.kde.org/applications/system/ksysguard > + `https://www.kde.org/donate.php?app=org.kde.ksysguard` REPOSITORY R106 KSysguard REVISION D

D13774: [QDBusMenuBar] Guard m_window with a QPointer

This revision was automatically updated to reflect the committed changes. Closed by commit R135:73eeda3a7dfb: [QDBusMenuBar] Guard m_window with a QPointer (authored by broulik). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D13774: [QDBusMenuBar] Guard m_window with a QPointer

broulik updated this revision to Diff 36819. broulik added a comment. - Always update `m_window` `QPointer` still needed. Could be refactored to also unregister on destruction but that requires storing the `WId` separately as in `QObject::destroyed` the `~QWindow` already ran and as such

D13774: [QDBusMenuBar] Guard m_window with a QPointer

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. In reviewing I found a quirky bit of code: void QDBusMenuBar::handleReparent(QWindow *newParentWindow) { if (newParentWindow && newParentWindow != m_window)

D13776: Move the salt file existence check into the unprivileged process

fvogt created this revision. fvogt added reviewers: Plasma, aacid. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. fvogt requested review of this revision. REVISION SUMMARY Otherwise the salt is always recreated on with ~ on NFS with root_

D13770: Only show available ports in port selection

drosca added a comment. I don't think hiding it makes sense, indicating that it is unavailable/unplugged as pavucontrol does is enough. User should see that pulse knows about those ports, but they are just not plugged so if user choose them, it won't play audio. REPOSITORY R115 Plasma Au

Deadline to submit a talk to ELC EU is nearly upon us

Hello, A brief reminder that, if you are working on anything related to mobile or embedded, the ELC EU, conference (organised by the Linux Foundation) would like to hear from you. https://www.linuxfoundation.org/blog/last-chance-to-speak-at-open-source-summit-and-elc-openiot-summit-europe-submi