D14303: [SubCategoryPage] Use binding for back button color

This revision was automatically updated to reflect the committed changes. Closed by commit R124:de80e8d30a2b: [SubCategoryPage] Use binding for back button color (authored by broulik). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14303?vs=38265&id=38

D14285: Fix Kickoff compact repr size hints in panel

This revision was automatically updated to reflect the committed changes. Closed by commit R119:664865f12bc7: Fix Kickoff compact repr size hints in panel (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14285?vs=38290&id=38305 REVISI

D14325: Remove Advanced section from screen config

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY There was only one option hidden behind the andvanced section,

D14325: Remove Advanced section from screen config

gladhorn added a comment. F6134344: kcm_resfresh_before.png F6134347: kcm_refresh_after.png REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14325 To: gladhorn, #plasma Cc: plasma-devel, ra

D14326: Fix layout of resolution selection

gladhorn created this revision. gladhorn added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY The resolution slider or combo added extra spacing, which i

D14326: Fix layout of resolution selection

gladhorn added a comment. F6134401: kcm_res_bef.png F6134403: kcm_res_aft.png F6134405: kcm_resfresh_before.png F6134408: kcm_refresh_after.png

D14326: Fix layout of resolution selection

zzag added a comment. How does it look with the slider? Off-topic: Is the slider a good idea from UX/UI perspective? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14326 To: gladhorn, #plasma, #vdg Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, al

D14326: Fix layout of resolution selection

broulik added a comment. The slider case after looks misaligned here now. I think you should set margins to zero only for the ComboBox case where there is only that single widget? F613: Screenshot_20180724_122521.png REPOSITORY R104 KScreen RE

D14326: Fix layout of resolution selection

broulik added a comment. > How does it look with the slider? There's screenshots. This patch is solely about the margins, not the fact that it uses a slider or combobox > Off-topic: Is the slider a good idea from UX/UI perspective? That is why it uses a `QComboBox` if there are

D14328: Fix pre-selected refresh rate

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY When we determine to show a refresh rate, it should rather be t

Calculator

Hy Plasma Team, I use the calculator mini program and I would like to suggest an improvement. It would be nice if I could copy numbers from e.g. a website to the calculator input field then make a calculation and afterwards copy the resulting number form the calculator to e.g. an editor. Thanks,

Re: Virtual Desktop and Activities future: Merging proposal

On Mon, Jul 16, 2018 at 11:47 PM David Edmundson wrote: > - If someone else wants to add new effects/pagers that group/filter VDs they > should be able to. > (like Michails quite cool mockups and stuff) I don't think that requires any > changes in the VD protocol to do so, and we definitely sho

D14325: Remove Advanced section from screen config

andreaska added a comment. Will be useful. Can you make the dropdown items all the same size. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14325 To: gladhorn, #plasma, #vdg Cc: andreaska, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterb

D14328: Fix pre-selected refresh rate

This revision was automatically updated to reflect the committed changes. Closed by commit R104:61ebc0208396: Fix pre-selected refresh rate (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14328?vs=38320&id=38330 REVISION DETAIL https:

D14228: Make OSD buttons' accessible

This revision was automatically updated to reflect the committed changes. Closed by commit R104:9431bd13fb24: Make OSD buttons' accessible (authored by gladhorn). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14228?vs=38075&id=38331#toc REPOSITORY R104 KScreen CHANGES SINCE LAST UPDA

D14229: Make OSD buttons' accessible

gladhorn abandoned this revision. gladhorn added a comment. This was a duplicate. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14229 To: gladhorn, #plasma Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D14225: Use hideOsd function instead of its code copied

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:ea63b2ce6dbf: Use hideOsd function instead of its code copied (authored by gladhorn). REPOSITORY R104 KScreen CHANG

D14143: Make the action selector OSD independent of the other OSDs

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:5238ae3a7251: Make the action selector OSD independent of the other OSDs (authored by gladhorn). CHANGED PRIOR TO COMM

D14165: Handle keyboard in action selector OSD

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:bb6c51b0e858: Handle keyboard in action selector OSD (authored by gladhorn). CHANGED PRIOR TO COMMIT https://phabric

D14224: Make kcm size hint bigger

gladhorn abandoned this revision. gladhorn added a comment. I'm unsure how to really fix this in a sensible way. Abandoning this for now. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14224 To: gladhorn, #plasma, ngraham Cc: ngraham, plasma-devel, ragreen, Pitel, Z

D14326: Fix layout of resolution selection

gladhorn added a comment. In D14326#296857 , @broulik wrote: > The slider case after looks misaligned here now. I think you should set margins to zero only for the ComboBox case where there is only that single widget? > F613: Screenshot_2

D14325: Remove Advanced section from screen config

gladhorn added a comment. I can play with the drop-down sizes in a follow up change. To keep reviews as easy as possible, I prefer to make minimal changes with less chance of breakage :) I'm unsure about how wide the combo boxes should be though, taking the full width would make them look

D14325: Remove Advanced section from screen config

ngraham added a comment. Approved; having a single item under an Advanced section didn't make much sense. Also, in the next patch we can use a nice simple `QFormLayout` for everything here, which is good because the misalignment of the Resolution ComboBox is driving me bananas! :) REPOSITOR

D14325: Remove Advanced section from screen config

gladhorn added a comment. @ngraham https://phabricator.kde.org/D14326 fixes the alignement of the combo box, it's unrelated to using a form layout. REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.kde.org/D14325 To: gladhorn, #plasma, #vdg, ngraham Cc: ngrah

D14325: Remove Advanced section from screen config

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Don't explicitly mess with the combobox sizes; just use a `QFormLayout` and let it handle that for you. REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.k

D14325: Remove Advanced section from screen config

This revision was automatically updated to reflect the committed changes. Closed by commit R104:51c93ef1f9eb: Remove Advanced section from screen config (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14325?vs=38315&id=38338 REVISION DE

D14326: Fix layout of resolution selection

ngraham added a comment. In D14326#296957 , @gladhorn wrote: > In D14326#296857 , @broulik wrote: > > > The slider case after looks misaligned here now. I think you should set margins to zero only f

D14325: Remove Advanced section from screen config

abetts added a comment. +1 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14325 To: gladhorn, #plasma, #vdg, ngraham Cc: abetts, ngraham, andreaska, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14326: Fix layout of resolution selection

abetts added a comment. +1 on the visual changes! REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14326 To: gladhorn, #plasma, #vdg Cc: abetts, ngraham, broulik, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14326: Fix layout of resolution selection

abetts added a comment. In D14326#296853 , @gladhorn wrote: > F6134401: kcm_res_bef.png F6134403: kcm_res_aft.png F6134417: kcm_resolution_before.png

D14326: Fix layout of resolution selection

gladhorn added a comment. In D14326#297016 , @abetts wrote: > In D14326#296853 , @gladhorn wrote: > > > F6134401: kcm_res_bef.png F6134403: kcm_res_aft.png

D14326: Fix layout of resolution selection

abetts added a comment. In D14326#297020 , @gladhorn wrote: > In D14326#297016 , @abetts wrote: > > > In D14326#296853 , @gladhorn wrote: > > > > > F613

D14326: Fix layout of resolution selection

andreaska added a comment. The thing is that you should bring more focus to the screen factor setting. Ordinary you should not change the screen resolution you should change the factor on hidpi this should be in focus. Nobody should change the resolution and the rate by default cause best r

D14326: Fix layout of resolution selection

gladhorn added a comment. OK, so shall we discuss the general KCM in https://phabricator.kde.org/T7254 or https://phabricator.kde.org/T4066 or https://phabricator.kde.org/T3464 ? all of them seem to be duplicates, but I don't know how to handle that. REPOSITORY R104 KScreen REVISION DETAI

D14335: Make astronomical Plasma plugin JSON consistent with other plugins and translatable

yurchor created this revision. yurchor added reviewers: Plasma, Localization. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. yurchor requested review of this revision. REVISION SUMMARY Currently, JSON file has a structure which is not par

D14335: Make astronomical Plasma plugin JSON consistent with other plugins and translatable

ltoscano added a comment. Adding @kossebau with the question: is there a reason to not have the KPlugin key in the json file? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D14335 To: yurchor, #plasma, #localization, kossebau Cc: ltoscano, plasma-devel, ragree

D14336: Make calendar Plasma plugin JSON consistent with other plugins and translatable

yurchor created this revision. yurchor added reviewers: Plasma, Localization, mck182. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. yurchor requested review of this revision. REVISION SUMMARY Currently, JSON file has a structure which is

D14335: Make astronomical Plasma plugin JSON consistent with other plugins and translatable

kossebau added a comment. TD;LR current legacy-based implementation might need that format. Needs complete tested porting to KPlugin. I had blindly copying the only other-known-to-me existing plugin data, which also has that metadata schema. Cmp. also https://phabricator.kde.org/sour

D14336: Make calendar Plasma plugin JSON consistent with other plugins and translatable

kossebau added a comment. See https://phabricator.kde.org/D14335#297096 might need other changes to the plugin to make it a real kplugin format. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14336 To: yurchor, #plasma, #localization, mck182 Cc: kossebau,

D14326: Fix layout of resolution selection

ngraham added a comment. Let's centralize the discussion in T7254 . I've closed the other two. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14326 To: gladhorn, #plasma, #vdg Cc: andreaska, abetts, ngraham, broulik, zzag, plasma-

Re: Calculator

Hi Markus, Please file a bugzilla ticket at bugs.kde.org to request this new feature. The product is "kdeplasma-addons" FWIW, a slightly easier way to accomplish what you want to do today is to use KRunner, which has a built-in calculator that accepts pasted text at least. Nate On Thu,

D14338: Fix preview widget appearing to scale twice

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY It worked when I wrote it against integer scaling, it got broken when fractional sup

D14339: Remove confusing icons from rotation combobox

gladhorn created this revision. gladhorn added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY Right now there is an icon associated with each rotation, b

D14339: Remove confusing icons from rotation combobox

gladhorn updated this revision to Diff 38350. gladhorn added a comment. Accidentally added new ui file, thanks arc :( REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14339?vs=38349&id=38350 BRANCH master REVISION DETAIL https://phabricator.kde.org/D143

D14339: Remove confusing icons from rotation combobox

gladhorn added a comment. Before, with the icons: F6135574: kcm_rot_before.png Without: F6135577: kcm_rot_after.png Comments appreciated, maybe these should be buttons, but imho this is a low-hanging fr

D14326: Fix layout of resolution selection

gladhorn added a comment. @abetts see D14339 for the icons. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14326 To: gladhorn, #plasma, #vdg Cc: andreaska, abetts, ngraham, broulik, zzag, plasma-devel, ragreen, Pitel, ZrenBot, l

D14326: Fix layout of resolution selection

gladhorn added a comment. In the meantime, I'd like opinions on this change, I'm still a big fan of small steps in the right direction which will reach users soon, since I'm unsure if the big re-design will be implemented in the near future. REPOSITORY R104 KScreen REVISION DETAIL https

D14339: Remove confusing icons from rotation combobox

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Hmm, instead of removing them, I'd prefer if we used better icons. Maybe like that little icon of a mountain and a sun within a frame that we already have--but rotated. Wit

Re: Virtual Desktop and Activities future: Merging proposal

So, if I understood this correctly, KAMD keeps a list of activities, and a list of VDs which are usually mapped 1-1, but could also be 1-n. Adding an activity would mean adding a VD (just one by default). Removing an activity would mean removing all VDs for that activity. This could be (I think)

Re: Virtual Desktop and Activities future: Merging proposal

On Tue, Jul 24, 2018 at 8:37 PM Ivan Čukić wrote: > There is one question, though. Do the new VDs support showing a window > on two different VDs? the wayland protocol can associate windows on any subset of vds, yes -- Marco Martin

D14340: [Multimedia KCM] Kill PulseAudio device setup

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It is redundant with plasma-pa TEST PLAN (I wish we could just

Re: Virtual Desktop and Activities future: Merging proposal

What to do with X11? I don't like the idea that we have two completely different behaviours for W and X. Cheers, Ivan

D14339: Remove confusing icons from rotation combobox

abetts added a comment. In D14339#297211 , @ngraham wrote: > Hmm, instead of removing them, I'd prefer if we used better icons. Maybe like that little icon of a mountain and a sun within a frame that we already have--but rotated. > > With no

D14338: Fix preview widget appearing to scale twice

This revision was automatically updated to reflect the committed changes. Closed by commit R104:5c45d27f00b4: Fix preview widget appearing to scale twice (authored by davidedmundson). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14338?vs=38348&id=38354 REVI

D14326: Fix layout of resolution selection

ngraham added a comment. I agree. +1 on how it looks with a combobox. Is there any way to manually remove resolutions so I can get it to use a slider and test that case? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14326 To: gladhorn, #plasma, #vdg Cc: andreaska,

D14340: [Multimedia KCM] Kill PulseAudio device setup

nicolasfella added a comment. Looks like we had the same thought again :D D13935 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14340 To: broulik, #plasma Cc: nicolasfella, plasma-devel, ragreen, Pitel, ZrenBot, lesliezha

D14250: Sort update items by completion

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Sorry for the long delay in reviewing. I gave this a shot with a huge batch of 400 updates on Neon. It was a //huge// improvement in user experience. It's hard to express how much better

D14307: Changed refresh time from 30 to 60 seconds

This revision was automatically updated to reflect the committed changes. Closed by commit R114:9eae090a3038: Changed refresh time from 30 to 60 seconds (authored by piotrkakol, committed by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14307?

D12946: Single/Double Click Option at Workspace KCM

ngraham added a comment. In D12946#295395 , @rooty wrote: > hey guys, resident grammar nazi reporting :D > it says Click Behaviour (british spelling), and the rest of the module uses Behavior (american spelling) > a great idea otherwise

D14339: Remove confusing icons from rotation combobox

ngraham added a comment. Something like this set: F6136542: view-preview0.png F6136543: view-preview90.png F6136544: view-preview180.png F6136545: view-preview27

D14347: Fix blocky text on splash screen when using non-integer scale factor

ngraham created this revision. ngraham added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The Qt bug that makes `Text.NativeRendering` look t

D14347: Fix blocky text on splash screen when using non-integer scale factor

broulik added inline comments. INLINE COMMENTS > Splash.qml:91 > +// https://bugreports.qt.io/browse/QTBUG-67007 > +renderType: Screen.devicePixelRatio % 1 !== 0 ? > Text.QtRendering : Text.NativeRendering > anchors.verticalCenter: parent.vertical

D14349: Clean up casts

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D

D14350: Make sure for loop does not detach

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D

D14351: Remove unused variables

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D

D14352: Use fuzzy compare for floats

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D

D14353: Improve alignment of types

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D

D14339: Remove confusing icons from rotation combobox

gladhorn added a comment. In D14339#297233 , @abetts wrote: > In D14339#297211 , @ngraham wrote: > > > Hmm, instead of removing them, I'd prefer if we used better icons. Maybe like that little icon