D14746: [Style KCM] Use "configure" icon

ngraham added a comment. Retroactive +1! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14746 To: broulik, #plasma, ngraham, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14751: [Shell Corona] Don't create ScriptingEngine if there are no update scripts

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f326b1435a71: [Shell Corona] Don't create ScriptingEngine if there are no update scripts (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

smithjd added a comment. In D14739#306749 , @davidedmundson wrote: > We also have > > system settings -> shortcuts -> standard shortcuts > > These can have alternatives which would work for this. I don't know if these work with QQC2 Text

D14751: [Shell Corona] Don't create ScriptingEngine if there are no update scripts

broulik created this revision. broulik added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It takes almost 30ms here to create the engine and then we us

D14746: [Style KCM] Use "configure" icon

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8ed77e53af33: [Style KCM] Use "configure" icon (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14746?vs=39459&id=39474 REVISION DETAIL

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

davidedmundson added a comment. We also have system settings -> shortcuts -> standard shortcuts These can have alternatives which would work for this. I don't know if these work with QQC2 TextFields, we should fix it if not. Thanks for kconfig magic you can override them (withou

D14737: Move "update" button from the left side to the right side in NIC module

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. What branch did you make this patch against? It doesn't apply for me against master: error: while searching for: m_list->setHeaderLabels(columns); QH

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

smithjd added a comment. Most of the keys on that side of the keyboard are already bound globally into combos, so the best solution IMO is to intercept the required keycombos in KRunner instead of having to rearrange the global app keycombos around KRunner. This is what this patch does to im

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Sorry, I'm with Kai on this, aspecially because one of the proposed new shortcuts conflicts with an existing shortcut that it's possible to use here. REPOSITORY R120 Plasma Wo

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

broulik added a comment. You can't and I don't see why you can't just use Home/End. Sorry. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14739 To: smithjd, #plasma Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

smithjd added a comment. Yes, except the CTRL + S combo is default for save in other applications, with no easy way I can think of to reassign it for just KRunner. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14739 To: smithjd, #plasma Cc: broulik, plasm

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

broulik added a comment. I don't understand. Also, you can change the default shortcut from Home/End to whatever you like. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14739 To: smithjd, #plasma Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliez

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

smithjd added a comment. I now see that KDE has default application shortcuts for beginning of line and end of line (HOME and END) and skip word forwards or backwards (CTRL + RARROW/LARROW), that also work in KRunner, that should obsolete this patch. REPOSITORY R120 Plasma Workspace REVIS

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

smithjd added a comment. I tend to frequenty hit additional keys while not watching the runner window. Although the shortcut is no longer in common with Bash (the CTRL + S shortcut would also have made more sense for Bash) the idea is the same. You can already do this from the keyboard, but

D14737: Move "update" button from the left side to the right side in NIC module

schampailler added a comment. > I know you merely moved it but when you're touching it anyway... :) thx for noting; my spare time is quite finite :-) Now : - `KGuiItem` has nothing like refresh/update... - `KStandardAction`

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

broulik added a comment. Can you explain the rationale behind this? Since you've seemingly randomly changed the shortcut, it doesn't seem like a "common" shortcut sheme? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14739 To: smithjd, #plasma Cc: broulik,

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

smithjd updated this revision to Diff 39467. smithjd added a comment. - [KRunner] Change start of line shortcut to CTRL + S. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14739?vs=39437&id=39467 BRANCH master-krunnerbashkeybindings (branched fr

D14737: Move "update" button from the left side to the right side in NIC module

abetts added a comment. +1 REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D14737 To: schampailler, ngraham Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14746: [Style KCM] Use "configure" icon

broulik created this revision. broulik added reviewers: Plasma, grahamperrin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 397358 FIXED-IN: 5.12.7 TEST PLAN F6187233:

D14737: Move "update" button from the left side to the right side in NIC module

broulik added a comment. Shouldn't it rather be called "Reload" with the appropriate icon? Checkout `KStandardAction` or `KGuiItem` REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D14737 To: schampailler, ngraham Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBo

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

broulik added a comment. Ctrl+A is reserved for "Select All" REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14739 To: smithjd Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart