D14869: [RFC] Increase default font sizes by 1 pt

2018-08-15 Thread Andres Betts
abetts added a comment. In D14869#309824 , @ngraham wrote: > In D14869#309821 , @abetts wrote: > > > I like the way this looks, I would like to push it further for clarity and ask for window title

KDE CI: Plasma ksysguard kf5-qt5 SUSEQt5.10 - Build # 26 - Fixed!

2018-08-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20ksysguard%20kf5-qt5%20SUSEQt5.10/26/ Project: Plasma ksysguard kf5-qt5 SUSEQt5.10 Date of build: Thu, 16 Aug 2018 01:42:55 + Build duration: 1 min 46 sec and counting JUnit Tests Name:

D14807: [AppStream Runner] Also search when there were errors during Pool::load

2018-08-15 Thread Stefan Brüns
bruns added a comment. Citing from https://community.kde.org/Policies/Commit_Policy#Commit_complete_changesets > OTOH, commits should be preferably "atomic" - not splittable. That means that every bugfix, feature, refactoring or reformatting should go into an own commit. This, too,

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-15 Thread Chris Rizzitello
rizzitello added a comment. The title bar with the bold font looks nice at both sizes. > Reduced text density (obviously) Our defaults are not very dense so the loss of density is only going to be bad, except for the case of small screens. On those its more then reasonable to

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-15 Thread Nathaniel Graham
ngraham added a comment. In D14869#309821 , @abetts wrote: > I like the way this looks, I would like to push it further for clarity and ask for window title at 13 and bold. I feel people stand to benefit from seeing a window title that is

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-15 Thread Andres Betts
abetts added a comment. I like the way this looks, I would like to push it further for clarity and ask for window title at 13 and bold. I feel people stand to benefit from seeing a window title that is readable, especially when we have a dark color background default. REPOSITORY R119

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-15 Thread David Edmundson
davidedmundson added a comment. This isn't the only place this needs changing, but we can sort that out if/when the concept gets accepted. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14869 To: ngraham, #plasma, #kde_applications, valorie, #vdg Cc:

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-15 Thread Chris Rizzitello
rizzitello added a comment. Honestly if you look at the last before and after shot the text now looks worse then when it was 10 pt. I think the issue is more your hinting then the font size. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14869 To: ngraham,

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-15 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Plasma, KDE Applications. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY We discussed the idea of increasing the font sizes by 1 pt at the VDG BoF at

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

2018-08-15 Thread James Smith
smithjd added a comment. Perhaps the intent of this patch could change to adding a KShortcutsDialog to the kcm where the MOVETOSTARTOFLINE and MOVETOENDOFLINE keyboard shortcuts could be reassigned? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14739

D14863: [kconf_update] Add "gtk-primary-button-warps-slider=0" to generated GTK3 config

2018-08-15 Thread Wolfgang Bauer
This revision was automatically updated to reflect the committed changes. Closed by commit R98:f5121ba89abf: [kconf_update] Add gtk-primary-button-warps-slider=0 to generated GTK3 config (authored by wbauer). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE

D14863: [kconf_update] Add "gtk-primary-button-warps-slider=0" to generated GTK3 config

2018-08-15 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Oops, what an oversight. :) This fixes the issue, thanks. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D14863 To: wbauer, #breeze, #plasma, ngraham Cc:

D14863: [kconf_update] Add "gtk-primary-button-warps-slider=0" to generated GTK3 config

2018-08-15 Thread Wolfgang Bauer
wbauer created this revision. wbauer added reviewers: Breeze, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. wbauer requested review of this revision. REVISION SUMMARY This brings the default GTK3 settings more in line with Qt's behavior, and it's also the

D14807: [AppStream Runner] Also search when there were errors during Pool::load

2018-08-15 Thread Stefan Brüns
bruns added a comment. In D14807#309460 , @apol wrote: > This is outright weird, please send just one patch with the feature and the logging and without the wrong lines. Which wrong lines? Why should I squash the commits? Each one:

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

2018-08-15 Thread Alexander Volkov
volkov updated this revision to Diff 39790. volkov added a comment. update device statistics only when it's shown REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14835?vs=39698=39790 BRANCH master REVISION DETAIL

D14807: [AppStream Runner] Also search when there were errors during Pool::load

2018-08-15 Thread Aleix Pol Gonzalez
apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Please squash all changes REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14807 To: bruns, #plasma, apol Cc: apol, plasma-devel, ragreen, Pitel,

D14807: [AppStream Runner] Also search when there were errors during Pool::load

2018-08-15 Thread Aleix Pol Gonzalez
apol added a comment. This is outright weird, please send just one patch with the feature and the logging and without the wrong lines. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14807 To: bruns, #plasma Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot,

D14804: [AppStream Runner] Pass on error message from the library

2018-08-15 Thread Aleix Pol Gonzalez
apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Please squash all changes REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14804 To: bruns, #plasma, apol Cc: plasma-devel, ragreen, Pitel, ZrenBot,

D14806: [AppStream Runner] Reduce verbosity of log output

2018-08-15 Thread Aleix Pol Gonzalez
apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Please squash all changes REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14806 To: bruns, #plasma, apol Cc: apol, plasma-devel, ragreen, Pitel,

D14805: [AppStream Runner] Use categorized logging

2018-08-15 Thread Aleix Pol Gonzalez
apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Please squash all changes REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14805 To: bruns, #plasma, apol Cc: plasma-devel, ragreen, Pitel, ZrenBot,

D14806: [AppStream Runner] Reduce verbosity of log output

2018-08-15 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM, maybe commit once only? xD REPOSITORY R120 Plasma Workspace BRANCH appstream_runner_3 REVISION DETAIL https://phabricator.kde.org/D14806 To: bruns, #plasma, apol Cc: apol,

D14857: Label job notifications with destination file name

2018-08-15 Thread Karthik Periagaram
karthikp updated this revision to Diff 39781. karthikp added a comment. Done! Thanks, I'm not confident in my javascript powers... yet. :) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14857?vs=39775=39781 REVISION DETAIL https://phabricator.kde.org/D14857 AFFECTED FILES

D14857: Label job notifications with destination file name

2018-08-15 Thread Kai Uwe Broulik
broulik added a comment. Thanks for your patch and explanation on the mailing list! The idea was mostly to show "which file it is currently copying" but I can see there are more cases where the source is weird than to where the destination is wrong? I'll add VDG to get some

D14855: Add applet with screen layouts and presentation mode

2018-08-15 Thread Andres Betts
abetts added a comment. On the first string I would change the wording: "Configurations become enabled when another screen is connected" The second string could read: "It will prevent the screen from turning off" (automatically = optional) REPOSITORY R104 KScreen REVISION

Help fixing minor issue in notifications

2018-08-15 Thread Karthik Periagaram
Hello everyone, I need some help in fixing this bug[1]. I have the plasma-browser integration add-on enabled in my browser and when downloading from places like google drive or similar file upload/sharing websites, the notification in the system tray is structured like this, Downloading

D14855: Add applet with screen layouts and presentation mode

2018-08-15 Thread Kai Uwe Broulik
broulik updated this revision to Diff 39779. broulik added a comment. - Use "application enforce presentation mode" to communicate better that the checkbox might be overruled REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14855?vs=39763=39779 REVISION

D14857: Label job notifications with destination file name

2018-08-15 Thread Karthik Periagaram
karthikp created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. karthikp requested review of this revision. REVISION SUMMARY If a destination file name is present, it is a better label for a job than the source file name. This is particularly true for

KDE CI: Plasma kwin kf5-qt5 SUSEQt5.10 - Build # 156 - Still Failing!

2018-08-15 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20SUSEQt5.10/156/ Project: Plasma kwin kf5-qt5 SUSEQt5.10 Date of build: Wed, 15 Aug 2018 09:05:24 + Build duration: 10 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma plasma-workspace kf5-qt5 SUSEQt5.10 - Build # 86 - Still Failing!

2018-08-15 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.10/86/ Project: Plasma plasma-workspace kf5-qt5 SUSEQt5.10 Date of build: Wed, 15 Aug 2018 08:19:27 + Build duration: 2 min 30 sec and counting CONSOLE

D14855: Add applet with screen layouts and presentation mode

2018-08-15 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG, fischbach. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY One of LiMux client's requirements is for display configuration to be easily