D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action

phuongn updated this revision to Diff 40619. phuongn added a comment. Correct the erroneous logic for determining the next and previous desktop index REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14989?vs=40555&id=40619 REVISION DETAIL https:/

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

phuongn updated this revision to Diff 40618. phuongn added a comment. Correct the erroneous logic for determining the next and previous desktop index REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14988?vs=40549&id=40618 REVISION DETAIL https://p

D15011: [Kickoff] Make the search field always look like a search field

filipf added a comment. Aside from that, the outer glow should maybe be reconsidered on the whole. I don't see much of that visual element these days; it was trendy about 10 years ago and really feels like a bit of Oxygen in Breeze. I think just having a colored border when focused would suf

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

ngraham added a comment. BTW, you can do the `OpacityMask` inline, like so: Image { id: faceIcon source: kuser.faceIconUrl [...] layer.enabled: true layer.effect: OpacityMask { // this Rectangle is a circle due to radius size

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

ngraham added a comment. Perhaps this is a clue. With or without your patch, every single time I change the icon in user-manager, plasmashell immediately prints the following to the console: file:///usr/share/plasma/plasmoids/org.kde.plasma.kickoff/contents/ui/Header.qml:55:5: QML Im

D15011: [Kickoff] Make the search field always look like a search field

ngraham added a comment. Note that I just landed the Widget Explorer patch, so I'll update the table accordingly. In D15011#316875 , @romangg wrote: > What's up with the third column "Search field visibly focused by default"? That me

D15011: [Kickoff] Make the search field always look like a search field

romangg added a comment. What's up with the third column "Search field visibly focused by default"? My personal opinion is it should not have the blue outline just because it looks too strong. But consistency trumps looks. At the moment it's not though from what I read out of the table.

D15101: [Widget Explorer] always show the search field

This revision was automatically updated to reflect the committed changes. Closed by commit R119:491137007c11: [Widget Explorer] always show the search field (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15101?vs=40511&id=40586 R

D15101: [Widget Explorer] always show the search field

ngraham added a comment. Thanks David! REPOSITORY R119 Plasma Desktop BRANCH widget-explorer-always-shows-search-field (branched from master) REVISION DETAIL https://phabricator.kde.org/D15101 To: ngraham, sharvey, #vdg, abetts, #plasma, davidedmundson Cc: abetts, sharvey, plasma-deve

KDE CI: Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.11 - Build # 2 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20kdeplasma-addons%20kf5-qt5%20FreeBSDQt5.11/2/ Project: Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.11 Date of build: Tue, 28 Aug 2018 21:32:05 + Build duration: 2 min 25 sec and counting

KDE CI: Plasma kdeplasma-addons stable-kf5-qt5 FreeBSDQt5.11 - Build # 2 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20kdeplasma-addons%20stable-kf5-qt5%20FreeBSDQt5.11/2/ Project: Plasma kdeplasma-addons stable-kf5-qt5 FreeBSDQt5.11 Date of build: Tue, 28 Aug 2018 21:30:50 + Build duration: 1 min 37 sec and counting

D15124: [POTD] Actually update the image every day

ngraham closed this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D15124 To: ngraham, #plasma, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15011: [Kickoff] Make the search field always look like a search field

ngraham added a comment. To wrap up, I think this patch is ready for review again, and we'll tackle the separator lines in another patch for atomicity's sake. Does that sound good to everyone? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham

D15101: [Widget Explorer] always show the search field

ngraham added a comment. Can I get a review from someone on the #plasma team before I land this? REPOSITORY R119 Plasma Desktop BRANCH widget-explorer-always-shows-search-field (branched from master) REVISION DETAIL https://phabricator.kde.org

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

zzag added inline comments. INLINE COMMENTS > zzag wrote in main.qml:130 > I think it should be `Math.min`. Also, maybe `repeater.count - 1`. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14988 To: phuongn, #plasma, #vdg, davidedmundson Cc: zzag, ngraham, abe

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

zzag added inline comments. INLINE COMMENTS > main.qml:130 > +(pagerModel.currentPage + 1) % repeater.count : > +Math.max(pagerModel.currentPage + 1, repeater.count); > +pagerModel.changePage(nextPage); I think it should be `Math.min`. > m

D15130: make mycroftplasmoidplugin translatable

lueck updated this revision to Diff 40577. lueck added a comment. Add a new line at the end of the file to make Krazy happy REPOSITORY R846 Mycroft Plasma integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15130?vs=40574&id=40577 REVISION DETAIL https://phabricator.kde.

D15130: make mycroftplasmoidplugin translatable

yurchor accepted this revision as: yurchor. yurchor added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > Messages.sh:2 > +#! /usr/bin/env bash > +$XGETTEXT *.cpp *.h -o $podir/mycroftplasmoidplugin.pot Add a new line at the end of the file to make Krazy happy

D15130: make mycroftplasmoidplugin tarnslatable

lueck created this revision. lueck added reviewers: Plasma, Localization, Aiix. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. lueck requested review of this revision. REVISION SUMMARY add Messages.sh for extraction load the catalog TEST PLAN extraction works REPO

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

abetts added a comment. In D14988#316672 , @ngraham wrote: > I think the terminology "wraps around" is fine. Seems pretty clear to me. Cool, let's go with that. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.o

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

ngraham added a comment. I think the terminology "wraps around" is fine. Seems pretty clear to me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14988 To: phuongn, #plasma, #vdg, davidedmundson Cc: ngraham, abetts, davidedmundson, broulik, plasma-devel, ragr

D13591: Set complete vectors instead of creting them at runtime

This revision was automatically updated to reflect the committed changes. Closed by commit R31:c671ea190645: Set complete vectors instead of creting them at runtime (authored by tcanabrava). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13591?vs=36515&id=40562

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

phuongn added a comment. F6220957: image.png Currently there is already "Desktop navigation wraps around" option for Virtual Desktops, which serve exact same purpose as this patch, but only for keyboard shortcut. I used "Page navigation wraps arou

D13591: Set complete vectors instead of creting them at runtime

davidedmundson added a comment. heh, if you reopen it, I'll approve it REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D13591 To: tcanabrava, #breeze, #plasma Cc: davidedmundson, ngraham, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterb

D13591: Set complete vectors instead of creting them at runtime

tcanabrava abandoned this revision. tcanabrava added a comment. Seems there's nobody to review. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D13591 To: tcanabrava, #breeze, #plasma Cc: ngraham, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, je

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

abetts added a comment. In D14988#316633 , @phuongn wrote: > Hi, it's just the default desktop changing effect. Activated by scrolling with the cursor hovering on the pager. I haven't changed the effect, just added an option to toggle page wrapp

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

phuongn added a comment. Hi, it's just the default desktop changing effect. Activated by scrolling with the cursor hovering on the pager. I haven't changed the effect, just added an option to toggle page wrapping F6220920: simplescreenrecorder-2018-08-28_17.44.42.mp4

D15124: [POTD] Actually update the image every day

kossebau resigned from this revision. kossebau added a comment. Sorry, no time for Plasma, no maintainer here. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D15124 To: ngraham, #plasma, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-

D15124: [POTD] Actually update the image every day

ngraham created this revision. ngraham added reviewers: Plasma, kossebau, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch adjusts the dirty condition so that the image is actually upda

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

abetts added a comment. Could you please put a video or gif that shows the effect? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14988 To: phuongn, #plasma, #vdg, davidedmundson Cc: abetts, davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, les

D15121: Kirigami ages are required for kcms

abetts added a comment. I prefer "allows you to configure" REPOSITORY R115 Plasma Audio Volume Applet BRANCH mart/newkcm REVISION DETAIL https://phabricator.kde.org/D15121 To: mart, #plasma, davidedmundson Cc: abetts, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, le

D14695: disable title for QML kcms

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.cpp:309 > +if (module && module->realModule()->inherits("KCModuleQml")) { > +page->setHeaderVisible(false); > +

D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action

phuongn updated this revision to Diff 40555. phuongn added a comment. Use standard min max functions to make code more readable for desktopswitch no-wrap option REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14989?vs=40192&id=40555 REVISION DETAI

D15121: Kirigami ages are required for kcms

ngraham added inline comments. INLINE COMMENTS > main.qml:34 > property QtObject sourceModel: SourceModel { } > - > -acceptedButtons: Qt.NoButton > -implicitWidth: units.gridUnit * 30 > -implicitHeight: units.gridUnit * 30 > - > ConfigModule.quickHelp: i18n("This module allo

D14581: support for multilevel kcms

davidedmundson added inline comments. INLINE COMMENTS > ModuleView.cpp:178 > // Create the scroller > +QWidget *mainWidget = new QWidget( this ); > +QVBoxLayout *layout = new QVBoxLayout( mainWidget ); why? > ModuleView.cpp:225 > page->setIcon( QIcon::fromTheme( moduleInfo->ic

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

phuongn updated this revision to Diff 40549. phuongn marked an inline comment as done. phuongn added a comment. Utilize Math methods (min, max) to make the code more readable REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14988?vs=40188&id=40549 REV

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

phuongn marked an inline comment as done. phuongn added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:130 > would > > var nextPage = plasmoid.configuration.wrapPage? > (pagerModel.currentPage + 1) % repeater.count : > Math.max(page

D15121: Kirigami ages are required for kcms

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Please fix typo in commit message REPOSITORY R115 Plasma Audio Volume Applet BRANCH mart/newkcm REVISION DETAIL https://phabricator.kde.org/D15121 To: mart, #plasma,

D15121: Kirigami ages are required for kcms

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY adapt to the new multilevel stuff as it's needed for qml kcms to inherit in some shape Kirigami.Page in o

D13907: [SDDM Theme] Set sourceSize on background image

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. marking as requests info till I get a reply. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13907 To: broulik, #plasma, davided

D6455: position the shellsurface immediately

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. This seems outdated. It also doesn't seem to be an issue? Possibly fixed by us having the extra roundtrip with the XDG shell configure REPOSITORY R120 Plasma Wo

D3769: expose immutable through dbus

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. scripts now run when we're immutable, so I think this isn't needed REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3769 To: mvou

D14806: [AppStream Runner] Reduce verbosity of log output

apol added a comment. Because your commits change all very closely related things and even fix each other. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14806 To: bruns, #plasma, apol, ngraham Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, a

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

davidedmundson added inline comments. INLINE COMMENTS > main.qml:130 > +(pagerModel.currentPage + 1) % repeater.count : > pagerModel.currentPage + 1; > +if (nextPage >= repeater.count) nextPage = repeater.count - > 1; > +pagerModel.changePage(

D15110: Fix scrollbars in LibreOffice

gepardo added a comment. In D15110#316372 , @davidedmundson wrote: > Can you explain where this 14 is derived from? This value is used un Breeze-Dark-gtk and older revisions of Breeze-gtk. REPOSITORY R98 Breeze for Gtk REVISION DETAIL

D15026: Fetch high-resolution image from Bing

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I don't see how you can be sure that the 1920_1080 resolution version of the image exists, It seems more that we need to patch the request *in* to bing to get

D15115: fix translations kcm to be usable on new users/installations

sitter created this revision. sitter added a reviewer: hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY this broke somewhat recently. the new availabletranslationsmodel's rowcount is always 0 on a complete

D13911: Sync MAX_UID with upstream

This revision was automatically updated to reflect the committed changes. Closed by commit R123:1421359002d6: Sync MAX_UID with upstream (authored by arojas). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13911?vs=37222&id=40540 REVISI

D13911: Sync MAX_UID with upstream

arojas added a comment. Ping REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D13911 To: arojas, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15110: Fix scrollbars in LibreOffice

davidedmundson added a comment. Can you explain where this 14 is derived from? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D15110 To: gepardo, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,