[Breeze] [Bug 367696] konsole icon is almost invisible when I use breeze dark theme

https://bugs.kde.org/show_bug.cgi?id=367696 Dr. Chapatin changed: What|Removed |Added Version|5.13.0 |5.13.5 -- You are receiving this mail because:

D15331: [Folder View] Hide /home/foo/Desktop place in configuration

davidedmundson added a comment. > It's just a QSortFilterProxyModel so not sure we can "delay" the filtering? setDynamicSortFilter on/off REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15331 To: broulik, #plasma, hein, fvogt Cc: davidedmundson, ngraham,

D15331: [Folder View] Hide /home/foo/Desktop place in configuration

broulik planned changes to this revision. broulik added a comment. Alright, will look into `QQmlParserStatus`, didn't know about `dynamicSortFilter` REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15331 To: broulik, #plasma, hein, fvogt Cc: davidedmundson, ng

D15356: [Bookmarks Runner] Filter out empty urls, simplify, fix comment

bruns created this revision. bruns added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Bookmarks may have no title, the user is free to delete it when creating a bookmark. A bookmark with

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

bruns created this revision. bruns added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY An entry from the moz_places db may have several referring entries in the moz_bookmarks db, i.e. where

D15356: [Bookmarks Runner] Filter out empty urls, simplify, fix comment

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > firefox.cpp:105 > const QUrl url = result.value(QStringLiteral("url")).toUrl(); > -if (url.scheme().contains(QStringLiteral("place"))) {

D15356: [Bookmarks Runner] Filter out empty urls, simplify, fix comment

bruns updated this revision to Diff 41223. bruns added a comment. replace QStringLiteral REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15356?vs=41215&id=41223 REVISION DETAIL https://phabricator.kde.org/D15356 AFFECTED FILES runners/bookmark

D15356: [Bookmarks Runner] Filter out empty urls, simplify, fix comment

This revision was automatically updated to reflect the committed changes. bruns marked an inline comment as done. Closed by commit R120:08895fd7f1ab: [Bookmarks Runner] Filter out empty urls, simplify, fix comment (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

bruns updated this revision to Diff 41227. bruns added a comment. rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15357?vs=41218&id=41227 BRANCH T9626 REVISION DETAIL https://phabricator.kde.org/D15357 AFFECTED FILES runners/bookmark

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

acrouthamel added a comment. Any movement on this? It would be great to use the dictionary in krunner. Still broken in 5.13.4. REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D14064 To: McPain, broulik Cc: acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, le

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I appreciate the patch and the fact that you considered the prior comments in D14739 . But I must admit I'm still left with a nagging questio