D13625: Add 'Documentation' category to the Application menus

yurchor abandoned this revision. yurchor added a comment. The problem can be solved on the distribution level: https://bugs.mageia.org/show_bug.cgi?id=19532#c5 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13625 To: yurchor, #plasma_workspaces Cc:

D15440: Translated into Russian

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. NACK, this is not the correct approach. The right approach is translate the messages via the .po file that contains them:

D15410: Handle clients which change window metadata during early startup

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Seems to work with LO 5.1.6 for me! REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D15410 To: hein, davidedmundson, broulik, ngraham

D15442: Improve DDCUtil handling in CMakeLists

nilathak created this revision. nilathak added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nilathak requested review of this revision. REVISION SUMMARY This has already been started in https://phabricator.kde.org/D8626?id=33105 but never got

D15441: Initial migration to >=ddcutil-0.8.6 API (tested with ddcutil-0.9.1)

nilathak created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nilathak requested review of this revision. REVISION SUMMARY The current ddcutilbrightness.cpp implementation has been broken since the following ddcutil commit:

D15440: Translated into Russian

sheykhnurlatipov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sheykhnurlatipov requested review of this revision. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D15440 AFFECTED FILES

D15435: Add translucent background attribute to popup menu

anemeth updated this revision to Diff 41432. anemeth added a comment. Add translucent background attribute to popup menu REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15435?vs=41431=41432 BRANCH fix_desktop_menu_tp REVISION DETAIL

D15435: Add translucent background attribute to popup menu

anemeth created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anemeth requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH fix_desktop_menu_tp REVISION DETAIL https://phabricator.kde.org/D15435 AFFECTED FILES

D15418: Dim application icon when it is not playing anything

acrouthamel added a comment. I like it. I agree though to maybe make them a bit lighter. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15418 To: broulik, #plasma, #vdg Cc: acrouthamel, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot,

D15423: System settings: make date/time format preview consistent

ngraham accepted this revision as: VDG. ngraham added a comment. Looks good to me, and doesn't regress anything in any of the other locales I tried. I'll let @hein do a final review. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15423 To: McPain, hein,

D15423: System settings: make date/time format preview consistent

ngraham added a reviewer: VDG. ngraham added a comment. Thanks, that helps! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15423 To: McPain, hein, #vdg Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D15418: Dim application icon when it is not playing anything

ngraham added a comment. Hmm. Here's another idea: we could badge the app icon with `player-volume-muted`, maybe. I just worry a bit that lightening the app icon may be too subtle, and people might see it as a bug or wonder why it looks different. REPOSITORY R115 Plasma Audio Volume

D15418: Dim application icon when it is not playing anything

abetts added a comment. +1 REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15418 To: broulik, #plasma, #vdg Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15423: System settings: make date/time format preview consistent

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15423 To: McPain, hein Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15430: Open Web Shorcuts KCM from Web Shortcut Runner config

broulik created this revision. broulik added reviewers: Plasma, leszeklesner, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The runner doesn't have any config on its own but uses the Web Shortcuts

D15429: Simplify cmake code: link to Qt5::GuiPrivate.

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. I think that makes sense. +1. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH Plasma/5.13 REVISION DETAIL https://phabricator.kde.org/D15429 To: dfaure, kfunk,

D15429: Simplify cmake code: link to Qt5::GuiPrivate.

dfaure created this revision. dfaure added reviewers: kfunk, kossebau. Herald added a project: Plasma. Herald edited subscribers, added: plasma-devel; removed: Plasma. dfaure requested review of this revision. REVISION SUMMARY This target was added in Qt 5.9, which we can now rely upon. Also

D15427: [Spellchecker Runner] Add button to open Spell Check KCM

broulik created this revision. broulik added reviewers: Plasma, leszeklesner, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY In the runner's configuration you can only configure the trigger word, whereas

D15423: System settings: make date/time format preview consistent

McPain added a comment. Before: F6252186: изображение.png After: F6252262: изображение.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15423 To: McPain, hein Cc: ngraham,

D15423: System settings: make date/time format preview consistent

ngraham added a comment. Before-and-after screenshots can make a big difference in the reviewability of a patch like this. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15423 To: McPain, hein Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot,

D15418: Dim application icon when it is not playing anything

broulik added a comment. F6252135: Screenshot_20180911_144651.png Fading the mute button doesn't make that big of a diference REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15418 To: broulik, #plasma,

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

McPain added a comment. In D14064#322643 , @davidedmundson wrote: > Urgh. Just read the code. > > We don't reset when we type a new letter. To do so would have a jumpy ui. Instead we reset when we get results back. > > That leaves a

D15423: System settings: make date/time format preview consistent

McPain created this revision. McPain added a reviewer: hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY BUG: 398493 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15423

D15418: Dim application icon when it is not playing anything

broulik added a comment. We need to take care to not make it confusing with the "muted" state where it fades the slider REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15418 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel, ragreen, Pitel,

D15418: Dim application icon when it is not playing anything

ngraham added a comment. That dimming effect might be too subtle on a brightly colored app icon. How about dimming the black volume icon instead of or in addition to the app icon? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15418 To: broulik,

D15418: Dim application icon when it is not playing anything

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When a stream is present but not playing anything ("corked"), show icon slightly translucent

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

smithjd added a comment. In D15341#323730 , @ngraham wrote: > In D15341#323715 , @smithjd wrote: > > > KRunner as a standalone application does much more than search for files. Therefore adding