D15598: Sort icon and cursor themes case-insensitively

ngraham updated this revision to Diff 41956. ngraham added a comment. Rebase on Plasma/5.14 branch REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15598?vs=41925=41956 BRANCH sort-icon-and-cursor-themes-case-insensitively (branched from

D15206: [Kickoff] Add a subtle separator line between the header and the content view

ngraham added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15206 To: ngraham, #plasma, #vdg Cc: abetts, mmustac, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15598: Sort icon and cursor themes case-insensitively

cfeck added a comment. If you would need to process the data sorted, you would already sort the model. But here, it is only sorted for display, and that's exactly the use case for the proxy model. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

ngraham added a comment. Looks like the dependencies have been committed and we've branched for 5.14. #plasma folks/@davidedmundson, does this look good to land now? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D15598: Sort icon and cursor themes case-insensitively

ngraham added a comment. Data structures are not really my forte, but I had a look. It seems possible but rather complicated due to the way the models populate and update themselves and return data. I'd like to see what @apol has to say. Is there some big disadvantage with this approach

KDE CI: Plasma » kactivitymanagerd » kf5-qt5 SUSEQt5.11 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kactivitymanagerd/job/kf5-qt5%20SUSEQt5.11/5/ Project: kf5-qt5 SUSEQt5.11 Date of build: Wed, 19 Sep 2018 15:07:59 + Build duration: 1 min 7 sec and counting JUnit Tests Name: (root)

KDE CI: Plasma » kactivitymanagerd » kf5-qt5 FreeBSDQt5.11 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kactivitymanagerd/job/kf5-qt5%20FreeBSDQt5.11/5/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Wed, 19 Sep 2018 15:07:59 + Build duration: 39 sec and counting

D13745: Implement support for virtual desktops on Wayland

anthonyfieroni added inline comments. INLINE COMMENTS > abstracttasksproxymodeliface.cpp:216 > + > +const QModelIndex = mapIfaceToSource(index); > +const AbstractTasksModelIface *m = dynamic_cast AbstractTasksModelIface *>(sourceIndex.model()); mapIfaceToSource and mapToSource returns

D15599: Port the "Switch Desktop" containment action to libtaskmanager

broulik added inline comments. INLINE COMMENTS > desktop.cpp:46 > + > +if (!s_virtualDesktopInfo) { > +delete s_virtualDesktopInfo; `!s_instanceCount` > desktop.cpp:65 > > -//Is it either the first time or the desktop number changed? > if (m_actions.count() <

Re: Fwd: KDE CI: Administration » Dependency Build Plasma kf5-qt5 SUSEQt5.11 - Build # 5 - Failure!

On jeudi 13 septembre 2018 21:47:36 CEST Ben Cooksley wrote: > Hi all, > > Please see below. If someone could please take a look and fix this failure > that would be appreciated. > > On another note, the Marble build recently broke with a similar error - has > something been changed in

D15599: Port the "Switch Desktop" containment action to libtaskmanager

hein updated this revision to Diff 41932. hein added a comment. Kill more unused stuff. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15599?vs=41931=41932 BRANCH arcpatch-D13745 REVISION DETAIL https://phabricator.kde.org/D15599 AFFECTED

D15599: Port the "Switch Desktop" containment action to libtaskmanager

hein updated this revision to Diff 41931. hein added a comment. Remove another unused include. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15599?vs=41930=41931 BRANCH arcpatch-D13745 REVISION DETAIL https://phabricator.kde.org/D15599

D15599: Port the "Switch Desktop" containment action to libtaskmanager

hein created this revision. hein added reviewers: mart, davidedmundson. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY This: - Makes it work on Wayland. Depends on D13745 . - Cleans up includes and linkage.

D15598: Sort icon and cursor themes case-insensitively

broulik added a comment. Can't we fix the `CursorThemesModel` and `IconThemesModel` to already populate themselves correctly? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D15598 To: ngraham, apol, #plasma Cc: broulik, plasma-devel, ragreen,

D15550: Move correct indices in the manual sort map when getting a move() call for group children

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3d3a4b6c0aa6: Move correct indices in the manual sort map when getting a move() call for… (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

KDE CI: Plasma » kactivitymanagerd » kf5-qt5 FreeBSDQt5.11 - Build # 4 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kactivitymanagerd/job/kf5-qt5%20FreeBSDQt5.11/4/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Wed, 19 Sep 2018 07:04:32 + Build duration: 1 min 24 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kactivitymanagerd » kf5-qt5 SUSEQt5.11 - Build # 4 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kactivitymanagerd/job/kf5-qt5%20SUSEQt5.11/4/ Project: kf5-qt5 SUSEQt5.11 Date of build: Wed, 19 Sep 2018 07:04:32 + Build duration: 46 sec and counting CONSOLE OUTPUT [...truncated