D15093: Add WireGuard capability.

andersonbruce added a comment. Okay, I just uploaded changes for most of the rest of the comments but I would like to revisit a couple of earlier issues. The first is the SpinBoxes. As I said in another comment, I don't think that the SpinBoxes are appropriate for any of the entries and wou

D15093: Add WireGuard capability.

andersonbruce updated this revision to Diff 42118. andersonbruce marked an inline comment as done. andersonbruce added a comment. - Update from more (but not all) review comments - Change 'setting' functions to use blank NMStringMap rather than incoming data. REPOSITORY R116 Plasma Networ

D15683: Add lock icon to desktop context menu

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D15683 To: anemeth, ngraham, #vdg Cc: abetts, safaalfulaij, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15683: Add lock icon to desktop context menu

safaalfulaij added a comment. Why not also add icons to other items instead of other X number of commits coming later by Y number of people? Yes, some don't have “group” icon (like sort, where only ascending and descending are available), but I don't see a problem if we used any “child” one

D15684: DateTime Runner timezone and 24 hour clock time conversion.

smithjd created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. smithjd requested review of this revision. REVISION SUMMARY Convert time to and from other time zones. Report time in 24 hr time. REPOSITORY R114 Plasma Addons BRANCH master-timeconverte

D15683: Add lock icon to desktop context menu

anemeth added a comment. My arcanist is still borked. Could someone please push this? Thank you. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D15683 To: anemeth, ngraham, #vdg Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohame

D15683: Add lock icon to desktop context menu

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM! REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D15683 To: anemeth, ngraham, #vdg Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliez

D15683: Add lock icon to context menu

anemeth created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anemeth requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D15683 AFFECTED FILES containments/desktop/plugins/

D15644: Provide option to hide menu bar for Ksysguard - Bug 395349

ngraham added inline comments. INLINE COMMENTS > ksysguard.cpp:149 > + > + // setup 'Settings' menu > + KToggleAction* showMenuBar = KStandardAction::showMenubar(nullptr, > nullptr, actionCollection()); Minor nitpick: "setup" is a noun; it should be "set up" so that there's a verb in the

D15644: Provide option to hide menu bar for Ksysguard - Bug 395349

ngraham added a comment. Thanks! Please also remove ` - Bug 395349` from the title and replace it with `BUG: 395349` in the Summary section. --- Now the patch looks better, applies cleanly, and works in my testing. However--and this is a complaint with other KDE software as well--if

D15644: Provide option to hide menu bar for Ksysguard - Bug 395349

lsartorelli updated this revision to Diff 42101. lsartorelli retitled this revision from "Bug 395349" to "Provide option to hide menu bar for Ksysguard - Bug 395349". lsartorelli edited the summary of this revision. lsartorelli added a comment. Thank you, for all the feedback. Yes, I have

D14011: Use QtQuick.Controls 2.0 Label in energy and fileindexmonitor KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R102:fde8d23beeae: Use QtQuick.Controls 2.0 Label in energy and fileindexmonitor KCM (authored by bosimonsen, committed by ngraham). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabri

D15682: Fix showing update notification

broulik created this revision. broulik added reviewers: Plasma, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It would check whether the old count was greater than or equal to the new count which is the

D14011: Use QtQuick.Controls 2.0 Label in energy and fileindexmonitor KCM

ngraham reopened this revision. ngraham added a comment. This revision is now accepted and ready to land. Whoops! I saw the name and didn't check the paths. Will land it for you. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D14011 To: bosimonsen, davidedmundson

D15644: Bug 395349

acrouthamel added a comment. Yeah I think that is a mistake. D42047 which precedes the current diff, makes much more sense. REVISION DETAIL https://phabricator.kde.org/D15644 To: lsartorelli, ngraham, #plasma, #frameworks Cc: acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, les

D15681: [Notifier] Fix word wrapping

broulik created this revision. broulik added reviewers: Plasma, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY A label without a size never wraps TEST PLAN 5.14 Both heading and main text wrap pro

D14011: Use QtQuick.Controls 2.0 Label in energy and fileindexmonitor KCM

zzag added a comment. In D14011#329805 , @ngraham wrote: > Looks like @zzag landed this patch for you last month: https://bugs.kde.org/show_bug.cgi?id=366451#c21 No, I didn't. Probably, instead of "BUG" it should be "CCBUG". REPOSIT

D14011: Use QtQuick.Controls 2.0 Label in energy and fileindexmonitor KCM

ngraham closed this revision. ngraham added a subscriber: zzag. ngraham added a comment. Looks like @zzag landed this patch for you last month: https://bugs.kde.org/show_bug.cgi?id=366451#c21 REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D14011 To: bosimonsen,

D15644: Bug 395349

ngraham requested changes to this revision. ngraham added reviewers: Plasma, Frameworks. ngraham added a comment. This revision now requires changes to proceed. Thank you for the patch! I see that this is your first KDE contribution, how exciting! This needs some work, so please don't get disc

D15644: Bug 395349

lsartorelli updated this revision to Diff 42048. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15644?vs=42047&id=42048 REVISION DETAIL https://phabricator.kde.org/D15644 AFFECTED FILES gui/ksysguard.cpp To: lsartorelli Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mo

D15644: Bug 395349

lsartorelli created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. lsartorelli requested review of this revision. REVISION SUMMARY Provide option to hide menu bar for Ksysguard REPOSITORY R106 KSysguard BRANCH master REVISION DETAIL https://phabr

D15642: Port "Switch Window" containment action to updated libtaskmanager API and away from KWindowSystem

hein created this revision. hein added reviewers: mart, davidedmundson. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY This makes it work on Wayland. And probably fixes bugs, the code, especially the next/prev window stuff, was pretty wonky. Also

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.11 - Build # 55 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.11/55/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 21 Sep 2018 09:42:30 + Build duration: 7 min 35 sec and counting

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.11 - Build # 54 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.11/54/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 21 Sep 2018 09:40:54 + Build duration: 1 min 30 sec and counting CONSOLE OUTPUT [...t

D15613: [Hotplug Engine] Update actions at runtime and listen for added/removed

This revision was automatically updated to reflect the committed changes. Closed by commit R120:522d2cfce8ec: [Hotplug Engine] Update actions at runtime and listen for added/removed (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D15637: Make DBusMenu work correctly with dynamically generated menus

poboiko added a comment. > Can this potentially throw off the order of items or cause items to be removed that got inserted previously (ID clash?)? As far as I can see, it should not be the case: those two operations should be totally interchangeable. Both "insert/update" and "remove"

D14011: Use QtQuick.Controls 2.0 Label in energy and fileindexmonitor KCM

bosimonsen added a comment. In D14011#290076 , @ngraham wrote: > Does this really resolve all of https://bugs.kde.org/show_bug.cgi?id=366451? I see several issues described in there... Nate, can you maybe help getting this patch landed?

D15637: Make DBusMenu work correctly with dynamically generated menus

broulik added a comment. I can see the menu sometimes flickering showing that it briefly has more actions than it used to be. Reproducible in Krita's "Window" menu when using title bar menu button and moving away form the menu. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://ph

D15637: Make DBusMenu work correctly with dynamically generated menus

broulik added a comment. Thanks for your patch! It also seems to fix some issues with menus unexpectedly closing in e.g. Kate or Thunderbird. Can this potentially throw off the order of items or cause items to be removed that got inserted previously (ID clash?)? Quick testing suggests

D15637: Make DBusMenu work correctly with dynamically generated menus

poboiko created this revision. poboiko added reviewers: Plasma, broulik. Herald added a project: Plasma. poboiko requested review of this revision. REVISION SUMMARY Right now, the "appmenutest" application fails to show the "Menu C" item, which is dynamically generated. (this also happens wit

D15616: [Comic] Handle error state correctly

anthonyfieroni updated this revision to Diff 42035. anthonyfieroni added a comment. Another approach: If timer expires in 2 min without result disconnect it from source and starts again for next 2 min, when it expires if try to update again by activate slotCurrentDay REPOSITORY R114 Plasma