[Powerdevil] [Bug 349750] Laptop does not suspend when lid closed in lock screen

https://bugs.kde.org/show_bug.cgi?id=349750 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #11 from Andrew

[kio-extras] [Bug 375826] Copying files to a remote SFTP folder opens a popup "Could not change permissions.."

https://bugs.kde.org/show_bug.cgi?id=375826 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #2 from Andrew

D15807: Allow to disable installation of wallpapers with breeze

apol closed this revision. apol added a comment. https://commits.kde.org/breeze/b97dfaff25ca2eb18099128243f3e2b2d2b56230 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D15807 To: apol, ngraham Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D12498: Fully remove `Application Name` from Details panel

bruns added a comment. Try this one: F6290609: authdetails.ui Also fixed up vertical alignment, should be the same for all labels. REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D12498 To: sharvey,

T8066: Fix Bug 390830 = Prevent indexing of Plasma vaults and other fuse filesystems

smithjd added a comment. > A slightly smarter approach would be for Plasma Vaults itself to add such a rule for whatever mountpoint is chosen during new vault creation. What about exposing these config options on dbus? ("includeFolders"),("excludeFolders") That would make for 4 new

D12498: Fully remove `Application Name` from Details panel

ngraham added a comment. > The XML file is auto-generated by the form editor in QtCreator. I don’t have any control over it. And I don’t want to mess with it by hand - too easy to break. You pretty much have to, or else the diff is impossible to review, and it's easy for unintentional

D12498: Fully remove `Application Name` from Details panel

sharvey added inline comments. INLINE COMMENTS > bruns wrote in authdetails.ui:20 > Can you try to restore/use the same item order in the XML file as previously? > Should make the diff significantly smaller, and easier to review. The XML file is auto-generated by the form editor in QtCreator. I

D12498: Fully remove `Application Name` from Details panel

bruns added inline comments. INLINE COMMENTS > authdetails.ui:20 > > - > - > - > - > - 75 > - true > - > + > + Can you try to restore/use the same item order in the XML file as previously? Should make the diff significantly smaller, and easier to

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I've written you a unit test. I can either take over this or upload as a separate review that you can merge in. INLINE COMMENTS > zzag wrote in

[plasmashell] [Bug 360339] Plasma Crash on startup

https://bugs.kde.org/show_bug.cgi?id=360339 Haris Tampakopoulos changed: What|Removed |Added Status|NEEDSINFO |RESOLVED

D15807: Allow to disable installation of wallpapers with breeze

apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Will make it possible to have breeze on the flatpak and snap backends without all of the wallpapers REPOSITORY R31 Breeze BRANCH

D15304: [KCM] Port (almost) entirely to QQC2

drosca added a comment. In D15304#332755 , @ngraham wrote: > > Plasma items should not be used in KCM. > > Hmm, what you you recommend then for showing an icon item? The old `QIconItem` breaks for fractional scale factors. Kirigami has a

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #33 from Marco Richetta --- > Marco Richetta seems to have problem with upower, independent of this bug. > > The applet not detecting battery only affects kde, other desktops seem to > work fine. Just restarted my laptop. acpi -i outputs

D15011: [Kickoff] Make the search field always look like a search field

ngraham added a comment. In D15011#332631 , @cfeck wrote: > David is on holidays, so maybe someone else could approve if this is urgent. Ah, whoops, didn't know that. No, it's not urgent. I can wait until he returns, then. REPOSITORY

D15304: [KCM] Port (almost) entirely to QQC2

ngraham added a comment. > Plasma items should not be used in KCM. Hmm, what you you recommend then for showing an icon item? The old `QIconItem` breaks for fractional scale factors. Kirigami has a nice icon, but then we'd need to import Kirigami. REPOSITORY R115 Plasma Audio Volume

D15644: Provide option to hide menu bar for Ksysguard

ngraham added a comment. Awesome job, @lsartorelli. For your next trick, would you like to create `KStandardAction::showMenubarWithWarning` (or something like that)? This would essentially duplicate the code you've written here, but it would be in a new central location so we could ensure

D15793: Sort keys in json encoder

This revision was automatically updated to reflect the committed changes. Closed by commit R856:ef33a69d7ea6: Sort keys in json encoder (authored by davidedmundson). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15793?vs=42415=42418

D15793: Sort keys in json encoder

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Should supress scripty noise. The previous manualy sorting above was

D14068: add -P switch to one-shot redshift call

grmat added a comment. In D14068#332672 , @davidedmundson wrote: > what happens to users on older versions? It breaks, as redshift <1.12 will exit with "invalid option -- 'P'". I initially just thought of this as packaging

D15644: Provide option to hide menu bar for Ksysguard

This revision was automatically updated to reflect the committed changes. Closed by commit R106:3a3220d41ac4: Provide option to hide menu bar for Ksysguard (authored by lsartorelli, committed by sitter). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE

D15644: Provide option to hide menu bar for Ksysguard

sitter accepted this revision. sitter added a comment. It's perfect now! REVISION DETAIL https://phabricator.kde.org/D15644 To: lsartorelli, ngraham, #plasma, #frameworks, sitter Cc: broulik, sitter, acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D15333: Group Widget + Color Picker = Widget Out Of Bounds

McPain added inline comments. INLINE COMMENTS > main.qml:138 > > -readonly property int thickness: > Math.ceil(Math.min(parent.width, parent.height) / units.iconSizes.small) > We need to make thickness independent from length. REVISION DETAIL

D15333: Group Widget + Color Picker = Widget Out Of Bounds

McPain updated this revision to Diff 42413. McPain added a comment. (height * 2) + spacer.height -> (height - spacer.height) / 2 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15333?vs=41157=42413 REVISION DETAIL https://phabricator.kde.org/D15333 AFFECTED FILES

D15333: Group Widget + Color Picker = Widget Out Of Bounds

McPain added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:111 > Please explain the rationale behind this. > > Especially the spacer.width being divided by 2 in the second part of the > statement. > Especially the spacer.width being divided by 2 in the second part of the

D15304: [KCM] Port (almost) entirely to QQC2

drosca added inline comments. INLINE COMMENTS > CardListItem.qml:33 > RowLayout { > -QIconItem { > +PlasmaCore.IconItem { > id: clientIcon Plasma items should not be used in KCM. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #32 from Arnaud --- Sorry, accidental post Same problem as everyone, with kde battery plasmoid not detecting any battery despite upower detecting it. Battery status available on lock screen. upower -d Device:

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 Arnaud changed: What|Removed |Added CC||arnaud.leh...@gmail.com --- Comment #31 from Arnaud

D14068: add -P switch to one-shot redshift call

davidedmundson added a comment. > since 1.12. what happens to users on older versions? REPOSITORY R885 Redshift Control for Plasma REVISION DETAIL https://phabricator.kde.org/D14068 To: grmat, #plasma, romangg, martinkostolny Cc: davidedmundson, ngraham, plasma-devel, ragreen,

D15333: Group Widget + Color Picker = Widget Out Of Bounds

davidedmundson added a comment. Commits really benefit from a bit more description. Reviewers don't have the same context you had in your head when you wrote it. INLINE COMMENTS > main.qml:111 > Plasmoid.compactRepresentation: Grid { > -readonly property int buttonSize: