D15892: [Devicenotifications Engine] Keep at most one notification per UDI

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Each notification was created as new datasource, and was newer removed as long as the engine exist

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

bruns added a comment. I would really appreciate if we could get this into the imminent Plasma release. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15357 To: bruns, #plasma Cc: davidedmundson, zzag, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesli

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

bruns added a comment. qdbus-qt5 org.kde.krunner /App org.kde.krunner.App.querySingleRunner bookmarks kde Current state: F6298174: Bookmarks_Current.png Deduplicated: F6298173: Bookmarks_Deduplicated.png

Re: My ksmserver plans

On Mon, Oct 1, 2018 at 1:47 PM David Edmundson wrote: > > I was making a few ksmserver patches, I thought I should document what my > long term plans are so the patches make sense. > > https://phabricator.kde.org/T9779 > > It's not an urgent task, so might spread over the next 2 releases. > > Dav

D15889: [Cursors] link *-resize to *_corner cursor

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY BUG: 399194 When hovering at the window corner in Nautilus an Adwaita curser is shown. Link it to the Breeze equival

D15888: new icons (Breeze style)

borisg created this revision. borisg added a reviewer: martinkostolny. borisg added a project: Plasma. Herald added a subscriber: plasma-devel. borisg requested review of this revision. REVISION SUMMARY F6297830: 2.jpg F6297829: 1.jpg

D15887: Fix Klipper popup opening on default screen instead of at cursor position

romangeints created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangeints requested review of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15887 AFFECTED FILES klipper/klipper.cpp To: romangeints

Re: My ksmserver plans

Sounds good! Cheers Martin Am 1. Oktober 2018 13:46:56 MESZ schrieb David Edmundson : >I was making a few ksmserver patches, I thought I should document what >my >long term plans are so the patches make sense. > >https://phabricator.kde.org/T9779 > >It's not an urgent task, so might spread over

D12498: Fully remove `Application Name` from Details panel

bruns added inline comments. INLINE COMMENTS > AuthDialog.cpp:325 > setupUi(this); > > -// better N/A than a blank space This hunk should go into D15885 , also all the changes with `appname`/`m_appname` REPOSITORY R121 Policykit (Polkit) KDE Age

D15885: Clean UI file for `details` portion of UI

bruns added a comment. The ui changes look fine now, but AFAICS you are missing the changes in AuthDialog.{h,cpp} from D12498 now. REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH cleanup-ui (branched from master) REVISION DETAIL https://phabric

KDE CI: Plasma » kscreen » kf5-qt5 SUSEQt5.11 - Build # 31 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kscreen/job/kf5-qt5%20SUSEQt5.11/31/ Project: kf5-qt5 SUSEQt5.11 Date of build: Mon, 01 Oct 2018 17:13:07 + Build duration: 4 min 10 sec and counting CONSOLE OUTPUT [...truncated 146.29

KDE CI: Plasma » kscreen » kf5-qt5 FreeBSDQt5.11 - Build # 28 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kscreen/job/kf5-qt5%20FreeBSDQt5.11/28/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Mon, 01 Oct 2018 17:13:07 + Build duration: 27 sec and counting CONSOLE OUTPUT [...truncated 122.49

D15790: Follow the preferred mode if we're asked to (i.e. if under QXL)

This revision was automatically updated to reflect the committed changes. Closed by commit R104:fb19e12c3253: Follow the preferred mode if we're asked to (i.e. if under QXL) (authored by apol). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15790?vs=42406&id=4

D15789: Support QXL hotplug_mode_update

This revision was automatically updated to reflect the committed changes. Closed by commit R110:b237aebd00ba: Support QXL hotplug_mode_update (authored by apol). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15789?vs=42500&id=42681 REVISION DETAIL

D15885: Clean UI file for `details` portion of UI

sharvey created this revision. sharvey added reviewers: ngraham, bruns. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sharvey requested review of this revision. REVISION SUMMARY Properly organized UI file (by @bruns) TEST PLAN Add to polkit-agent; recompile REPOSIT

D14949: Add option for whether to show the volume change OSD

graesslin added a comment. Please don't introduce options based on what's unpopular on Reddit. REVISION DETAIL https://phabricator.kde.org/D14949 To: anonym, #vdg Cc: graesslin, svenmauch, ngraham, romangg, mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jens

D15881: [ksmserver] change i18nd to i18nc

ngraham abandoned this revision. ngraham added a comment. No domain knowledge, will let @davidedmundson do what's necessary here, if anything. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15881 To: ngraham, davidedmundson Cc: broulik, plasma-devel, ragre

D15881: [ksmserver] change i18nd to i18nc

broulik added a comment. Also here we might as well now use a proper message now like "This will shut down your computer." REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15881 To: ngraham, davidedmundson Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot,

D15881: [ksmserver] change i18nd to i18nc

broulik added a comment. That makes no sense, that `d` is so it uses the lnf domain, you can just drop that `c` completely then, or provide some meaningful context to translators REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15881 To: ngraham, davidedmund

D15878: Replace "Shutdown" with "Shut Down" in user-facing strings

ngraham added a comment. In D15878#334829 , @ngraham wrote: > In D15878#334828 , @davidedmundson wrote: > > > We probably should change it to i18n / i18nc in master > > > OK, I can do that aft

D15881: [ksmserver] change i18nd to i18nc

ngraham created this revision. ngraham added a reviewer: davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY We're on master, we can and should use `i18nd()` instead REPOSITORY R120 Plasma Workspa

D15878: Replace "Shutdown" with "Shut Down" in user-facing strings

ngraham closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15878 To: ngraham, #vdg, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15878: Replace "Shutdown" with "Shut Down" in user-facing strings

ngraham added a comment. In D15878#334828 , @davidedmundson wrote: > We probably should change it to i18n / i18nc in master OK, I can do that after this lands. REPOSITORY R120 Plasma Workspace BRANCH shutdown-to-shut-down (branched

D15878: Replace "Shutdown" with "Shut Down" in user-facing strings

davidedmundson added a comment. i18nd == stating what catalog to load from the qml needs it because the logout greeter code doesn't set the domain my code had it because it was doing something very naughty and grabbing a translation from some other bit of code We probablyshould ch

D15878: Replace "Shutdown" with "Shut Down" in user-facing strings

ngraham added a comment. All good now, @davidedmundson? What does `i18nd()` mean? Should that now be changed to regular old `i18nc()` on master? REPOSITORY R120 Plasma Workspace BRANCH shutdown-to-shut-down (branched from master) REVISION DETAIL https://phabricator.kde.org/D15878

D15878: Replace "Shutdown" with "Shut Down" in user-facing strings

ngraham updated this revision to Diff 42664. ngraham added a comment. Fix one more that was just introduced on master REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15878?vs=42662&id=42664 BRANCH shutdown-to-shut-down (branched from master) REV

D15869: Fallback to in-process prompt if logout prompt fails

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R120:c2ea0afb5596: Fallback to in-process prompt if logout prompt fails (authored by davidedmundson). REPOSITORY R120 P

D15878: Replace "Shutdown" with "Shut Down" in user-facing strings

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I'm going to merge the other patch into stable, I can do that now, then when that's merged you can add the change there too. REPOSITORY R120 Plasma Workspace BRANCH shu

D15869: Fallback to in-process prompt if logout prompt fails

davidedmundson added inline comments. INLINE COMMENTS > ngraham wrote in shutdown.cpp:229 > Shutdown -> Shut Down > > "Shutdown" is a noun ("The nuclear reactor is experiencing a shutdown!") > > "Shut Down" is an imperative command with a verb ("Shut down the nuclear > reactor!"), which is how

D15877: [KonsoleProfiles applet] Fix navigating with the keyboard

thsurrel created this revision. thsurrel added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY BUG: 399192 TEST PLAN Create several profiles in Konsole. Open the Konsole Profiles applet

D15878: Replace "Shutdown" with "Shut Down" in user-facing strings

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY "Shutdown" is a noun ("The nuclear reactor is experiencing a shutdown!") "Shut Down" is a

D15840: [Folder View] Remember selected item when navigating in subfolders

thsurrel added inline comments. INLINE COMMENTS > anthonyfieroni wrote in FolderView.qml:1114 > Ok, then just embed Folder View in the panel (by right click on the panel, > panel options -> add widgets or drag'n'drop it in) then navigate to check > that should it goback to be applied as well.

D15840: [Folder View] Remember selected item when navigating in subfolders

anthonyfieroni added inline comments. INLINE COMMENTS > thsurrel wrote in FolderView.qml:1114 > My understanding was that the gridView.model could be undefined only if the > FolderModel was not ready. But if we navigated into a subfolder and we are > asking to go back, than the FolderModel had

D15869: Fallback to in-process prompt if logout prompt fails

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > shutdown.cpp:229 > +//i18nd is used as this patch was backported to an LTS > with stable translations > + > fallback

D15840: [Folder View] Remember selected item when navigating in subfolders

thsurrel added inline comments. INLINE COMMENTS > anthonyfieroni wrote in FolderView.qml:1114 > Do we have grodView.model after back clicked? If we do in expanded view > (that's when Folder View is embedded in the panel) goingBack will not be > performed. My understanding was that the gridView

D15876: Fix copyrights in binary clock files

piotrkakol added a comment. Well, previously it looked like I claimed to be contributor to fuzzy-clock, analog-clock and version from KDE4. Now it's clear that I only contributed to the newest version of binary-clock. In the rest files my copyriht claim is in a correct position. So it a

D15870: Move kactivitymanagerd to libexec and remove manual daemon management

This revision was automatically updated to reflect the committed changes. Closed by commit R161:0bb66df60346: Move kactivitymanagerd to libexec and remove manual daemon management (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15870?vs=42642&id=42660#toc REP

D15876: Fix copyrights in binary clock files

davidedmundson added a comment. What exactly is being "fixed" here? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D15876 To: piotrkakol, davidedmundson Cc: plasma-devel, ngraham, gladhorn, zzag, davidedmundson, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed

D15840: [Folder View] Remember selected item when navigating in subfolders

anthonyfieroni added inline comments. INLINE COMMENTS > FolderView.qml:1114 > onListingCompleted: { > if (!gridView.model && plasmoid.expanded) { > gridView.model = positioner; Do we have grodView.model after back clicked? If we do in expanded v

D15876: Fix copyrights in binary clock files

piotrkakol created this revision. piotrkakol added a reviewer: davidedmundson. Herald added a project: Plasma. piotrkakol requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH fix-copyrights (branched from master) REVISION DETAIL https://phabricator.kde.org/D15876 AFFECT

D15875: [Media Controller] Disallow seeking beyond end of track

anthonyfieroni added a comment. 1s file is a corner case as well as 0, cause you have always 2 positions - start and stop. In 0/1s these 2 steps just match, if you are write 0 isn't valid in 0s length file, does it? +1 for the patch from me. REPOSITORY R120 Plasma Workspace REVISION DET

D15863: [MPris Plugin] Support Seek()

This revision was automatically updated to reflect the committed changes. Closed by commit R856:a8152f2678b9: [MPris Plugin] Support Seek() (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15863?vs=42653&id=42656 REVISI

D15875: [Media Controller] Disallow seeking beyond end of track

fvogt added a comment. I'm not sure whether that's correct - a file with a duration of 1s still has a range of 1s. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15875 To: broulik, #plasma, fvogt Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-m

My ksmserver plans

I was making a few ksmserver patches, I thought I should document what my long term plans are so the patches make sense. https://phabricator.kde.org/T9779 It's not an urgent task, so might spread over the next 2 releases. David

D15143: Allow creation of separator Actions

This revision was automatically updated to reflect the committed changes. Closed by commit R169:91ea75c37045: Allow creation of separator Actions (authored by dkardarakos). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15143?vs=42465&id=42655 REVISION DETAI

D15875: [Media Controller] Disallow seeking beyond end of track

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY A track of 60 seconds length has the valid positions `[0,59]` so subtract `-1` TEST PLAN

D15863: [MPris Plugin] Support Seek()

broulik updated this revision to Diff 42653. broulik added a comment. - Use `>=` again :D bug is in media controller plasmoid REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15863?vs=42652&id=42653 REVISION DETAIL https://phabricator.kd

D15863: [MPris Plugin] Support Seek()

broulik updated this revision to Diff 42652. broulik added a comment. - Check bounds in `SetPosition` - Use `>` again since when I move the slider all the way to the end it sets the position to `length` and then would do nothing REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LA

D15863: [MPris Plugin] Support Seek()

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. LGTM. I just tried how the `currentTime` property in JS works, it actually behaves like MPRIS' seek does and does not ignore invalid values. That might need a check in SetPosition. REPOSITOR

D15869: Fallback to in-process prompt if logout prompt fails

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Has a nice Windows 3.1 flair to it REPOSITORY R120 Plasma Workspace BRANCH logout_prompt REVISION DETAIL https://phabricator.kde.org/D15869 To: davidedmundson, #plasma, broulik Cc

D15869: Fallback to in-process prompt if logout prompt fails

davidedmundson added a comment. It was.The situation is now much much much better. But kscreenlocker-greet is a different process, and we've definitely seen that fallback prompt shown. Also I don't like the way it was done. It was done as a conservative exact 1:1 mapping of the origina

Monday meeting minutes for 1/10/2018

Eike: what i did: * [Wayland] Virtual desktops KCM: Implemented delayed-apply, handle all cases of state-desync between KCM and server nicely for the user, UI cleanup * [Wayland] Fixed a crash in one of the containment action ports * [Kickoff] Rewrote mouse handling to fix highlight sticking to mou

D15093: Add WireGuard capability.

andersonbruce added a comment. I've uploaded everything I wanted to get done now. Are there any new comments? And by the way, what is the process once the all the comments do get cleared? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D15093

D15863: [MPris Plugin] Support Seek()

broulik updated this revision to Diff 42648. broulik added a comment. Use `>=` REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15863?vs=42647&id=42648 REVISION DETAIL https://phabricator.kde.org/D15863 AFFECTED FILES host/mprisplugin

D15863: [MPris Plugin] Support Seek()

broulik updated this revision to Diff 42647. broulik added a comment. - Implement Seek according to spec REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15863?vs=42620&id=42647 REVISION DETAIL https://phabricator.kde.org/D15863 AFFECTE

D15863: [MPris Plugin] Support Seek()

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. Seek has a different behaviour for `position() + offset < 0` and `position() + offset == m_length`: A negative value seeks back. If this would mean seeking back further than

D15143: Allow creation of separator Actions

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. In D15143#333127 , @dkardarakos wrote: > Previously introduced "separator mode" removed from AbstractListItem and BasicListItem. > > Instead

D15869: Fallback to in-process prompt if logout prompt fails

broulik added a comment. Wasn't the whole point of making the greeter binary out of process to cover cases where there is a version mismatch after updates? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15869 To: davidedmundson, #plasma Cc: broulik, plasma

D15815: Remove expensive blocking call on plasmashell startup

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0d3ffccbcf6b: Remove expensive blocking call on plasmashell startup (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15815?vs=4

D15870: Move kactivitymanagerd to libexec and remove manual daemon management

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Since it was made DBus activatable having any other code to start/stop the

D15869: Fallback to in-process prompt if logout prompt fails

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY KSmserver is currently very heavily tied to the shutdown prompt dialog. On