KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.11 - Build # 39 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.11/39/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 05 Oct 2018 03:59:18 + Build duration: 11 min and counting

KDE CI: Plasma » oxygen » kf5-qt5 FreeBSDQt5.11 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/oxygen/job/kf5-qt5%20FreeBSDQt5.11/7/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 05 Oct 2018 03:59:08 + Build duration: 8 min 46 sec and counting

KDE CI: Plasma » milou » kf5-qt5 FreeBSDQt5.11 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/milou/job/kf5-qt5%20FreeBSDQt5.11/10/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 05 Oct 2018 03:59:08 + Build duration: 6 min 38 sec and counting

D15942: Don't drag windows in empty areas from touch/pen events

This revision was automatically updated to reflect the committed changes. Closed by commit R31:fb0cbedcc365: Don't drag windows in empty areas from touch/pen events (authored by davidedmundson). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15942?vs=42852&id=42

D14542: WIP: Basic KCM using new virtual desktops DBus interface

hein updated this revision to Diff 42898. hein edited the summary of this revision. hein removed a subscriber: abetts. hein added a comment. Update description to scratch off the done todos REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14542?vs=42897&id=42898

D14542: WIP: Basic KCM using new virtual desktops DBus interface

hein updated this revision to Diff 42897. hein added a comment. Adjust to Marco's DBus API changes, removes the FIXMEs from the code REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14542?vs=42843&id=42897 BRANCH arcpatch-D13887_1 REVISION DETAIL https://p

D15887: Fix Klipper popup opening on default screen instead of at cursor position

davidedmundson added a comment. Sure, but on wayland menu->popup(QPoint) isn't goint work anyway. REVISION DETAIL https://phabricator.kde.org/D15887 To: romangeints, #plasma, davidedmundson Cc: mvourlakos, romangeints, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreu

D15887: Fix Klipper popup opening on default screen instead of at cursor position

mvourlakos added a comment. In D15887#336647 , @davidedmundson wrote: > it binds it to the availableGeometry so it always appears outside of struts (panels) I dont think this is valid under wayland. QScreen::availableGeometry() returns

D15827: [applet] Avoid showing a generic audio-card icon

ngraham added a comment. Great idea. Then the click target becomes much bigger and muting is easier. If we do that, we'd probably want to badge the icon with `emblem-unavailable` so that it's clear that that stream is muted. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL htt

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.11 - Build # 38 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.11/38/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Thu, 04 Oct 2018 19:06:16 + Build duration: 1 min 2 sec and counting CONSOLE OUTPUT [...trun

D15827: [applet] Avoid showing a generic audio-card icon

nicolasfella added a comment. In D15827#336757 , @ngraham wrote: > I think showing a generic speaker or microphone icon is a //huge// visual improvement over a sound card, but I agree with @drosca that it's odd to duplicate them. > > Here's

D15827: [applet] Avoid showing a generic audio-card icon

ngraham added a comment. I think showing a generic speaker or microphone icon is a //huge// visual improvement over a sound card, but I agree with @drosca that it's odd to duplicate them. Here's an idea: It's completely obvious what the sliders are for, so just get rid of the little one

D15950: Link *-resize to the right icons

This revision was automatically updated to reflect the committed changes. Closed by commit R31:63207819b89f: Link *-resize to the right icons (authored by nicolasfella). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15950?vs=42879&id=42883 REVISION DETAIL ht

D15950: Link *-resize to the right icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Heh, shows what I know about GNOME theming... REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D15950 To: nicolasfella, #breeze, ngraham Cc: plasma-

D15889: [Cursors] link *-resize to *_corner cursor

nicolasfella closed this revision. nicolasfella added a comment. Fixed in D15950 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D15889 To: nicolasfella, #breeze, hpereiradacosta, ngraham, andreask Cc: GB_2, plasma-devel, ragreen, Pi

D15950: Link *-resize to the right icons

nicolasfella created this revision. nicolasfella added reviewers: Breeze, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY D15889 did link those to their Breeze

D15889: [Cursors] link *-resize to *_corner cursor

GB_2 reopened this revision. GB_2 added a comment. This revision is now accepted and ready to land. There is still an issue! The cursors got linked with the *_corner cursors, but this is wrong, since those are different cursor than the normal resize cursors! This is how the links should be:

[Breeze] [Bug 367696] konsole icon is almost invisible when I use breeze dark theme

https://bugs.kde.org/show_bug.cgi?id=367696 Nate Graham changed: What|Removed |Added Keywords||junior-jobs -- You are receiving this mail becau

Plasma 5.14.0 tars available for packaging

Plasma 5.14.0 tars are on racnoss available for packagers to package in their distros and release on Tuesday Jonathan

D15887: Fix Klipper popup opening on default screen instead of at cursor position

davidedmundson added a comment. Code in system tray is quite good: if (QScreen *screen = appletInterface->window()->screen()) { const QRect geo = screen->availableGeometry(); pos = QPoint(qBound(geo.left(), (int)pos.x(), geo.right() - desktopMenu->width()),

D15942: Don't drag windows in empty areas from touch/pen events

ngraham added subscribers: abalaji, ngraham. ngraham accepted this revision. ngraham added a comment. Good idea. I know @abalaji was having trouble with this in D12162: Add support for touch scrolling in Dolphin . REPOSITORY R31 Breeze BRANCH master R

D15855: Port Kickoff to shared view component using single-MouseArea pattern

davidedmundson added inline comments. INLINE COMMENTS > KickoffListView.qml:57 > + > +PlasmaExtras.ScrollArea { > +id: scrollArea This already is a focusScope could this not be the root item? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15855 To

D15946: Avoid creation of needless temporary containers

volkov updated this revision to Diff 42860. volkov added a comment. fixed REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15946?vs=42859&id=42860 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15946 AFFECTED FILES backends/kwayla

D15946: Avoid creation of needless temporary containers

volkov added inline comments. INLINE COMMENTS > broulik wrote in waylandoutput.cpp:64 > I think we typically use `const...()` instead of `c...()` but since this > method is `const`, shouldn't be neccessary to begin with Isn't it better to follow STL style? cbegin is also popular in KDE project

D15946: Avoid creation of needless temporary containers

broulik added a comment. Nice findings, feel free to ignore the stylistic changes I commented, except the `qDeleteAll` one, and do unrelated further cleanup in a separate patch INLINE COMMENTS > waylandoutput.cpp:64 > +auto it = std::find(m_modeIdMap.cbegin(), m_modeIdMap.cend(), > kway

D15946: Avoid creation of needless temporary containers

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY Found by clazy. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D15946 AFFECTED FI

KDE CI: Plasma » libkscreen » kf5-qt5 FreeBSDQt5.11 - Build # 11 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/libkscreen/job/kf5-qt5%20FreeBSDQt5.11/11/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Thu, 04 Oct 2018 13:52:35 + Build duration: 1 min 58 sec and counting

D15942: Don't drag windows in empty areas from touch/pen events

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY For a mouse users have the precision that if they clicked in an empty area

KDE CI: Plasma » plasma-browser-integration » kf5-qt5 FreeBSDQt5.11 - Build # 47 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-browser-integration/job/kf5-qt5%20FreeBSDQt5.11/47/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Thu, 04 Oct 2018 11:40:48 + Build duration: 6 min 30 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » oxygen » kf5-qt5 FreeBSDQt5.11 - Build # 6 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/oxygen/job/kf5-qt5%20FreeBSDQt5.11/6/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Thu, 04 Oct 2018 11:40:43 + Build duration: 6 min 34 sec and counting CONSOLE OUTPUT Started by an SC

KDE CI: Plasma » libksysguard » kf5-qt5 FreeBSDQt5.11 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/libksysguard/job/kf5-qt5%20FreeBSDQt5.11/7/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Thu, 04 Oct 2018 11:40:18 + Build duration: 6 min 56 sec and counting CONSOLE OUTPUT Started by

KDE CI: Plasma » milou » kf5-qt5 FreeBSDQt5.11 - Build # 9 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/milou/job/kf5-qt5%20FreeBSDQt5.11/9/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Thu, 04 Oct 2018 11:40:23 + Build duration: 6 min 52 sec and counting CONSOLE OUTPUT Started by an SCM

KDE CI: Plasma » libkscreen » kf5-qt5 FreeBSDQt5.11 - Build # 10 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/libkscreen/job/kf5-qt5%20FreeBSDQt5.11/10/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Thu, 04 Oct 2018 11:40:12 + Build duration: 7 min 1 sec and counting CONSOLE OUTPUT Started by a

D14542: WIP: Basic KCM using new virtual desktops DBus interface

hein updated this revision to Diff 42843. hein added a comment. Change background color of selection delegates to grey REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14542?vs=42592&id=42843 BRANCH arcpatch-D14542 REVISION DETAIL https://phabricator.kde.o

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.11 - Build # 11 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.11/11/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Thu, 04 Oct 2018 11:36:32 + Build duration: 1 min 16 sec and counting CONSOLE OUTPUT [...trun

KDE CI: Plasma » kscreen » kf5-qt5 SUSEQt5.11 - Build # 32 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kscreen/job/kf5-qt5%20SUSEQt5.11/32/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 04 Oct 2018 11:13:10 + Build duration: 21 min and counting JUnit Tests Name: (root) Failed: 0 test(s

KDE CI: Plasma » kscreen » kf5-qt5 FreeBSDQt5.11 - Build # 29 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kscreen/job/kf5-qt5%20FreeBSDQt5.11/29/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Thu, 04 Oct 2018 11:13:10 + Build duration: 4 min 51 sec and counting

D15855: Port Kickoff to shared view component using single-MouseArea pattern

hein updated this revision to Diff 42841. hein added a comment. Add missing file, d'oh. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15855?vs=42596&id=42841 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15855 AFFECTED FILES ap

D15856: Fix initial focus

This revision was automatically updated to reflect the committed changes. Closed by commit R119:94eb9f9e5321: Fix initial focus (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15856?vs=42599&id=42840 REVISION DETAIL https://phabrica

D14542: WIP: Basic KCM using new virtual desktops DBus interface

mart added a comment. wrt position of desktopAdded and eventual reorders.. in the desktop data, x11DesktopNubmer is always guaranteed to be the correct position (modulo the annoying off by one due to x11 desktops) INLINE COMMENTS > desktopsmodel.cpp:295 > + > +// FIXME TODO: Positi

D15827: [applet] Avoid showing a generic audio-card icon

drosca added a comment. I don't really think it looks better, now you have those icons duplicated (big one being for the "device" and small one in volume slider). I think it would be much better to have new icon for "speakers" and "microphone" devices instead of using "output-volume" and "in