[ksysguard] [Bug 399637] libksysguard fails to build without QtWebEngine

https://bugs.kde.org/show_bug.cgi?id=399637 --- Comment #1 from Rik Mills --- For the record, seeing the same failure on Neon and Kubuntu CI builds of master branch. -- You are receiving this mail because: You are the assignee for the bug.

[ksysguard] [Bug 399637] libksysguard fails to build without QtWebEngine

https://bugs.kde.org/show_bug.cgi?id=399637 Rik Mills changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0

[ksysguard] [Bug 399637] New: libksysguard fails to build without QtWebEngine

https://bugs.kde.org/show_bug.cgi?id=399637 Bug ID: 399637 Summary: libksysguard fails to build without QtWebEngine Product: ksysguard Version: unspecified Platform: Other OS: Linux Status: REPORTED

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham added a comment. Thanks! I'm working on the blur now. You also brought up in the #VDG chat that the Virtual Keyboard, session chooser, and battery indicator icons need some better contrast too. Will also work on that. REPOSITORY R120 Plasma

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rizzitello accepted this revision as: rizzitello. rizzitello added a comment. This revision is now accepted and ready to land. This Looks Great! REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D16031 REVISION DETAIL https://phabricator.kde.org/D16031 To: ngraham, #vdg, #plasma,

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham added a comment. I've updated the shadows and text according to #VDG feedback from this morning and I'm feeling pretty good about the current state. Will try to work on blurry backgrounds for the icons now. REPOSITORY R120 Plasma Workspace

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham updated this revision to Diff 43367. ngraham added a comment. - Reduce shadow darkness - Add subtle outlines - Increase text size a bit REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16031?vs=43260=43367 BRANCH arcpatch-D16031

D16106: Focus handling fixes

hein updated this revision to Diff 43329. hein added a comment. - Drop the onPress handling, it was unnecessary with the focus-forwarding I added later during development. - Take David's review comment into account. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D16106: Focus handling fixes

hein added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:425 > I would have expected just folderViewLayer.forceActiveFocus() to work? > > the FolderViewLayer item should be the only item within the Loader (which is > a focus scope) and you added focus: true to

D16106: Focus handling fixes

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > main.qml:425 > +if (isFolder) { > +folderViewLayer.item.forceActiveFocus(); > +} else { I would have expected

D13745: Implement support for virtual desktops on Wayland

hein updated this revision to Diff 43317. hein added a comment. - Make `TaskGroupingProxyModel::requestVirtualDesktops` and similar async-safe. - Make `TasksModel::Private::lessThan` handle unsorted virtual desktops lists. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D16087: RFC: Store full URL as URI

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. > Not sure what the implications are for this change, it does fix Dolphin showing folders in its This I don't like. KAMD stores file paths, not URIs for local files in the

D14542: KCM using new virtual desktops DBus interface

hein updated this revision to Diff 43315. hein added a comment. Drop FIXME from spacer on Marco's advice. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14542?vs=43181=43315 BRANCH arcpatch-D13887_2 REVISION DETAIL https://phabricator.kde.org/D14542

D16106: Focus handling fixes

hein created this revision. hein added a reviewer: broulik. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY - Fix keyboard nav on the desktop again. BUG:399566 - Fix initial focus properly. - Make sure when using arrows after starting Plasma

D16087: RFC: Store full URL as URI

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense, even the argument is URI REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D16087 To: broulik, #plasma, hein, ivan, apol Cc: apol,

D16042: [ksmserver] remove unused suspend/resume startup API

This revision was automatically updated to reflect the committed changes. Closed by commit R120:06cb6cb61fec: [ksmserver] remove unused suspend/resume startup API (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D15201: Move logout-greeter into it's own subdir out of ksmserver

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f4ac46f0569d: Move logout-greeter into its own subdir out of ksmserver (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15201?vs=41608=43298#toc REPOSITORY R120

D16040: [ksmserver] remove dead code

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a1eb7a03e9be: [ksmserver] remove dead code (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16040?vs=43115=43300 REVISION

D15202: Move kcheckrunning into startkde

This revision was automatically updated to reflect the committed changes. Closed by commit R120:06bbb92a1730: Move kcheckrunning into startkde (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15202?vs=41351=43299#toc REPOSITORY R120 Plasma Workspace

D16065: [logoutprompt] Split greeter class into separate .h .cpp files

This revision was automatically updated to reflect the committed changes. Closed by commit R120:00395be673ab: [logoutprompt] Split greeter class into separate .h .cpp files (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

KDE CI: Plasma » systemsettings » kf5-qt5 FreeBSDQt5.11 - Build # 18 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.11/18/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Wed, 10 Oct 2018 09:57:14 + Build duration: 9 min 54 sec and counting CONSOLE OUTPUT

D16095: [Background Model] Use own QCache for thumbnails

This revision was automatically updated to reflect the committed changes. Closed by commit R120:de6f8246ecab: [Background Model] Use own QCache for thumbnails (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16095?vs=43275=43287

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.11 - Build # 17 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.11/17/ Project: kf5-qt5 SUSEQt5.11 Date of build: Wed, 10 Oct 2018 09:50:09 + Build duration: 12 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » systemsettings » kf5-qt5 FreeBSDQt5.11 - Build # 17 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.11/17/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Wed, 10 Oct 2018 09:50:09 + Build duration: 4 min 6 sec and counting CONSOLE OUTPUT

D15840: [Folder View] Remember selected item when navigating in subfolders

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6736bdaa4bbd: [Folder View] Remember selected item when navigating in subfolders (authored by thsurrel). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D14581: support for multilevel kcms

This revision was automatically updated to reflect the committed changes. Closed by commit R124:a079df6a5e3f: support for multilevel kcms (authored by mart). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14581?vs=40627=43281 REVISION DETAIL

D16095: [Background Model] Use own QCache for thumbnails

broulik updated this revision to Diff 43275. broulik edited the summary of this revision. broulik added a comment. - Clarify max cost REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16095?vs=43268=43275 REVISION DETAIL

D14542: KCM using new virtual desktops DBus interface

mart added a comment. In D14542#339584 , @hein wrote: > @mart There's a last FIXME in the QML code for a spacing hack (mentioned as a todo in the description). Could you give me a hand with that one? to me is not an hack, it's how

D16082: Notify headphone being plugged in on some hardware

thsurrel updated this revision to Diff 43271. thsurrel added a comment. Fixes as per broulik comments. Thanks for the review! REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16082?vs=43237=43271 BRANCH arc_ports (branched from

D13745: Implement support for virtual desktops on Wayland

mart added inline comments. INLINE COMMENTS > hein wrote in taskgroupingproxymodel.cpp:724 > The sorting code will look at the first desktop in practice, which is why it > should be the lowest desktop. I wasn't sure if I can rely on > PlasmaWindow::plasmaVirtualDesktops() to return the

D16095: [Background Model] Use own QCache for thumbnails

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Previously it would use an on-disk `KImageCache` which would never be

D15840: [Folder View] Remember selected item when navigating in subfolders

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. No worries, thanks for the patch :) REPOSITORY R119 Plasma Desktop BRANCH arc_folderview3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D15840 To: thsurrel,

D15840: [Folder View] Remember selected item when navigating in subfolders

thsurrel updated this revision to Diff 43266. thsurrel added a comment. I'm not sure how I managed to lose this bit when preparing this. Thanks for your patience, hein, I have been doing a pretty poor job on this patch. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D15840: [Folder View] Remember selected item when navigating in subfolders

hein added inline comments. INLINE COMMENTS > FolderView.qml:194 > function doCd(row) { > -history.push(url); > +history.push({"url": url, "index": gridView.currentIndex, > "contentY": gridView.contentY}); > updateHistory(); You're still storing contentY here.