D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-10-12 Thread Nathaniel Graham
ngraham added a comment. [Just as a reminder: this is only for the login screen; the lock screen is not being touched] I wish the conceptual concerns had been brought up in T9658 before I started implementing the design changes we agreed to there. It

D16170: [Device Notifier] Restore busy indicator

2018-10-12 Thread Nathaniel Graham
ngraham added reviewers: broulik, bruns. ngraham added a comment. I have no understanding of this code, but am adding some reviewers who do. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16170 To: thsurrel, #plasma, #vdg, broulik, bruns Cc: ngraham,

D16170: [Device Notifier] Restore busy indicator

2018-10-12 Thread Thomas Surrel
thsurrel added a comment. The bad news with this patch is that I don't understand it fully. Why were we doing polling before ? Why was it breaking the 'state' propagation ? What does it change not to do it anymore (performance hit ? something else ?) ? REPOSITORY R120 Plasma Workspace

D16170: [Device Notifier] Restore busy indicator

2018-10-12 Thread Thomas Surrel
thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY This patch fixes two issues: - the 'state' of the device now propagates correctly,

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.11 - Build # 18 - Still Failing!

2018-10-12 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.11/18/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 12 Oct 2018 19:40:00 + Build duration: 5 min 47 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » systemsettings » kf5-qt5 FreeBSDQt5.11 - Build # 19 - Fixed!

2018-10-12 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.11/19/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 12 Oct 2018 19:40:01 + Build duration: 5 min 19 sec and counting

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-10-12 Thread Root
rooty added a comment. In D16031#341773 , @davidedmundson wrote: > > why not? > > Because it makes for a inconsistent random experience p.s. :D i never wanted to do away with the blur in the first place, i think it's kinda cool,

D15247: Show tooltips in krunner

2018-10-12 Thread Oleg Solovyov
McPain added a comment. Additionally, tooltips are glitching if you move the mouse pointer too fast between items{F6324386 } REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D15247 To: McPain, #plasma, broulik, ngraham Cc: ngraham,

D15247: Show tooltips in krunner

2018-10-12 Thread Oleg Solovyov
McPain added a comment. Found out that sometimes displayed text appears to be elided (not always reproducible) Resolution: 1920x1080, dpi: 142 F6324374: Screenshot_20181012_165807.png REPOSITORY R112 Milou REVISION DETAIL

5.15 Kickoff Meeting Wednesday 17 2018 12:00UTC, 13:00BST, 14:00CEST

2018-10-12 Thread Jonathan Riddell
Let's have our meeting in #plasma at Wednesday 12:00UTC, 13:00BST, 14:00CEST Have at look at my schedule proposals https://notes.kde.org/p/plasma-5.15-kickoff And any ToDo items you want you can add on there too for discussion Jonathan

D15616: [Comic] Handle error state correctly

2018-10-12 Thread Anthony Fieroni
anthonyfieroni updated this revision to Diff 43461. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15616?vs=42286=43461 REVISION DETAIL https://phabricator.kde.org/D15616 AFFECTED FILES dataengines/comic/comicprovider.cpp To: anthonyfieroni,

D15616: [Comic] Handle error state correctly

2018-10-12 Thread David Edmundson
davidedmundson added a comment. yeah, that change in comicprovider I think makes sense. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D15616 To: anthonyfieroni, davidedmundson, #plasma, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D15616: [Comic] Handle error state correctly

2018-10-12 Thread Anthony Fieroni
anthonyfieroni added a comment. In D15616#341840 , @davidedmundson wrote: > The DataEngine also has a timer for timeouts, so we now have two timeout timers. > Having two timeout timers doesn't seem right. Yep, i'm on same opinion,

D15616: [Comic] Handle error state correctly

2018-10-12 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > but in such cases dataUpdated is not called In what cases? The DataEngine also has a timer for timeouts, so we now have two timeout timers. Having

D16087: RFC: Store full URL as URI

2018-10-12 Thread Kai Uwe Broulik
broulik added a comment. Alright, so we have two bugs then: 1. Task Manager does `QUrl("/foo/bar")` which results in an invalid URL. It must use `fromLocalFile` and/or check for whether it's a `/simple/path` or `sftp://proper/url` 2. EventSpy plugin just does `toLocalFile()` so recent

D16152: [Discover Notifier] Open Updates page in notification

2018-10-12 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When clicking the "there are new updates" notification it should go to the Updates page

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-10-12 Thread Root
rooty added a comment. In D16031#341773 , @davidedmundson wrote: > > why not? > > Because it makes for a inconsistent random experience perhaps, but a far more intuitive experience unless you're about to add a Slide to unlock

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-10-12 Thread Roman Gilg
romangg added a comment. The shadows look now better than in the first revision. Still I find the original version with full blur and darkened background way better to read for many background pictures. I don't think it's wort it to sacrifice this usability factor to allow a better view of

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-10-12 Thread David Edmundson
davidedmundson added a comment. > why not? Because it makes for a inconsistent random experience REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D16031 REVISION DETAIL https://phabricator.kde.org/D16031 To: ngraham, #vdg, #plasma, rizzitello Cc: davidedmundson, rizzitello,

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-10-12 Thread Root
rooty added a comment. In D16031#341646 , @davidedmundson wrote: > Why should the login screen look different to the lock screen? why not? the lock screen (like nate said) is fine the way it is and the login screen had the problem

D15616: [Comic] Handle error state correctly

2018-10-12 Thread Anthony Fieroni
anthonyfieroni added a comment. Someone? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D15616 To: anthonyfieroni, davidedmundson, #plasma, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16149: [Global Menu Applet] Fix menu layout option being always disabled

2018-10-12 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, davidedmundson, chinmoyr. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The setting was supposed to be disabled when global menu service was