D6056: [Run Command] Auto-close on focus loss only if query field is empty

2018-10-13 Thread Christoph Feck
cfeck added a comment. Please commit or abandon this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6056 To: broulik, #plasma, #vdg, davidedmundson Cc: cfeck, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D15011: [Kickoff] Make the search field always look like a search field

2018-10-13 Thread uRohan Kun
urohan added a comment. In D15011#342508 , @filipf wrote: > In D15011#342503 , @urohan wrote: > > > In D15011#342449 , @ngraham wrote: > > > > > Ah, I

D15011: [Kickoff] Make the search field always look like a search field

2018-10-13 Thread Filip Fila
filipf added a comment. In D15011#342503 , @urohan wrote: > In D15011#342449 , @ngraham wrote: > > > Ah, I didn't even know that the Activity Switcher had a search field. I suspect that @sharvey,

D15011: [Kickoff] Make the search field always look like a search field

2018-10-13 Thread Ivan Čukić
ivan added a comment. Different search bars are on different levels of usefulness. Use-cases for searching activities are much rarer than, for example, searching widgets. The current activity switcher UI clearly shows the search button, so there's no problem with discoverability. While

D15011: [Kickoff] Make the search field always look like a search field

2018-10-13 Thread uRohan Kun
urohan added a comment. In D15011#342504 , @sharvey wrote: > In D15011#342503 , @urohan wrote: > > > Anyway, I am not yet a contributor so my words are weightless. > > > Not true! We listen to

D15011: [Kickoff] Make the search field always look like a search field

2018-10-13 Thread Scott Harvey
sharvey added a comment. In D15011#342503 , @urohan wrote: > Anyway, I am not yet a contributor so my words are weightless. Not true! We listen to everyone's input. Unfortunately, it seems you're a little late to this party and the

D15011: [Kickoff] Make the search field always look like a search field

2018-10-13 Thread uRohan Kun
urohan added a comment. In D15011#342449 , @ngraham wrote: > Ah, I didn't even know that the Activity Switcher had a search field. I suspect that @sharvey, the fellow who did most of the work to improve the Widget Explorer's search field,

D15011: [Kickoff] Make the search field always look like a search field

2018-10-13 Thread Scott Harvey
sharvey added a comment. Let's see what we can do... I'll make the `Activities` change a separate diff, since this one's the most epic I've personally encountered. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg,

D15011: [Kickoff] Make the search field always look like a search field

2018-10-13 Thread Nathaniel Graham
ngraham added a comment. Yeah, and I extended that to simply make it always visible (if it exists; apparently it only does when there's more than one Activity). That's what we want here too. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham,

D15011: [Kickoff] Make the search field always look like a search field

2018-10-13 Thread Scott Harvey
sharvey added a comment. I can take a look at it. I didn't do anything regarding its visual appearance, just made it appear and disappear at will - by hiding or showing the row it was placed on. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To:

D16152: [Discover Notifier] Open Updates page in notification

2018-10-13 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks Kai! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D16152 To: broulik, #plasma, apol, ngraham Cc: ngraham, plasma-devel, ragreen, Pitel,

Willing to contribute

2018-10-13 Thread Antoon BERES
Hello, I'm pretty new to opensource projects etc in general, nevertheless, as a novice programmer the plasma-mobile project grabbed my interest. I am a chemist and hobby/amateur programmer (mainly python and C, still learning C, ..) I have been a linux/pc enthousiast for a long time and would

D15011: [Kickoff] Make the search field always look like a search field

2018-10-13 Thread Nathaniel Graham
ngraham added a comment. Ah, I didn't even know that the Activity Switcher had a search field. I suspect that @sharvey, the fellow who did most of the work to improve the Widget Explorer's search field, didn't know either. I agree that it's not ideal for these to be different. We should

D15247: Show tooltips in krunner

2018-10-13 Thread Andres Betts
abetts added a comment. Love it! Thanks for the patch! REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D15247 To: McPain, #plasma, broulik, ngraham Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol,

D13100: do not use buffered file IO

2018-10-13 Thread Rolf Eike Beer
dakon updated this revision to Diff 43538. dakon added a comment. O_CREAT was missing, as well as the file mode. O_CLOEXEC is available for a long time, there should be no need for the compat define. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13100?vs=34833=43538 REVISION

D15011: [Kickoff] Make the search field always look like a search field

2018-10-13 Thread uRohan Kun
urohan added a comment. In D15011#315779 , @ngraham wrote: > Awesome, thanks for introducing that additional information, @filipf. It seems like we have some inconsistency here in our Plasma search fields; I will summarize: > > | Interface