D16241: [Folder View] Improve layout and formatting of Icons page

2018-10-18 Thread Nathaniel Graham
ngraham updated this revision to Diff 43899. ngraham added a comment. Make the ghetto spacers invisible REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16241?vs=43835=43899 BRANCH icons-page-tweaks (branched from master) REVISION DETAIL

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

2018-10-18 Thread Nathaniel Graham
ngraham added a comment. Are there any other outstanding issues, or is this ready for review? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12925 To: progwolff, #plasma Cc: rkflx, ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D14697: X11: set GDK_SCALE (try 2)

2018-10-18 Thread Nathaniel Graham
This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R120:31e1a1a96ca2: X11: set GDK_SCALE (try 2) (authored by eszlari, committed by ngraham). REPOSITORY R120 Plasma

D14697: X11: set GDK_SCALE (try 2)

2018-10-18 Thread Peter Eszlari
eszlari added a comment. peter.eszl...@gmail.com REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697 To: eszlari, davidedmundson, ngraham, #plasma Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D14697: X11: set GDK_SCALE (try 2)

2018-10-18 Thread Nathaniel Graham
ngraham added a comment. @eszlari, can you provide an email address so we can land this with the proper authorship information? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697 To: eszlari, davidedmundson, ngraham, #plasma Cc: broulik, plasma-devel,

D14697: X11: set GDK_SCALE (try 2)

2018-10-18 Thread Nathaniel Graham
ngraham added a comment. Peter, can you provide an email address so we can land this with the proper authorship information? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697 To: eszlari, davidedmundson, ngraham, #plasma Cc: broulik, plasma-devel,

D14697: X11: set GDK_SCALE (try 2)

2018-10-18 Thread David Edmundson
davidedmundson added a comment. sure. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697 To: eszlari, davidedmundson, ngraham, #plasma Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14697: X11: set GDK_SCALE (try 2)

2018-10-18 Thread Nathaniel Graham
ngraham added a comment. I think that would make sense. @davidedmundson do you agree? It would be nice to have three months to live with this and see if there are any bugs (my testing is clean FWIW). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697

D14697: X11: set GDK_SCALE (try 2)

2018-10-18 Thread Kai Uwe Broulik
broulik resigned from this revision. broulik added a comment. I guess this can go in so we can have a full cycle of testing? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697 To: eszlari, davidedmundson, ngraham, #plasma Cc: broulik, plasma-devel,

D16241: [Folder View] Improve layout and formatting of Icons page

2018-10-18 Thread Andres Betts
abetts added a comment. In D16241#345082 , @ngraham wrote: > Kirigami FormLayout is a really nice control to work with. I'm a big fan. This port was easy peasy and I can't wait to do more of these! > > The double `Kirigami.Separator` items

D16287: [Comics & Weather widgets] give "Configure..." buttons icons

2018-10-18 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R114:bd558d122885: [Comics Weather widgets] give Configure... buttons icons (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D16297: [DBusMenuImporter] Don't call removeAction() to avoid an empty QMenu

2018-10-18 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, davidedmundson, poboiko. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY As soon as `QMenu` becomes empty it is closed. This can happen when the

D15093: Add WireGuard capability.

2018-10-18 Thread Jan Grulich
jgrulich added inline comments. INLINE COMMENTS > andersonbruce wrote in wireguardwidget.cpp:60 > My apologies if I sound a little frustrated on this but I spent more than 4 > hours trying to follow the very unclear documentation on handling colors > before making this change. I thought the

D15093: Add WireGuard capability.

2018-10-18 Thread Bruce Anderson
andersonbruce added inline comments. INLINE COMMENTS > jgrulich wrote in wireguardwidget.cpp:60 > Do not use KColorScheme. Use QPalette instead and you don't need to keeping > it as class variable. My apologies if I sound a little frustrated on this but I spent more than 4 hours trying to

D16292: [Minimize All Plasmoid] Import QtQuick 2.7

2018-10-18 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R114:f328668559cc: [Minimize All Plasmoid] Import QtQuick 2.7 (authored by broulik). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16292?vs=43850=43854 REVISION

D14830: Add "Configure Displays" context menu entry on the desktop

2018-10-18 Thread Kai Uwe Broulik
broulik added a comment. Note that Microsoft removed that option in Vista in favor of a "Personalize" option but brought a dedicated Screen configuration entry back in Windows 7 which has remained to this very day. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D16292: [Minimize All Plasmoid] Import QtQuick 2.7

2018-10-18 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `Connections.enabled` was only added in Qt 5.7 BUG: 399947 FIXED-IN: 5.14.2 TEST PLAN