D16241: [Folder View] Improve layout and formatting of Icons page

2018-10-19 Thread Nathaniel Graham
ngraham updated this revision to Diff 43959. ngraham added a comment. - Also do the Location page - Use `Spacer` items instead of hacks REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16241?vs=43899&id=43959 BRANCH icons-page-tweaks (branched fro

D16330: Add a vertical spacer item

2018-10-19 Thread Nathaniel Graham
ngraham updated this revision to Diff 43958. ngraham added a comment. - Make it an Item, not a Rectangle - Make it do horizontal spacing too REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16330?vs=43954&id=43958 BRANCH verticalspacer (branched from ma

D16331: GTK theme typo/bug fix

2018-10-19 Thread Olli Helin
ohelin created this revision. ohelin added a reviewer: Breeze. ohelin added a project: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ohelin requested review of this revision. REVISION SUMMARY Fixes a typo in the CSS files which resulted in GTK treeviews being u

D16330: Add a vertical spacer item

2018-10-19 Thread Alexey Min
alexeymin added a comment. 1. What if in the future another, horizontal spacer component will become needed? Will you add a HorizontalSpacer.qml then? 😆 Maybe have just a Spacer with `horizontal` property? 2. Why `Rectangle`, it could be just `Item`, it does not cause rendering (Rectangle

D16241: [Folder View] Improve layout and formatting of Icons page

2018-10-19 Thread Nathaniel Graham
ngraham added a comment. Instead of ghetto DIY spacers, maybe we can use purpose-built vertical spacers: D16330: Add a vertical spacer item REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16241 To: ngraham, #plasma, #vdg,

D16330: Add a vertical spacer item

2018-10-19 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: mart, Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch creates a very simple vertical spacer item that can be used to add a pre-dete

D16329: Add a ReadMe with install from Git instructions and bugzilla links

2018-10-19 Thread Chris Holland
Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY TODO: Figure out all the build dependencies. REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabric

D16328: Saner config defaults

2018-10-19 Thread Chris Holland
Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Make sure the buttons have a dedicated place, filling the entire height of the panel rather than only 50%. We could probably limit the si

D16327: Update libdbusmenuqt folder

2018-10-19 Thread Chris Holland
Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY I needed to add `include(ECMQtDeclareLoggingCategory)` to the root `CMakeLists.txt` to get it to compile. https://github.com/KDE/pla

D16309: Add accessibility information to desktop icons

2018-10-19 Thread Christian Hempfling
chempfling added a comment. Ok, so nothing to do then. Is this merged automatically once per day or something? Or how do i get the patch into master now? I mark the task as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16309 To: chempfling, hein, g

D16212: [Device Notifier] Add a button to unmount all devices

2018-10-19 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a subscriber: broulik. ngraham added a comment. This revision is now accepted and ready to land. Consider it VDG-approved! The button label vastly improves the situation IMHO. Now, is it @broulik -approved? ;) REPOSITORY R120 Plasma Workspac

D16309: Add accessibility information to desktop icons

2018-10-19 Thread Frederik Gladhorn
gladhorn added a comment. I guess we can go with this for now, let's be pragmatic. Qt doesn't have icon or desktop_icon at the moment. I can add, if Joanie suggests doing that on the Orca mailing list. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16309 To

D16212: [Device Notifier] Add a button to unmount all devices

2018-10-19 Thread Thomas Surrel
thsurrel updated this revision to Diff 43929. thsurrel added a comment. Add a text label to the new button Fixes to hide the button correctly when devices unmount REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16212?vs=43624&id=43929 BRANCH ar

2019 Plasma release schedule

2018-10-19 Thread Jonathan Riddell
I've made the Plasma release schedule for 2019 https://community.kde.org/Schedules/Plasma_5 Plasma 5.15 (using Frameworks 5.54) beta is Jan 17th and final Feb 12th. Plasma 5.16.0 June 11 Plasma 5.17.0 Oct 15 It's in Phabricator https://phabricator.kde.org/calendar/query/month/2018/11/ and my Go

D16309: Add accessibility information to desktop icons

2018-10-19 Thread Christian Hempfling
chempfling added a comment. Do i need to do anythin else to get it into master? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16309 To: chempfling, hein, gladhorn Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, se

D16309: Add accessibility information to desktop icons

2018-10-19 Thread Christian Hempfling
chempfling added inline comments. INLINE COMMENTS > gladhorn wrote in FolderItemDelegate.qml:45 > Is Canvas what Gnome uses for desktop icons? I'm fine with this, since I > don't have a better suggestion. Canvas is used by Nautilus. The default filemanager. Joanie would prefer the Role „Icon“

D16316: [Kicker] Rename id column to itemColumn

2018-10-19 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY In Qt 5.12 new magic `column` and `row` properties appeared in the delegate's scope, similar

D15887: Fix Klipper popup opening on default screen instead of at cursor position

2018-10-19 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:90466f3cd655: Fix Klipper popup opening on default screen instead of at cursor position (authored by romangeints, committed by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST U

D15887: Fix Klipper popup opening on default screen instead of at cursor position

2018-10-19 Thread Roman Geints
romangeints added a comment. roman...@gmail.com REVISION DETAIL https://phabricator.kde.org/D15887 To: romangeints, #plasma, davidedmundson Cc: mvourlakos, romangeints, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

5.15 New Features notepad

2018-10-19 Thread Rik Mills
On 19/10/2018 13:37, Rik Mills wrote: > notes.kde.org refuses to allow log in Seems to have rectified itself. :)

D15887: Fix Klipper popup opening on default screen instead of at cursor position

2018-10-19 Thread David Edmundson
davidedmundson added a comment. What's your email address? (for the commit log) REVISION DETAIL https://phabricator.kde.org/D15887 To: romangeints, #plasma, davidedmundson Cc: mvourlakos, romangeints, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, s

D16309: Add accessibility information to desktop icons

2018-10-19 Thread Frederik Gladhorn
gladhorn accepted this revision. gladhorn added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > FolderItemDelegate.qml:45 > +Accessible.name: name > +Accessible.role: Accessible.Canvas > function openPopup() { Is Canvas what Gnome uses for desktop

D16170: [Device Notifier] Restore busy indicator

2018-10-19 Thread Nathaniel Graham
ngraham added a comment. FWIW, I can confirm that https://bugs.kde.org/show_bug.cgi?id=399986 is fixed with this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16170 To: thsurrel, #plasma, #vdg, broulik, bruns Cc: ngraham, plasma-devel, ragreen, Pitel, Zr

Re: 5.15 New Features notepad

2018-10-19 Thread Rik Mills
On 19/10/2018 11:18, Jonathan Riddell wrote: > As discussed at the meeting starting the 5.15 new features notepad > early, please add things as you merge them in > https://notes.kde.org/p/plasma_5_15 > > Jonathan > notes.kde.org refuses to allow log in

D15887: Fix Klipper popup opening on default screen instead of at cursor position

2018-10-19 Thread Roman Geints
romangeints added a comment. Am I right thinking no further action is expected from me? REVISION DETAIL https://phabricator.kde.org/D15887 To: romangeints, #plasma, davidedmundson Cc: mvourlakos, romangeints, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, a

5.15 New Features notepad

2018-10-19 Thread Jonathan Riddell
As discussed at the meeting starting the 5.15 new features notepad early, please add things as you merge them in https://notes.kde.org/p/plasma_5_15 Jonathan

Can't unsubscribe

2018-10-19 Thread tajames
Hello all, I'm currently having some issues with my email acccounts, and I'd like to unsubscribe from plasma-devel.  I've tried unsubscribing through the web portal and I've tried resetting my password - neither option appears to do anything.  Coudl someone please manually take me off the list?