D16331: GTK theme treeview style typo/bug fix

This revision was automatically updated to reflect the committed changes. Closed by commit R98:a742b49636d9: GTK theme treeview style typo/bug fix (authored by ohelin, committed by ngraham). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16331?vs=43956&i

D16331: GTK theme treeview style typo/bug fix

ngraham added a comment. Thanks, that's very helpful. Could you comment there too? Also, it would be even better if you could apply the patch and give it a spin. Here's the documentation: https://community.kde.org/Infrastructure/Phabricator#How_to_review_someone_else.27s_patch As for th

D16331: GTK theme treeview style typo/bug fix

ohelin added a comment. In D16331#346540 , @ngraham wrote: > Thanks, can you provide us with your real name and email address so we can land this with proper authorship information? > > On the subject of GTK theme fixes, we also have a very l

D16331: GTK theme treeview style typo/bug fix

ngraham added subscribers: jackg, ngraham. ngraham added a comment. Thanks, can you provide us with your real name and email address so we can land this with proper authorship information? On the subject of GTK theme fixes, we also have a very large and ambitious patch: D15786: share com

D16327: Update libdbusmenuqt folder

davidedmundson added a comment. > Yeah, I'm not 100% sure why the Active Window Control widget needs it. AWC started out as some github project without asking us to make a plugin. Which would be (IMHO) the best path moving forwards. Note also libdbusmenu-qt upstream is both expor

D16339: sddm-kcm: don't hardcode session file location.

tcberner created this revision. tcberner added a reviewer: FreeBSD. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcberner requested review of this revision. REVISION SUMMARY The sddm-kcm uses /usr/share/xsessions and /usr/share/wayland-sessions pathes, but in FreeBSD

D16327: Update libdbusmenuqt folder

Zren added a comment. KNotifications provides an example of linking to `dbusmenu-qt5`: https://github.com/KDE/knotifications/blob/master/src/CMakeLists.txt#L46-L49 However REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D16327 To

D16331: GTK theme treeview style typo/bug fix

ohelin added a comment. In D16331#346191 , @broulik wrote: > Thanks, makes sense. Do you have commit access? I don't think so, I just created the KDE account for this. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator

D16331: GTK theme treeview style typo/bug fix

ohelin added a comment. In D16331#346192 , @broulik wrote: > I noticed there's a bunch more places where `seperator` is used, e.g. in `gtk-3.18` and dark, I guess these should be fixed as well? Yeah definitely, but... I'm not familiar wit

D16327: Update libdbusmenuqt folder

Zren added a comment. Yeah, I'm not 100% sure why the Active Window Control widget needs it. I assume it should be dynamically linking to the `/usr/lib/x86_64-linux-gnu/libdbusmenu-qt.so.2`, but I wanted to update all the common code first before making major refactoring. REPOSITORY R884

D16331: GTK theme treeview style typo/bug fix

broulik added a comment. I noticed there's a bunch more places where `seperator` is used, e.g. in `gtk-3.18` and dark, I guess these should be fixed as well? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D16331 To: ohelin, #breeze, #vdg, broulik Cc: plasma-de

D16331: GTK theme treeview style typo/bug fix

broulik added a comment. Thanks, makes sense. Do you have commit access? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D16331 To: ohelin, #breeze, #vdg, broulik Cc: plasma-devel, #breeze, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abett

D16327: Update libdbusmenuqt folder

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Can you rebase this patch? I already made it use categorized logging a few weeks ago. There's also random other bits of changes, be more specific what the change should do, "upd

D16327: Update libdbusmenuqt folder

broulik resigned from this revision. broulik added a comment. Oh, wait, appmenu thing has its own copy of libdbusmenu-qt? REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D16327 To: Zren Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot