KDE CI: Plasma » systemsettings » stable-kf5-qt5 FreeBSDQt5.11 - Build # 10 - Fixed!

2018-10-23 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20FreeBSDQt5.11/10/ Project: stable-kf5-qt5 FreeBSDQt5.11 Date of build: Wed, 24 Oct 2018 06:16:31 + Build duration: 27 min and counting

D15616: [Comic] Handle error state correctly

2018-10-23 Thread Anthony Fieroni
anthonyfieroni added a comment. @davidedmundson to commit or you have other objections? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D15616 To: anthonyfieroni, davidedmundson, #plasma, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed

D15206: [Kickoff] Add a subtle separator line between the header and the content view

2018-10-23 Thread Andres Betts
abetts added a comment. Does the blue line from the selected content touch the divider line you are prosing? If it isn't, I would suggest no gap between those two lines. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15206 To: ngraham, #plasma, #vdg Cc: abet

D15206: [Kickoff] Add a subtle separator line between the header and the content view

2018-10-23 Thread Nathaniel Graham
ngraham added a comment. Sorry it's taken me so long to get this right. Things have been crazy busy lately! This is ready for review. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15206 To: ngraham, #plasma, #vdg Cc: abetts, mmustac, hein, plasma-devel, rag

D15206: [Kickoff] Add a subtle separator line between the header and the content view

2018-10-23 Thread Nathaniel Graham
ngraham updated this revision to Diff 44134. ngraham added a comment. - Rebase on master - Do everything in this patch - Draw the lines in a prettier way REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15206?vs=41788&id=44134 BRANCH arcpatch-D1

D16394: Hide Buttons With Empty Text (Gtk Separators)

2018-10-23 Thread Chris Holland
Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Fixes issue #146 on GitHub: https://github.com/kotelnik/plasma-applet-active-window-control/issues/146 This is the same method the

D16381: Only use wl-shell for the ksmserver greeters on Qt < 5.12

2018-10-23 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R120:790f5bf48f2b: Only use wl-shell for the ksmserver greeters on Qt < 5.12 (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16381?vs=44093&

D16381: Only use wl-shell for the ksmserver greeters on Qt < 5.12

2018-10-23 Thread Fabian Vogt
fvogt added a comment. I created https://bugreports.qt.io/browse/QTBUG-71350 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16381 To: fvogt, #plasma Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D16381: Only use wl-shell for the ksmserver greeters on Qt < 5.12

2018-10-23 Thread Fabian Vogt
fvogt added a comment. In D16381#347483 , @davidedmundson wrote: > Do Qt know it's broken? It shouldn't be Not yet. There is a warning on stderr that wl-shell shouldn't be used though. REPOSITORY R120 Plasma Workspace REVISION DETAIL

Plasma 5.14.2 released

2018-10-23 Thread Bhushan Shah
Plasma 5.14.2 is released : https://www.kde.org/announcements/plasma-5.14.2.php Thanks! -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

D16384: Avoid needless config parse

2018-10-23 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY There's practically no reason to ever open kdeglobals. The way the kde casc

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

2018-10-23 Thread Nathaniel Graham
ngraham added a comment. If this patch can, practically speaking, be applied and used, I'm happy to offer some UI review, and I suspect other #VDG folks would, too. If not, screenshots would be helpful. :) REPOSITORY R119 Plasma Desktop REVISION DET

KDE CI: Plasma » systemsettings » stable-kf5-qt5 FreeBSDQt5.11 - Build # 9 - Failure!

2018-10-23 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20FreeBSDQt5.11/9/ Project: stable-kf5-qt5 FreeBSDQt5.11 Date of build: Tue, 23 Oct 2018 10:41:35 + Build duration: 7 min 41 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.11 - Build # 8 - Failure!

2018-10-23 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.11/8/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Tue, 23 Oct 2018 10:35:33 + Build duration: 6 min 51 sec and counting CONSOLE OUTPUT [

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.11 - Build # 6 - Failure!

2018-10-23 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.11/6/ Project: stable-kf5-qt5 FreeBSDQt5.11 Date of build: Tue, 23 Oct 2018 10:35:33 + Build duration: 1 min 1 sec and counting CONSOLE OUTPUT

D14542: KCM using new virtual desktops DBus interface

2018-10-23 Thread Vlad Zagorodniy
zzag added a comment. It looks like this revision now also includes Marco's patch. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D14542 To: hein, mart, davidedmundson, ltoscano, zzag Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, jackyalcine, Pit

D16381: Only use wl-shell for the ksmserver greeters on Qt < 5.12

2018-10-23 Thread David Edmundson
davidedmundson added a comment. Do Qt know it's broken? It shouldn't be REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16381 To: fvogt, #plasma Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, seba

D15599: Port the "Switch Desktop" containment action to libtaskmanager

2018-10-23 Thread Eike Hein
hein updated this revision to Diff 44096. hein added a comment. Fix off-by-one. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15599?vs=43811&id=44096 BRANCH arcpatch-D15599 REVISION DETAIL https://phabricator.kde.org/D15599 AFFECTED FILES

D14542: KCM using new virtual desktops DBus interface

2018-10-23 Thread Eike Hein
hein updated this revision to Diff 44095. hein added a comment. - Fix Exec - Clean up KCM titles REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14542?vs=43814&id=44095 BRANCH arcpatch-D14542_1 REVISION DETAIL https://phabricator.kde.org/D14542 AFFECTE

D15599: Port the "Switch Desktop" containment action to libtaskmanager

2018-10-23 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > desktop.cpp:58 > } else if (m_actions.count() > numDesktops) { > -for (int i = numDesktops +1; i <= m_actions.count(); ++i) { > -delete m_actions[i]; > -m_actions.remove(i); > +for (int i = m_actions.count(

D14542: KCM using new virtual desktops DBus interface

2018-10-23 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > kcm_kwin_virtualdesktops.desktop:2 > [Desktop Entry] > +Exec=kcmshell5 kwn_virtualdesktops > +Icon=preferences-desktop Is it a typo? > main.qml:30 > + > +ConfigModule.quickHelp: i18n("Virtual Desktops NG") > + I suppose we don't need NG anymor

D16381: Only use wl-shell for the ksmserver greeters on Qt < 5.12

2018-10-23 Thread Fabian Vogt
fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY Apparently wl-shell fullscreen is broken on Qt 5.12 now, but we don't need this workaround anymore. BUG: 399918 TEST PLAN Clicked on l