D15093: Add WireGuard capability.

andersonbruce marked 9 inline comments as done. andersonbruce added inline comments. INLINE COMMENTS > jgrulich wrote in plasmanetworkmanagement_wireguardui.desktop:16 > Name could be just WireGuard I guess I left this alone because it is consistent with the names of other VPNs. > jgrulich wrot

D15093: Add WireGuard capability.

andersonbruce added a comment. A couple of notes on the latest upload: 1. I left the background color change code alone. Doing searches on changing widget background color, it looks like the preferred method is to use setPalette() which requires a QPalette, and after trying a couple of t

D15093: Add WireGuard capability.

andersonbruce updated this revision to Diff 44198. andersonbruce added a comment. - Address review comments REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15093?vs=42290&id=44198 BRANCH Feature/AddWireGuardVPN REVISION DETAIL

D16417: Improve replacement text when action description is not provided

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, this works. INLINE COMMENTS > bruns wrote in AuthDialog.cpp:359 > Btw, "not provided" is your own proposal ;-) What!? I must be going senile already... REPOSITORY R121 Policyk

D12498: Fully remove `Application Name` from Details panel

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH arcpatch-D12498 REVISION DETAIL https://phabricator.kde.org/D12498 To: bruns, ngraham, davidedmundson, sharvey Cc: davi

D16365: share common values for both Breeze and Breeze-dark GTK themes

ngraham accepted this revision. ngraham added a subscriber: grmat. ngraham added a comment. This revision is now accepted and ready to land. I haven't noticed any problems running with this over the past few days. It's unfortunate that neither the maintainer (@jackg) nor anyone else familiar w

[Powerdevil] [Bug 304696] Display is dimmed in half the time you configure to dim

https://bugs.kde.org/show_bug.cgi?id=304696 Chris Holland changed: What|Removed |Added CC||zrenf...@gmail.com --- Comment #14 from Chris H

D16419: [kickoff] Wordwrap long sentence in config

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Text should always be constrained and should almost always elide or wrap.

D16417: Improve replacement text when action description is not provided

bruns added inline comments. INLINE COMMENTS > ngraham wrote in AuthDialog.cpp:359 > I would prefer "not available" over "not provided", but I won't choose this > as my hill to die on. :) > > Do we actually need to repeat the word 'Description' here? Btw, "not provided" is your own proposal ;-

D15885: Clean UI file for `details` portion of UI

bruns abandoned this revision. bruns added a comment. Folded back into D12498 REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D15885 To: bruns, ngraham, davidedmundson, sharvey Cc: bruns, plasma-devel, ragreen,

D16403: Add services and appstream runner debug categories to categories file

This revision was automatically updated to reflect the committed changes. Closed by commit R120:17a0d34d0e83: Add services and appstream runner debug categories to categories file (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D164

D16417: Improve replacement text when action description is not provided

bruns added inline comments. INLINE COMMENTS > ngraham wrote in AuthDialog.cpp:356 > So I gather `.isEmpty()` works now? Yes. > ngraham wrote in AuthDialog.cpp:359 > I would prefer "not available" over "not provided", but I won't choose this > as my hill to die on. :) > > Do we actually need

D12498: Fully remove `Application Name` from Details panel

bruns updated this revision to Diff 44184. bruns added a comment. Update UI file Split out "description" change REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12498?vs=42375&id=44184 BRANCH arcpatch-D12498 REVISION DETAIL https:

D16417: Improve replacement text when action description is not provided

ngraham added inline comments. INLINE COMMENTS > AuthDialog.cpp:356 > -// replace blank description > -// neither isEmpty() or isNull() worked (?) > -if (actionDescription.description() == "") { So I gather `.isEmpty()` works now? > AuthDialog.cpp:359 > action_label->setFon

D16417: Improve replacement text when action description is not provided

bruns created this revision. bruns added reviewers: Plasma, ngraham, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY The polkit rules specification mandates a description for actions, https://ww

D16327: Update libdbusmenuqt folder

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R884:bb680e8dbfc2: Update libdbusmenuqt folder (authored by Zren). REPOSITORY R884 Active Window Control Applet for Pla

D16394: Hide Buttons With Empty Text (Gtk Separators)

This revision was automatically updated to reflect the committed changes. Closed by commit R884:942169541d33: Hide Buttons With Empty Text (Gtk Separators) (authored by Zren). REPOSITORY R884 Active Window Control Applet for Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16394

D15206: [Kickoff] Add a subtle separator line between the header and the content view

ngraham added a comment. No, the blue highlight doesn't touch, just like people requested. It looks just fine now. If we want to make the blue highlight touch the bounds of its whole view, that would be a significant design change that would need to be made elsewhere (if indeed it would be d

D15855: Port Kickoff to shared view component using single-MouseArea pattern

ngraham added a comment. Oops, sorry, I forgot to change my status! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15855 To: hein, #plasma, ngraham, davidedmundson Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, j

D16212: [Device Notifier] Add a button to unmount all devices

ngraham added a comment. Ping! Can we get a review from a #plasma person? REPOSITORY R120 Plasma Workspace BRANCH arc_unmountall (branched from master) REVISION DETAIL https://phabricator.kde.org/D16212 To: thsurrel, #plasma, #vdg, ngraham Cc

D16410: [Bookmarks Runner] Avoid leaking FetchSqlite instances

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY The favicon and places instances are created in the prepare() call, leaking the instance from the

D16409: [Bookmarks Runner] Open database connection in the query thread

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY QSqlDatabase connection instances are global reference counted objects which can be crated using t

D16405: Add debug category for bookmarks runner

bruns added a comment. Only applies cleanly after D16403 . REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D16405 To: bruns, #frameworks, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai

D16405: Add debug category for bookmarks runner

bruns added a comment. Depends on the cleanup in D16404 , as the autogenerated `bookmarks_debug.cpp` is not linked to the tests/testChromeBookmarks binary otherwise. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator

D16327: Update libdbusmenuqt folder

Zren added a comment. For now, I'm going to merge this so I can keep the widget in sync with the global menu widget. We can revisit linking to a shared library later on. REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D16327 To: Zren C

D16405: Add debug category for bookmarks runner

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Dependency for followup patches, no functional change TEST PLAN make REPOSITORY R120 Plasma Wo

D16402: Cleanup - remove unnecessary QIcon include

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9945aecaf2eb: Cleanup - remove unnecessary QIcon include (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16402?vs=44159&id=44163 REVIS

D16404: [Bookmarks Runner] Cleanup tests CMakeList

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Build the test dependencies as static library. Remove duplicate and commented out lines. Use ecm_a

D16403: Add services and appstream runner debug categories to categories file

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Make the debug categories visible in kdebugsettings REPOSITORY R120 Plasma Workspace BRANCH ma

D16402: Cleanup - remove unnecessary QIcon include

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY QIcon is only used in the implementation, not in the interface. TEST PLAN compile tested, no func

[Powerdevil] [Bug 304696] Display is dimmed in half the time you configure to dim

https://bugs.kde.org/show_bug.cgi?id=304696 S changed: What|Removed |Added CC||sb56...@gmail.com --- Comment #13 from S --- Created attac

D15616: [Comic] Handle error state correctly

This revision was automatically updated to reflect the committed changes. Closed by commit R114:7c7c00798048: [comicprovider] Restart timer on redirect request (authored by anthonyfieroni). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15616?vs=43461&id

D16400: Prefer to set current mode in resolution combobox

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY Preferred resolution may be lower than current resolution (e.g. on KVM), in this case it will be selected in the combobox instead of

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

lavender added a comment. This redesign seems like a good place to start thinking about integrating accessibility options T with the rest of the settings. I included some screenshots of what OSX does (Switch Control

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:24bdc06747ed: [server] Respect input region of sub-surfaces on pointer surface focus (authored by romangg). REPOSITORY

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

romangg updated this revision to Diff 44149. romangg added a comment. Rebase on master. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7038?vs=42733&id=44149 BRANCH inputRegionSubSurfaces REVISION DETAIL https://phabricator.kde.org/D7038 AFFECTED FI

D15855: Port Kickoff to shared view component using single-MouseArea pattern

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:48b32259e73f: Port Kickoff to shared view component using single-MouseArea pattern (authored by hein). REPOSITORY R1

D16368: Swap Trash/Delete when Shift is used while the menu is open

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c4285ed1b407: Swap Trash/Delete when Shift is used while the menu is open (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16368?vs=44091&i