D16587: [ksmserver] Simplify call to kcminit

This revision was automatically updated to reflect the committed changes. davidedmundson marked an inline comment as done. Closed by commit R120:8c85bfa65a11: [ksmserver] Simplify call to kcminit (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6a4f4cc31ebc: [Folder View] Improve layout, formatting, and wording of Icons and Locations… (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D16595: Fix i18n when the kcm code is embedded in the plasmoid config

broulik added a comment. We use everything in Plasma "as a library", that's why `KDeclarative::QmlObject` sets a translation context on the root context, so that plasmoids, wallpaper plugins, and other QML bits can use `i18n` with no translation domain (only exception really being the look

D16595: Fix i18n when the kcm code is embedded in the plasmoid config

aacid added a comment. In D16595#352466 , @broulik wrote: > This is only covering an underlying problem where `KDeclarative` fails to set the translation context on `QQmlContext` as the engines are shared and it then refuses to set anything on

D16595: Fix i18n when the kcm code is embedded in the plasmoid config

broulik added a comment. This is only covering an underlying problem where `KDeclarative` fails to set the translation context on `QQmlContext` as the engines are shared and it then refuses to set anything on the "internal context". But since I haven't found a solution, perhaps this is

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

zzag added a comment. Other issues: - if I remove a virtual desktop and apply settings, it's not possible anymore to add or remove virtual desktops; - if I create a virtual desktop, then for some reason the KCM will try to create more than one: F6377804:

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

hein updated this revision to Diff 44673. hein added a comment. Fix build error. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14542?vs=44672=44673 BRANCH arcpatch-D14542_2 REVISION DETAIL https://phabricator.kde.org/D14542 AFFECTED FILES

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

hein updated this revision to Diff 44672. hein retitled this revision from "KCM using new virtual desktops DBus interface" to "[kcmkwin/desktop] KCM using new virtual desktops DBus interface". hein added a comment. Update the title. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D14542: KCM using new virtual desktops DBus interface

hein updated this revision to Diff 44671. hein added a comment. - Sync ids before syncing names. - Remove the dummy id swap, it's no longer needed given the above. - Add a class description comment that illuminates the sync/detach behavior. - Reindent headers. REPOSITORY R108 KWin

D14542: KCM using new virtual desktops DBus interface

zzag added inline comments. INLINE COMMENTS > desktopsmodel.cpp:253 > + > +call.setArguments({m_desktops.last()}); > + Is m_desktops.last() the right one? It can be already deleted. For example, If user has two virtual desktops: - Desktop 1 - Pizza and he or she wants to delete

D14542: KCM using new virtual desktops DBus interface

zzag requested changes to this revision. zzag added inline comments. INLINE COMMENTS > desktopsmodel.cpp:413 > +// so we can determine when we are in sync. > +const QString = m_desktops.at(data.position); > +m_names.remove(dummyId); Is this right? If I remove a desktop

D16598: enable animations for standalone created buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R113:f88caf298dbe: enable animations for standalone created buttons (authored by mvourlakos). REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16598?vs=44667=44668

D16284: do not force text display for ToolButton

ngraham added a subscriber: hein. ngraham added a comment. To me, using `Qt::ToolButtonFollowStyle` would seem to make sense, but it might be best to ask @mart or @hein, who may know more of the history behind why `Qt::ToolButtonTextBesideIcon` was chosen here in the first place. REPOSITORY

D16598: enable animations for standalone created buttons

mvourlakos created this revision. mvourlakos added reviewers: Plasma, hpereiradacosta, zzag. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mvourlakos requested review of this revision. REVISION SUMMARY --as mentioned at T9899 we are

D16284: do not force text display for ToolButton

astippich added a subscriber: mgallien. astippich added a comment. @mgallien stated in the meantime that we probably have been abusing the ToolButton in Elisa for our needs, and we will go a different route anyway. Since the desktop style still behaves differently than QQC1 and the Fusion

D16596: enable animations for standalone created buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R31:19348e1ccb32: enable animations for standalone created buttons (authored by mvourlakos). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16596?vs=44663=44664 REVISION

Re: Plasma 5.14.2 released

Updated :) On Wed, Oct 24, 2018 at 2:31 AM Bhushan Shah wrote: > Plasma 5.14.2 is released : > https://www.kde.org/announcements/plasma-5.14.2.php > > Thanks! > > -- > Bhushan Shah > http://blog.bshah.in > IRC Nick : bshah on Freenode > GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07

D16596: enable animations for standalone created buttons

mvourlakos updated this revision to Diff 44663. mvourlakos added a comment. - fix comment description REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16596?vs=44662=44663 BRANCH fixCreator REVISION DETAIL https://phabricator.kde.org/D16596 AFFECTED

D16596: enable animations for standalone created buttons

mvourlakos created this revision. mvourlakos added reviewers: Breeze, zzag. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mvourlakos requested review of this revision. REVISION SUMMARY --as mentioned at T9899 we are not calling the

D16595: Fix i18n when the kcm code is embedded in the plasmoid config

aacid created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY You can get to this code by right clicking on the plasmoid, when doing that the kcm translation catalog is not loaded so we must make

D16284: do not force text display for ToolButton

ngraham added a comment. Wouldn't this change make it revert to the default value, which is `Qt::ToolButtonIconOnly` ? How about `Qt::ToolButtonFollowStyle` instead? That way it'll pick up the user-overridable setting in the

D16284: do not force text display for ToolButton

astippich added a comment. opinions? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16284 To: astippich, mart, apol Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16404: [Bookmarks Runner] Cleanup tests CMakeList

bruns added a comment. Ping! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16404 To: bruns, #frameworks Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14542: KCM using new virtual desktops DBus interface

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I understand what you're doing with the syncing now, it makes sense in principle. Can you copy-paste what you typed to me into the code. INLINE COMMENTS >

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.11 - Build # 143 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.11/143/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 01 Nov 2018 16:50:42 + Build duration: 52 min and counting JUnit Tests Name: (root) Failed: 19

D14542: KCM using new virtual desktops DBus interface

hein added a comment. In D14542#352260 , @zzag wrote: > Please wait for others. > > When you're about to push, please: > > - re-title this patch to "[kcmkwin/desktop] Use new ..."; > - shift access modifiers and everything that goes

D14542: KCM using new virtual desktops DBus interface

zzag accepted this revision. zzag added a comment. Please wait for others. When you're about to push, please: - re-title this patch to "[kcmkwin/desktop] Use new ..."; - shift access modifiers and everything that goes below 4 spaces to the left (that's one of my inline comments).

D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

hein accepted this revision. hein added a comment. Looks great, I'm happy to finally see this get cleaned up. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16241 To: ngraham, #plasma, #vdg, hein, mart Cc: mart, abetts, thsurrel, plasma-devel, ragreen,

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.11 - Build # 142 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.11/142/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 01 Nov 2018 15:36:02 + Build duration: 5 min 3 sec and counting CONSOLE OUTPUT [...truncated 623.83

[Powerdevil] [Bug 360162] Segfault at startup (just after login)

https://bugs.kde.org/show_bug.cgi?id=360162 Andrew Crouthamel changed: What|Removed |Added Status|REPORTED|NEEDSINFO Resolution|---

D16587: [ksmserver] Simplify call to kcminit

davidedmundson updated this revision to Diff 44630. davidedmundson added a comment. remove Q_SIGNALS REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16587?vs=44628=44630 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16587

D16587: [ksmserver] Simplify call to kcminit

zzag added inline comments. INLINE COMMENTS > main.h:37 > Q_SCRIPTABLE void runPhase2(); > -Q_SIGNALS: //dbus signal > - Q_SCRIPTABLE void phase1Done(); > - Q_SCRIPTABLE void phase2Done(); > +Q_SIGNALS: > public: It looks like there are no more signals anymore. Do

D16587: [ksmserver] Simplify call to kcminit

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY kcminit had a slot to start processing something and a signal to emit when