D16628: [ksmserver] Remove blocking call introspecting KDED

2018-11-02 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY We don't need to introspect at runtime as KDED installs the interface XML f

Re: KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 69 - Still Failing!

2018-11-02 Thread Ben Cooksley
Hi Marco & Plasma Folks, Can someone please look into this? This seems to be the usual class of QTest compilation failures due to changes in how it handles casts between 5.9 / 5.10. Cheers, Ben On Sat, Nov 3, 2018 at 5:06 PM CI System wrote: > *BUILD FAILURE* > Build URL > https://build.kde.or

D16622: [Plasmoid] Clean up layout

2018-11-02 Thread Nathaniel Graham
ngraham updated this revision to Diff 44750. ngraham added a comment. Fix separator line placement when it's on a bottom panel (i.e. reversed) REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16622?vs=44738&id=44750 BRANCH better-layout (branched from master

D16622: [Plasmoid] Clean up layout

2018-11-02 Thread Kai Uwe Broulik
broulik added a comment. I was a bit concerned at first that you jumped the gun for that but I admit I like that better than I thought I would. +1 from me (when you're at it, can yo fix the separator lines for when it's in a bottom panel? :P) REPOSITORY R112 Milou REVISION DETAIL h

D16622: [Plasmoid] Clean up layout

2018-11-02 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Plasma, broulik, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch cleans up the Search plasmoid's layout to essentially match that of KRunn

D16621: [kstyle] Calculate correct size of scaled shadow pixmap

2018-11-02 Thread Vlad Zagorodniy
zzag reclaimed this revision. zzag added a comment. Hmm, it looks like TileSet chops the shadow pixmap incorrectly. (the rendered pixmap is correct) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D16621 To: zzag, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesl

D16621: [kstyle] Calculate correct size of scaled shadow pixmap

2018-11-02 Thread Vlad Zagorodniy
zzag abandoned this revision. zzag added a comment. Meh, there are more cases when we have to round. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D16621 To: zzag, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, seb

D16621: [kstyle] Calculate correct size of scaled shadow pixmap

2018-11-02 Thread Vlad Zagorodniy
zzag added a comment. F6387164: Screenshot_20181102_234002.png F6387166: Screenshot_20181102_233931.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D16621 To: zzag, #plasma Cc: plas

D16621: [kstyle] Calculate correct size of scaled shadow pixmap

2018-11-02 Thread Vlad Zagorodniy
zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY This change slightly improves how widget style shadows look with fractional scaling. TEST PLAN There a

D16615: Set appropriate icon for plasmoid

2018-11-02 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R115:125c716889b9: Set appropriate icon for plasmoid (authored by broulik). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16615?vs=44720&id=44729 RE

D16615: Set appropriate icon for plasmoid

2018-11-02 Thread Nathaniel Graham
ngraham added a comment. Wanna hit https://bugs.kde.org/show_bug.cgi?id=400587 too? Is the the same issue, just for plasma-nm. That way I can credit them both to you in this sunday's U&P blog post. :) REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org

D16615: Set appropriate icon for plasmoid

2018-11-02 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Widget explorer automatically uses the "preview" icon based on the plasmoid's name, so us

Downtime announcement: www.kde.org

2018-11-02 Thread Ben Cooksley
Hi all, In order to allow for hardware maintenance, one of our physical hardware hosts will need to be shutdown for a few hours on Monday. This downtime will commence around 9:30am UTC and may take several hours. During this time a number of sites will be inaccessible, including: - www.kde.org -

D16277: [ksmserver] Split xsession logout and shutdown into separate classes

2018-11-02 Thread David Edmundson
davidedmundson added a comment. Phab shows it weird. Logout and shutdown are copies of a single file. One has one half removed the other has the other half removed. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16277 To: davidedmundson, #plasma, apol

D16277: [ksmserver] Split xsession logout and shutdown into separate classes

2018-11-02 Thread Roman Gilg
romangg added a comment. Stupid question, but is there a file missing? Because so much code is being removed. INLINE COMMENTS > shutdown.cpp:1 > -/* > -ksmserver - the KDE session management server > +#include "shutdown.h" > +#i

D16611: Fix build with libc++

2018-11-02 Thread Kirill Tatunov
ktatunov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ktatunov requested review of this revision. REVISION SUMMARY The build breaks with clang & libc++ because apparently libc++ doesn't transitively include so to use EPERM we need to add it ex

[kio-extras] [Bug 363593] In dolphin-16.04.1-1.fc25.x86_64, Unknown error code 150 when copying from phone to computer

2018-11-02 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=363593 Elvis Angelaccio changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|---