D16082: Notify headphone being plugged in on some hardware

ngraham added a comment. But you can plug speakers into the headphone jack on a laptop. They can use the same 1/16 minijack as actual headphones. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D16082 To: thsurrel, #plasma, #vdg, drosca Cc: ngraham

D15093: Add WireGuard capability.

andersonbruce added a comment. In D15093#354899 , @jgrulich wrote: > I still don't like the way how to get QPalette in the advanced dialog, can you please just simply construct it the same way you do it in the standard dialog? Fair enoug

D15093: Add WireGuard capability.

andersonbruce updated this revision to Diff 45001. andersonbruce marked an inline comment as done. andersonbruce added a comment. - Allocate palettes in advanced widget rather than passing them from main interface REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D16715: make global menu minimize state aware

mvourlakos updated this revision to Diff 44998. mvourlakos added a comment. - use null in qml side REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16715?vs=44987&id=44998 BRANCH appMenuMinimize REVISION DETAIL https://phabricator.kde.org/D1671

D16715: make global menu minimize state aware

apol added inline comments. INLINE COMMENTS > main.qml:107 > id: buttonRepeater > -model: appMenuModel > +model: !appMenuModel.menuHidden ? appMenuModel : 0 > use `null` REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D167

D16711: Make sure m_labelMode is initialised

This revision was automatically updated to reflect the committed changes. Closed by commit R119:98d38f9ffb60: Make sure m_labelMode is initialised (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16711?vs=44971&id=44996#toc REPOSITORY R119 Plasma Desktop CHANGES SINC

D16722: Some clazy fixes

aacid created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY Q_ENUMS -> Q_ENUM Give context to the timer single shot call REPOSITORY R994 Pulseaudio Qt Bindings BRANCH master REVISION DETA

D16082: Notify headphone being plugged in on some hardware

broulik added a comment. I //think// it can tell the difference between regular speaker jacks on the back of a desktop computer and the headphone port on a laptop. Not sure, though, might be a good idea to test that. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://pha

D16711: Make sure m_labelMode is initialised

hein accepted this revision. hein added a comment. Patch is fine, but codingstyle-wise I usually do it in the constructor in the .cpp. I'd be a nice gesture if you move it before you push, but otherwise all cool. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://ph

D16082: Notify headphone being plugged in on some hardware

ngraham added a comment. Does this have the potential to inappropriately show a headphones OSD when you plug in speakers, or vice versa? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D16082 To: thsurrel, #plasma, #vdg, drosca Cc: ngraham, broulik

D16082: Notify headphone being plugged in on some hardware

broulik added a comment. Seems to work well here. But I'll leave it to @drosca or @nicolasfella to decide. Sorry for the long wait time :/ REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D16082 To: thsurrel, #plasma, #vdg, drosca Cc: broulik, nicol

D16082: Notify headphone being plugged in on some hardware

thsurrel marked 5 inline comments as done. thsurrel added a comment. Ping ! Anybody else managed to test this ? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D16082 To: thsurrel, #plasma, #vdg, drosca Cc: broulik, nicolasfella, plasma-devel, rag

D16697: [Kickoff] Fix context menu not appearing on right-click

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9b25a95c2191: [Kickoff] Fix context menu not appearing on right-click (authored by broulik, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.

D16715: make global menu minimize state aware

mvourlakos updated this revision to Diff 44987. mvourlakos added a comment. - remove whitespace REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16715?vs=44985&id=44987 BRANCH appMenuMinimize REVISION DETAIL https://phabricator.kde.org/D16715

D16715: make global menu minimize state aware

mvourlakos updated this revision to Diff 44985. mvourlakos added a comment. - fix naming and improve code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16715?vs=44978&id=44985 BRANCH appMenuMinimize REVISION DETAIL https://phabricator.kde.or

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

filipf added a comment. But it seems to me like Nate's addressed or is addressing all the pitfalls regarding usability. The icons will have more contrast in a newer revision and from what I've seen in that diff there's an idea of adding a rectangle at the bottom to make the text there nicely

D16715: make global menu minimize state aware

anthonyfieroni added inline comments. INLINE COMMENTS > appmenumodel.cpp:245-248 > +if (info.isMinimized()) { > +setMenuIsHidden(true); > +} else { > +setMenuIsHidden(false); setMenuHidden(info.isMinimized()); > appmenumodel.h:42 > Q_PROPERTY(bool me

D16715: make global menu minimize state aware

mvourlakos created this revision. mvourlakos added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mvourlakos requested review of this revision. REVISION SUMMARY --a new menuIsHidden property is added in the AppMenuModel in order to inform m

Plasma 5.14.3

Plasma 5.14.3 is now released https://www.kde.org/announcements/plasma-5.14.3.php

D16530: Drop X11 core fonts code from startkde/startplasma

fvogt added a comment. Looks good to me, but I don't know enough about old X11 stuff like this to accept it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16530 To: bruns, #plasma, fvogt, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezha

D16530: Drop X11 core fonts code from startkde/startplasma

bruns added a comment. Friendly reminder ... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16530 To: bruns, #plasma, fvogt, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16711: Make sure m_labelMode is initialised

apol created this revision. apol added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Fixes uninitialised warning on valgrind REPOSITORY R119 Plasma Desktop BRANCH master REVISION D

D15093: Add WireGuard capability.

jgrulich added a comment. I still don't like the way how to get QPalette in the advanced dialog, can you please just simply construct it the same way you do it in the standard dialog? Other than that it looks good and I think it's ready to go. Those mentioned coding style can be fixed later,

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.11 - Build # 8 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.11/8/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Tue, 06 Nov 2018 10:26:05 + Build duration: 40 min and counting CONSOLE OUTPUT [...trunca

KDE CI: Plasma » systemsettings » stable-kf5-qt5 FreeBSDQt5.11 - Build # 12 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20FreeBSDQt5.11/12/ Project: stable-kf5-qt5 FreeBSDQt5.11 Date of build: Tue, 06 Nov 2018 10:26:19 + Build duration: 12 min and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.11 - Build # 11 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.11/11/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Tue, 06 Nov 2018 10:22:53 + Build duration: 6 min 37 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.11 - Build # 9 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.11/9/ Project: stable-kf5-qt5 FreeBSDQt5.11 Date of build: Tue, 06 Nov 2018 10:22:53 + Build duration: 2 min 5 sec and counting CONSOLE OUTPUT

D12997: Add new api to support window tabs

graesslin added a comment. In D12997#354190 , @zzag wrote: > Ping? The code doesn't work yet, the API is still lacking some functionality REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D12997 T

D16425: Added new Suspend then Hibernate option

avaldes updated this revision to Diff 44950. avaldes added a comment. I have changed the message. Also, if anyone can help me, I'm having a segmentation fault with these changes when an application inhibits power saving. This does happen with or without having available hibernation in th