D16530: Drop X11 core fonts code from startkde/startplasma

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5374513266ee: Drop X11 core fonts code from startkde/startplasma (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16530?vs=44499=45152

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham added a comment. OK, will do! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16031 To: ngraham, #vdg, #plasma, rizzitello, davidedmundson Cc: romangg, davidedmundson, rizzitello, abetts, pstefan, broulik, rikmills, filipf, rooty, plasma-devel,

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Why are there hardcoded colours? If the font is black then surely the outline needs to be white? There's two parts to this patch: - Improving

D16771: Fix warning

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Now if appIcon isn't defined, it will set the property as undefined.

D16530: Drop X11 core fonts code from startkde/startplasma

davidedmundson added a comment. It's always tricky when you remove old stuff; we don't want to risk any changes that could affect a usecase no matter how obscure. It's not something to rush or do lightly. However, your rationale makes sense. There's an additional pieces of information

D16715: make global menu minimize state aware

mvourlakos updated this revision to Diff 45141. mvourlakos added a comment. - mage global menu screen aware REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16715?vs=44998=45141 BRANCH appMenuScreen REVISION DETAIL

D16768: mage global menu screen aware

mvourlakos created this revision. mvourlakos added reviewers: Plasma, broulik. mvourlakos added a project: Plasma. mvourlakos requested review of this revision. REVISION SUMMARY --a new screenGeometry property is added in the AppMenuModel in order to be used for filtering windows based on

D16715: make global menu minimize state aware

mvourlakos updated this revision to Diff 45142. mvourlakos added a comment. fix REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16715?vs=45141=45142 BRANCH appMenuMinimize REVISION DETAIL https://phabricator.kde.org/D16715 AFFECTED FILES

D16404: [Bookmarks Runner] Cleanup tests CMakeList

bruns added a comment. Anyone? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16404 To: bruns, #frameworks Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16530: Drop X11 core fonts code from startkde/startplasma

bruns added a comment. In D16530#355078 , @fvogt wrote: > Looks good to me, but I don't know enough about old X11 stuff like this to accept it. @fvogt - maybe you can poke a coworker? Someone else? REPOSITORY R120 Plasma

D16170: [Device Notifier] Restore busy indicator

thsurrel added a comment. It is awaiting a review. As I said in an older comment, I don't know if there are some drawbacks to not do polling, but i have been using this patch for a while and it works well. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D16170: [Device Notifier] Restore busy indicator

cfeck added a comment. What is the status of this patch? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16170 To: thsurrel, #plasma, #vdg, broulik, bruns Cc: cfeck, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D16750: Various grammar and capitalization fixes for UI consistency

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > appmenu.desktop:3 > Type=Service > -Name=Application menus daemon > +Name=Application Menu Daemon > Name[ar]=عفريت قوائم التطبيقات While we're touching

D16750: Various grammar and capitalization fixes for UI consistency

ltoscano added a comment. I can't check the change against the guidelines right now, but please change only the original strings. Any translation (including en_GB and x-test) is handled elsewhere and it will be overwritten. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D16628: [ksmserver] Remove blocking call introspecting KDED

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c8ed48fc1a2a: [ksmserver] Remove blocking call introspecting KDED (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D16657: [kioslave/desktop] Remove more QDBusInterface

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c29d2528c184: [kioslave/desktop] Remove more QDBusInterface (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D16277: [ksmserver] Split xsession logout and shutdown into separate classes

This revision was automatically updated to reflect the committed changes. Closed by commit R120:008d58cfc60d: [ksmserver] Split xsession logout and shutdown into separate classes (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D16082: Notify headphone being plugged in on some hardware

drosca added a comment. In D16082#356111 , @thsurrel wrote: > So now the question is whether it is acceptable to show a headphone on the OSD when we could have been plugging something else in the jack. It will already show in device list

D16082: Notify headphone being plugged in on some hardware

thsurrel added a comment. In D16082#356109 , @drosca wrote: > What do you mean with "sink change"? Do you mean that plugging in something in jack will trigger adding new sink (device) to Pulseaudio? That will only be the case for USB

D16082: Notify headphone being plugged in on some hardware

drosca added a comment. In D16082#356099 , @thsurrel wrote: > So, it seems that pulseaudio can not tell the difference what we are plugging in the jack connector on a laptop, but I guess it must be the same behavior with computers that get a

D16082: Notify headphone being plugged in on some hardware

thsurrel added a comment. So, it seems that pulseaudio can not tell the difference what we are plugging in the jack connector on a laptop, but I guess it must be the same behavior with computers that get a sink change when switching from internal speaker to external ? REPOSITORY R115

D16750: Various grammar and capitalization fixes for UI consistency

snoordhuis created this revision. snoordhuis added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. snoordhuis requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D16750