D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

2018-11-16 Thread Root
rooty added a comment. > FWIW make sure to test your changes with all four possible orientations. I actually figured out how to do that just before my latest edit, my bad. It seems to work sort of fine with the tabs on the left or the right, except for the lower separator (to the left/ri

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

2018-11-16 Thread Filip Fila
filipf added a comment. I didn't comment on the original patch, but I'd like to pitch in here. There are two issues/points of improvement for the original patch: 1. The width of the separators does not correspond to any meaningful UI element -> they're almost drawn from edge to edge, but

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

2018-11-16 Thread Root
rooty added a comment. In D16937#360667 , @ngraham wrote: > But now when the tab bar is on the top or bottom, the separators will have different widths, which doesn't look good. To be honest, I'm not sure what the actual problem is here.

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

2018-11-16 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. But now when the tab bar is on the top or bottom, the separators will have different widths, which doesn't look good. To be honest, I'm not sure what the actual problem is here.

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

2018-11-16 Thread Root
rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY Leaner separators in Kickoff (lowered opacity, narrower/shorter) REPOSITORY R119 Plasma Desktop BRANCH kickoff-leaner-separators (

Plasma Accessibility: Kickoff Application starter and Focus handling

2018-11-16 Thread chrys
Howdy Plasma List, My name is chrys and I m very new here. I currently started with Frederik (my mentor) some work on Plasma Accessibility. We try to bring an Accessibility team back on rail and try improve the situation here. We already make some progress here and continue our work in that ar

D16595: Fix i18n when the kcm code is embedded in the plasmoid config

2018-11-16 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Sure, lets get this into stable till a magic fix comes along REPOSITORY R115 Plasma Audio Volume Applet BRANCH Plasma/5.14 REVISION DETAIL https://phabricator.kde.org

D16897: Allow windows to be closed from the window switchers

2018-11-16 Thread Martin Flöser
graesslin added a comment. In D16897#359912 , @ngraham wrote: > In D16897#359911 , @graesslin wrote: > > > In D16897#359900 , @ngraham wrote: > > > > >

D2393: Don't check current active session at all

2018-11-16 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Marking as request changes based on Kai's comment which has gone unanswered. Also you've explained what the patch is doing, but not really what the reason for

D16900: Don't use an icon that is only supposed for plasmoids

2018-11-16 Thread Aleix Pol Gonzalez
apol closed this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D16900 To: apol, andreask, sitter, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D2754: Touchpad KDED: fix metadata warning

2018-11-16 Thread David Edmundson
davidedmundson commandeered this revision. davidedmundson edited reviewers, added: knambiar; removed: davidedmundson. davidedmundson added a comment. This was merged at some point Closing the RR. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2754 To: david

D2975: [shell] Event compress resizePanel

2018-11-16 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Marking as request changes to remove from queue pending reply to Kai's question REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D

[Powerdevil] [Bug 360162] Segfault at startup (just after login)

2018-11-16 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=360162 --- Comment #4 from Bug Janitor Service --- Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular b

D16918: [brightnesscontrol] Do not change screen brightness on invalid values

2018-11-16 Thread Anthony Fieroni
anthonyfieroni created this revision. anthonyfieroni added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY The problem: 1. Unplug laptop power supply 2. On screen energy

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-11-16 Thread Eike Hein
hein added a comment. @ngraham Let's progress this, do you want @phuongn to change the patch? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14988 To: phuongn, #plasma, #vdg, davidedmundson Cc: hein, zzag, ngraham, abetts, davidedmundson, broulik, plasma-deve