Re: Conceptual changes to KScreen

On November 24, 2018 at 12:43:00 PM, Nate Graham (n...@kde.org) wrote: > [CCing visual-des...@kde.org] > > Hi Roman, > Could you summarize for less technical people like me what the > user-facing impact of this change would be? How would this change the > experience of managing external

D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling

ngraham added a comment. In D17143#365585 , @fvogt wrote: > I agree, but I think it's more effective to fix this at the source in kirigami and ask distros to patch frameworks (which aren't LTS, so they're either updating versions or doing

D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling

fvogt added a comment. > Yeah, I had a feeling that that might end up as a better place for the fix. Someone else would need to do that patch or help me with it though. I gave it a shot but couldn't get the binding right. It might be that in those cases Kirigami doesn't create the

D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling

ngraham added a comment. Yeah, I had a feeling that that might end up as a better place for the fix. Someone else would need to do that patch or help me with it though. I gave it a shot but couldn't get the binding right. Regardless, it might be nice to also land this on the stable

D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling

fvogt added a comment. IMO this workaround is generic enough that adding it into `ScrollablePage.qml` or even `templates/private/ScrollView.qml` itself is better as it hits almost every use. It would be nice to have a minimal reproducer to allow creating a QTBUG, but I haven't been

D17127: [Device Notifier] Keep the device label & icon after unmounting

filipf added a comment. I tested both the old and new code and it seemed same to me, it would probably take more attempts to trigger the bug you described. But for what it's worth the new code didn't cause any issues that I could notice. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D16968: [Folder View] improve label contrast against challenging backgrounds

abetts added a comment. Looking good guys! +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16968 To: ngraham, #plasma, hein, #vdg Cc: abetts, svenmauch, matheusm, filipf, emateli, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling

ngraham added a subscriber: mart. ngraham added a comment. @mart An alternative to this patch would be to fix https://bugs.kde.org/show_bug.cgi?id=401174 at the Kirigami level. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D17143 To: ngraham, #plasma,

D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling

ngraham created this revision. ngraham added reviewers: Plasma, Kirigami. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY By pixel-aligning the flickables, we eliminate text clipping artifacts caused by

D17127: [Device Notifier] Keep the device label & icon after unmounting

thsurrel updated this revision to Diff 46160. thsurrel added a comment. Fix REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17127?vs=46094=46160 BRANCH arc_notifier_labels (branched from master) REVISION DETAIL

D16968: [Folder View] improve label contrast against challenging backgrounds

ngraham added a comment. Ah never mind, I see it now. Still, that's not connected to this patch, so let's try to keep the conversation on-topic. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16968 To: ngraham, #plasma, hein, #vdg Cc: svenmauch,

Re: Conceptual changes to KScreen

[CCing visual-des...@kde.org] Hi Roman, Could you summarize for less technical people like me what the user-facing impact of this change would be? How would this change the experience of managing external screens for laptop users? Etc. Nate On 11/19/18 3:11 AM, Roman Gilg wrote: Hi all,

D16968: [Folder View] improve label contrast against challenging backgrounds

ngraham added a comment. Can't reproduce with Neon dev unstable / everything from git master. Then again I don't really see the problem in those screenshot in the first place. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16968 To: ngraham, #plasma, hein,

D16968: [Folder View] improve label contrast against challenging backgrounds

filipf added a comment. ^ Sorry to digress, but an update: bug does not happen if icons are in rows at the top (when the panel is at the bottom). We probably have bug with how the folder view widget adjusts the dimensions of its elements when it encounters panels or some other elements it

D16968: [Folder View] improve label contrast against challenging backgrounds

filipf added a comment. I've been testing this solution some more and I think I'm running into either a QML (using Qt 5.11.2) or widget bug, can someone else test to make sure it's not just my setup? Basically the text and the shadows can look hazy and unsharpened at times. The easiest

D16968: [Folder View] improve label contrast against challenging backgrounds

svenmauch added a comment. Looks great! Not having to avoid certain wallpapers is a big win for usability. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16968 To: ngraham, #plasma, hein, #vdg Cc: svenmauch, matheusm, filipf, emateli, mart, plasma-devel,

D16968: [Folder View] improve label contrast against challenging backgrounds

matheusm added a comment. Much better now! +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16968 To: ngraham, #plasma, hein, #vdg Cc: matheusm, filipf, emateli, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D16968: [Folder View] improve label contrast against challenging backgrounds

ngraham added a comment. Thanks! I like this too. Let's see if #VDG and/or #plasma folks agree. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16968 To: ngraham, #plasma,

D16968: [Folder View] improve label contrast against challenging backgrounds

filipf added a comment. Looks great to me with your values! The shadows don't draw much attention and the labels are finally not wimpy looking in certain situations. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16968 To: ngraham, #plasma, hein, #vdg Cc:

D17105: Add a new lookandfeel runner

ngraham added a comment. Hmm, I'm not sure how I feel about this. Seems like this could make it easy to accidentally change your LNF by accident. Changing LNF packages is in some sense a destructive since there's no easy way to undo it and go back to your previous panel-and-widget setup.

D17094: Fixed comic widget context menu crash

ngraham added a reviewer: anthonyfieroni. ngraham added a comment. @anthonyfieroni, if this looks good to you now, would you mind landing it for Pavel? Thanks! His authorship information is `Pavel Mars ` REVISION DETAIL https://phabricator.kde.org/D17094 To: pavelmos, jriddell,

D16968: [Folder View] improve label contrast against challenging backgrounds

ngraham updated this revision to Diff 46123. ngraham added a comment. Use a much tighter shadow that kind of looks like a tasteful outline REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16968?vs=46099=46123 BRANCH arcpatch-D16968 REVISION DETAIL

D16968: [Folder View] improve label contrast against challenging backgrounds

ngraham added a comment. Hey, that looks pretty darn good! I'll tweak the values a bit (just a bit) from what you suggested and rejigger this patch to use them. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16968 To: ngraham, #plasma, hein, #vdg Cc:

D16968: [Folder View] improve label contrast against challenging backgrounds

filipf added a comment. Ultimately if the blurriness can be resolved I'd recommend: horizontalOffset: 1 verticalOffset: 1 radius: 3 samples: 7 spread: 0.3 Before: F6439397: Screenshot_20181124_144817a.png After: F6439399:

D16968: [Folder View] improve label contrast against challenging backgrounds

filipf added a comment. Here's my rough estimation of what Windows does, although maybe a bit more subtly: horizontalOffset: 1 verticalOffset: 1 radius: 4 samples: 9 spread: 0.5 Before: F6439380: Screenshot_20181124_142255.png

D16968: [Folder View] improve label contrast against challenging backgrounds

filipf added a comment. The icon labels should be visible enough with pretty much any wallpaper used. Historically in other systems there's been some cheating involved by having default wallpapers deliberately be darker on the left side, but you'd think we could come up with something

D17079: Provide a qqc2/kirigami-based about page

vkrause added a comment. In D17079#364308 , @mart wrote: > In D17079#364263 , @apol wrote: > > > In D17079#364163 , @ltoscano wrote: > > > > >

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps

This revision was automatically updated to reflect the committed changes. Closed by commit R858:1e02355c1786: Support for QGuiApplication-based apps (authored by rjvbb). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14000?vs=44083=46108#toc REPOSITORY R858 Qt Quick Controls 2: