D16988: [Kickoff] Make the visible search field unfocused by default

2018-11-25 Thread Nathaniel Graham
ngraham added a comment. D17020 , D17022 , and D17023 still include duplicated changes from this patch. The idea was to make all of your Kickoff patches independent of each

D17154: Go back to SCSS

2018-11-25 Thread Nathaniel Graham
ngraham added subscribers: jackg, ngraham. ngraham added reviewers: Plasma, jackg, Breeze. ngraham added a comment. @jackg, if you're around, I'd really appreciate your perspective on this patch. I'm not sure about the history regarding why we moved away from this approach, whether or not

D17095: Fixed comic widget crash

2018-11-25 Thread Nathaniel Graham
ngraham added a comment. @anthonyfieroni these last few patches of Pavel's were landed with your authorship information, not his. In the future let's follow https://community.kde.org/Infrastructure/Phabricator#Landing_someone_else.27s_diff Thanks! REPOSITORY R114 Plasma Addons

D16890: [systemtray] Keep config entries after modifying

2018-11-25 Thread Anthony Fieroni
anthonyfieroni added a subscriber: mart. anthonyfieroni added a comment. To commit it @mart @broulik ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16890 To: anthonyfieroni, #plasma, broulik, davidedmundson, ngraham Cc: mart, ngraham, broulik,

D17152: Hide the badge if number too big

2018-11-25 Thread Nathaniel Graham
ngraham added a comment. In D17152#365985 , @svuorela wrote: > I have a couple of hundred thousand unread emails + the emails in my spamfolder which is another hundred thousand. Having such an indicator in this case is just .. useless.

D17152: Hide the badge if number too big

2018-11-25 Thread Sune Vuorela
svuorela added a comment. @ngraham It might be that many notifications != no notifications in some cases, but at least in the case of emails, with many unread emails basically doesn't make a difference. I have a coulpe of hundred thousand unread emails + the emails in my spamfolder

D17152: Hide the badge if number too big

2018-11-25 Thread Noah Davis
ndavis added a comment. Why not abbreviate the number and round the abbreviated number instead? Instead of using "9,999+" for 11000, use "11K". REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17152 To: svuorela, #plasma, hein, broulik, #vdg, ngraham Cc:

D17006: Compress calls to `updateSize`

2018-11-25 Thread Victor Ryzhykh
victorr added a comment. F6441215: group.jpeg Now the group looks like this. After clicking on it, the plasmashell falls. You can check it on unstable KDE https://files.kde.org/neon/images/neon-devedition-gitunstable/current/ after updating from

D16873: [comic] Request current identifier on date changed

2018-11-25 Thread Anthony Fieroni
anthonyfieroni updated this revision to Diff 46207. anthonyfieroni added a reviewer: mart. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16873?vs=45444=46207 REVISION DETAIL https://phabricator.kde.org/D16873 AFFECTED FILES applets/comic/comic.cpp

D16856: [comic] Sync configuration on write

2018-11-25 Thread Anthony Fieroni
anthonyfieroni updated this revision to Diff 46206. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16856?vs=45556=46206 REVISION DETAIL https://phabricator.kde.org/D16856 AFFECTED FILES applets/comic/comicupdater.cpp To: anthonyfieroni, #plasma,

D17152: Hide the badge if number too big

2018-11-25 Thread Nathaniel Graham
ngraham added a comment. Or an infinity symbol?  REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17152 To: svuorela, #plasma, hein, broulik, #vdg, ngraham Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D16844: [comic] Correct usage of DataEngineConsumer

2018-11-25 Thread Anthony Fieroni
This revision was automatically updated to reflect the committed changes. Closed by commit R114:0f79d76cf932: [comic] Correct usage of DataEngineConsumer (authored by anthonyfieroni). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16844?vs=45370=46205

D17095: Fixed comic widget crash

2018-11-25 Thread Anthony Fieroni
This revision was automatically updated to reflect the committed changes. Closed by commit R114:5b412f94ff39: [comic] Fix error handling in data updated (authored by anthonyfieroni). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17095?vs=45996=46204

D17094: Fixed comic widget context menu crash

2018-11-25 Thread Anthony Fieroni
This revision was automatically updated to reflect the committed changes. Closed by commit R114:ce5bc062fe15: [comic] Fix widget context menu (authored by anthonyfieroni). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17094?vs=46064=46203#toc REPOSITORY R114 Plasma Addons CHANGES

D17152: Hide the badge if number too big

2018-11-25 Thread Kai Uwe Broulik
broulik added a comment. Maybe just show an asterisk instead? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17152 To: svuorela, #plasma, hein, broulik, #vdg, ngraham Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D16856: [comic] Sync configuration on write

2018-11-25 Thread Anthony Fieroni
anthonyfieroni added a comment. It's mostly one per day or accept configuration. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D16856 To: anthonyfieroni, #plasma, davidedmundson Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D17152: Hide the badge if number too big

2018-11-25 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Hmm, I get that "+" may not be useful, but not showing any badge at all is misleading; too many notifications != no notifications at all. Maybe we could come up with a

D17154: Go back to SCSS

2018-11-25 Thread Alexander Kernozhitsky
gepardo created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gepardo requested review of this revision. REVISION SUMMARY As it was explained in https://phabricator.kde.org/D16365, > Further potential steps in the same direction of saving code

D16990: [kded] Change configuration storage path

2018-11-25 Thread Roman Gilg
romangg added a comment. Is it fine if we keep the files in the current directory and just add the additional directories `outputs` and `control` in later patches. The hash values should never coincide with these names. So it might be ugly, but work without problems. Moving the

D17007: Do hash and hex name based output hashes

2018-11-25 Thread Roman Gilg
romangg added a comment. In D17007#364724 , @mart wrote: > could a kconfigupdate script be provided to migrate config? > screwing up multiscreen config between updated is quite of an issue Difficult, maybe mathematically not even

D16997: [kcm] Expose interface to control output property retention

2018-11-25 Thread Roman Gilg
romangg added a comment. In D16997#361978 , @ngraham wrote: > I'll admit just looking at the new UI, it's not entirely clear what either of the options do. Can you help me understand? Thanks Roman! I replied to your mail to the

Re: Conceptual changes to KScreen

2018-11-25 Thread Roman Gilg
On Sat, Nov 24, 2018 at 8:42 PM Nate Graham wrote: > [CCing visual-des...@kde.org] > > Hi Roman, > Could you summarize for less technical people like me what the > user-facing impact of this change would be? How would this change the > experience of managing external screens for laptop users?

D17152: Hide the badge if number too big

2018-11-25 Thread Sune Vuorela
svuorela created this revision. svuorela added reviewers: Plasma, hein, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. svuorela requested review of this revision. REVISION SUMMARY A + badge on the email conveys no actual information that the user isn't

D14428: Define ownership of edid in output and do not leak it

2018-11-25 Thread Frederik Gladhorn
This revision was automatically updated to reflect the committed changes. Closed by commit R110:e6b197b47b8a: Define ownership of edid in output and do not leak it (authored by gladhorn). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14428?vs=38600=46182#toc REPOSITORY R110 KScreen