KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.11 - Build # 88 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.11/88/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Tue, 27 Nov 2018 06:37:41 + Build duration: 1 min 19 sec and counting

D15684: DateTime Runner timezone and 24 hour clock time conversion.

smithjd updated this revision to Diff 46297. smithjd added a comment. Rebase around multiple zone matching, and some improvements. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15684?vs=43091&id=46297 BRANCH master-timeconverter (branched from mas

D17181: [Componentchooser KCM] Make default browser app choice work even when combobox is not used

This revision was automatically updated to reflect the committed changes. Closed by commit R119:26fb5ec20af6: [Componentchooser KCM] Make default browser app choice work even when combobox… (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kd

D17181: [Componentchooser KCM] Make default browser app choice work even when combobox is not used

ngraham updated this revision to Diff 46295. ngraham added a comment. Don't need to `emit` (everything still works) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17181?vs=46294&id=46295 BRANCH fix-default-browser-app-combobox (branched from Plasm

D17073: Do not crop albumArt

filipf added a comment. Great patch and good thinking concerning removing an extra label. I'd remove the upper one (and then we can move the "on" desktop 1" text up) because I think the bigger one is nicer. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1707

D4929: DrKonqi : lldb and Mac support

davidedmundson added inline comments. INLINE COMMENTS > rjvbb wrote in lldbrc:7 > Yes, that file is used when the user asks to attach a debugger to the crashed > process. We shouldn't presume that s/he has Konsole installed, nor that it is > installed with a wrapper script on the path. So we in

D17181: [Componentchooser KCM] Make default browser app choice work even when combobox is not used

davidedmundson added inline comments. INLINE COMMENTS > ngraham wrote in componentchooserbrowser.cpp:49 > What should it be instead? That line is just copy-pasted from the original > inline function. just "configChanged();" as it's a method not a signal. REPOSITORY R119 Plasma Desktop BRAN

D17181: [Componentchooser KCM] Make default browser app choice work even when combobox is not used

ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in componentchooserbrowser.cpp:49 > this "emit" looks wrong What should it be instead? That line is just copy-pasted from the original inline function. REPOSITORY R119 Plasma Desktop BRANCH fix-default-browser-app-combo

D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling

filipf added a comment. > [Ignore the flickering in the video; I'm not sure why that happens but it's an artifact of the software (SimpleScreenRecorder), not something that actually happens] Don't know anything about flickables, but maybe I can help with this. Screen recorders can flick

D17181: [Componentchooser KCM] Make default browser app choice work even when combobox is not used

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > componentchooserbrowser.cpp:49 > +m_browserExec.clear(); > +emit configChanged(); > +} this "emit" looks wrong REPOSITORY R119 Plasma Desktop

D17181: [Componentchooser KCM] Make default browser app choice work even when combobox is not used

ngraham created this revision. ngraham added reviewers: Plasma, cfeck. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 350663 FIXED-IN: 5.12.8 When choosing a default browser app using the app list c

D4929: DrKonqi : lldb and Mac support

patrickelectric added a comment. @rjvbb I got it to work here ! Took some time to figure out the problems with relative paths and KConfig, I am working to bundle kcrash in a .dmg :) REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D4929 To: rjvbb, #plasma_workspaces,

D17073: Do not crop albumArt

abetts added a comment. In D17073#366588 , @ngraham wrote: > Staring at these screenshots again, it occurs to me that the artist and title are unnecessarily repeated in the current UI: once right under the app name, and again towards the bottom,

D17073: Do not crop albumArt

ngraham added a comment. Staring at these screenshots again, it occurs to me that the artist and title are unnecessarily repeated in the current UI: once right under the app name, and again towards the bottom, on the transparent bar. We can probably get rid of one of these to scrounge up som

D17152: Hide the badge if number too big

svuorela added a subscriber: mlaurent. svuorela added a comment. Let's try poke @mlaurent and see if he has any comments. I still think it is mostly a visualization issue. the mail client just tells what it knows. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kd

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.11 - Build # 87 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.11/87/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Mon, 26 Nov 2018 20:29:39 + Build duration: 2 min 2 sec and counting CONSOLE OUTPUT [...truncated

D17152: Hide the badge if number too big

ngraham added a comment. FWIW after talking to some KMail developers in the #plasma IRC channel, we came up with a few bug reports that might help you: - https://bugs.kde.org/show_bug.cgi?id=401443 - https://bugs.kde.org/show_bug.cgi?id=401444

D17152: Hide the badge if number too big

ngraham added a comment. I did. My proposal is something a bit different: an option to have KMail only look at the inbox for the purpose of determining the unread count to report to Plasma. I do see how this would be only marginally useful for you if you have 5,000 unread emails in your inbo

D17152: Hide the badge if number too big

svuorela added a comment. In D17152#366536 , @ngraham wrote: > What I'm saying is that I think it makes more sense to communicate your preferred email workflow to KMail rather then to Plasma. I'm open to being convinced out of this point of view

D17152: Hide the badge if number too big

ngraham added a comment. In D17152#366535 , @svuorela wrote: > In D17152#366525 , @ngraham wrote: > > > > > > > > > I feel like this patch trying to work around a problem in either your wo

D17152: Hide the badge if number too big

svuorela added a comment. In D17152#366525 , @ngraham wrote: > > I feel like this patch trying to work around a problem in either your workflow Is plasma seriously going to try to dictate my email workflow? > Maybe 1000 wo

D17152: Hide the badge if number too big

ngraham added a comment. In D17152#366524 , @svuorela wrote: > In D17152#366495 , @anthonyfieroni wrote: > > > So i like second one, it can still be fixed to 10K+ because it does not matter above.

D17152: Hide the badge if number too big

svuorela added a comment. In D17152#366495 , @anthonyfieroni wrote: > So i like second one, it can still be fixed to 10K+ because it does not matter above. I'm still unsure what I as a user should use the number for ? It is not like I'm

D17177: Drop tab-based UI for the about page

ngraham added a comment. Looks much better visually! But something about the bugDisplay looks wrong. Right now it's recommending that people send bugs via email. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17177 To: apol, #plasma, #vdg Cc: ngraha

D17152: Hide the badge if number too big

anthonyfieroni added a comment. So i like second one, it can still be fixed to 10K+ because it does not matter above. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17152 To: svuorela, #plasma, hein, broulik, #vdg, ngraham Cc: anthonyfieroni, fabianr, ndavis

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.11 - Build # 77 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.11/77/ Project: kf5-qt5 SUSEQt5.11 Date of build: Mon, 26 Nov 2018 17:54:31 + Build duration: 1 min 27 sec and counting CONSOLE OUTPUT [...truncated 229.2

D17152: Hide the badge if number too big

svuorela added a comment. F6442734: image.png is just with a + F6442738: image.png is around current code F6442740: image.png is this proposal I'll try with + for a cou

D17152: Hide the badge if number too big

svuorela added a comment. @ngraham I use kmail ... but I have hundreds of thousands unread emails without counting my spam folders. (commit lists, bug lists, ...) @anthonyfieroni I think that doesn't convey any actual information. "You have a lot of unread emails and doesn't use the coun

D17177: Drop tab-based UI for the about page

apol added a comment. F6442717: discover-scrollableabout.png REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17177 To: apol, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuter

D17177: Drop tab-based UI for the about page

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Integrates better with Kirigami. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETA

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.11 - Build # 86 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.11/86/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Mon, 26 Nov 2018 16:57:24 + Build duration: 2 min 0 sec and counting CONSOLE OUTPUT [...truncated

D17079: Provide a qqc2/kirigami-based about page

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:673981634266: Provide a qqc2/kirigami-based about page (authored by apol). REPOSITORY R134 Discover Software Store

D17152: Hide the badge if number too big

ngraham added a comment. +1 from me too for 9k+, 10k+, 11k+, etc REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17152 To: svuorela, #plasma, hein, broulik, #vdg, ngraham Cc: anthonyfieroni, fabianr, ndavis, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, les

D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling

ngraham abandoned this revision. ngraham added a comment. Thanks so much, Marco! That does it and looks to be a more correct way to fix the problem. I've requested a backport for Kubuntu: T10130: Backport Kirigami scroll fix into Bionic Presumabl

D17171: Set error if a kjob host disappears from kuiserver with active jobs

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2beb1a0ad231: Set error if a kjob host disappears from kuiserver with active jobs (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling

mart added a comment. now scrollviews in qqc2 do that as well REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D17143 To: ngraham, #plasma, #kirigami, mart Cc: fvogt, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling

mart added a comment. check master now, done with a slightly different approach REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D17143 To: ngraham, #plasma, #kirigami, mart Cc: fvogt, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensr

D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. ah, i noticed now, shouldn't be done here, but rather in src/controls/templates/private/ScrollView.qml REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.11 - Build # 40 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.11/40/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Mon, 26 Nov 2018 10:12:42 + Build duration: 8 min 39 sec and counting JUnit Tests N

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.11 - Build # 100 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.11/100/ Project: kf5-qt5 SUSEQt5.11 Date of build: Mon, 26 Nov 2018 10:12:37 + Build duration: 8 min 41 sec and counting JUnit Tests Name: (root) F

D17171: Set error if a kjob host disappears from kuiserver with active jobs

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. 5.12 please REPOSITORY R120 Plasma Workspace BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D17171 To: davidedmundson, #plasma, broulik Cc

D17169: Include Breeze scrollbar CSS inline

This revision was automatically updated to reflect the committed changes. Closed by commit R856:1b06fe651c74: Include Breeze scrollbar CSS inline (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17169?vs=46240&id=46258

D17170: Include actual player source in metadata

This revision was automatically updated to reflect the committed changes. Closed by commit R856:18eb942ba230: Include actual player source in metadata (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17170?vs=46242&id=46

D17171: Set error if a kjob host disappears from kuiserver with active jobs

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY If the host of a kjob crashes or is killed kuiserver currently reports that

Monday meeting notes for 26/11/2018

Roman: --- What I did: --- * Rebased my touch input patches locally on master and tested them on my live system. * Replied to review comment in D16990 and D17007 <- needs decision on how to move forward Diff 16990 "[kded] Change configuration storage path" [Needs Review] https://

KDE CI: Plasma » plasma-browser-integration » kf5-qt5 SUSEQt5.11 - Build # 81 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-browser-integration/job/kf5-qt5%20SUSEQt5.11/81/ Project: kf5-qt5 SUSEQt5.11 Date of build: Mon, 26 Nov 2018 10:12:47 + Build duration: 7 min 38 sec and counting JUnit Tests Name

D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. In D17143#365563 , @fvogt wrote: > IMO this workaround is generic enough that adding it into `ScrollablePage.qml` or even `templates/private/Scrol

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.11 - Build # 39 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.11/39/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Mon, 26 Nov 2018 09:27:19 + Build duration: 10 min and counting JUnit Tests Name: (r

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.11 - Build # 99 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.11/99/ Project: kf5-qt5 SUSEQt5.11 Date of build: Mon, 26 Nov 2018 09:24:19 + Build duration: 6 min 0 sec and counting JUnit Tests Name: (root) Fail

KDE CI: Plasma » plasma-browser-integration » kf5-qt5 SUSEQt5.11 - Build # 80 - Failure!

einit5: opened connection to :90Cannot find file: /home/jenkins/workspace/Plasma/plasma-browser-integration/kf5-qt5 SUSEQt5.11/build/DartConfiguration.tcl Site:Build name: (empty)Create new tag: 20181126-0927 - ExperimentalCannot find file: /home/jenkins/workspace/Plasma/plasma-browser-integr

D16435: Also catch new Audio() elements

This revision was automatically updated to reflect the committed changes. Closed by commit R856:c947306c0c23: Also catch new Audio() elements (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16435?vs=44243&id=46247 REVI

D17039: ASAN: Fix leak in KAStatsFavoritesModel

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7f83492a654c: ASAN: Fix leak in KAStatsFavoritesModel (authored by kfunk). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17039?vs=45867&id=46246 REVISION D

D17127: [Device Notifier] Keep the device label & icon after unmounting

thsurrel added a comment. Hi @filipf, thanks for trying that out. I realized that the problem is only present when working with master, the problem appeared with a recent commit. I updated the summary accordingly. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde

D17170: Include actual player source in metadata

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY For all intents and purposes the website URL is more appropriate but it can

D17169: Include Breeze scrollbar CSS inline

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY You cannot access cssRules for on a different domain since Chrome 64. Si

D17152: Hide the badge if number too big

anthonyfieroni added a comment. In D17152#365975 , @ndavis wrote: > Why not abbreviate the number? Instead of using "9,999+" for 11000, use "11K". I like the idea, 10K+, 11K+, (badgeRect.number / 1000) REPOSITORY R119 Plasma Desktop R