D17360: Added "Transparent with light text" theme for Desktop Notes

2018-12-04 Thread Maxim Stepanov
IamMaxim added a comment. Of course, it's g.maxim.stepan...@gmail.com REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D17360 To: IamMaxim, #plasma, davidedmundson Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.11 - Build # 12 - Fixed!

2018-12-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.11/12/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Wed, 05 Dec 2018 07:07:23 + Build duration: 2 min 13 sec and counting JUnit Tests Name:

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.11 - Build # 14 - Still unstable!

2018-12-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.11/14/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Wed, 05 Dec 2018 07:07:24 + Build duration: 2 min 4 sec and counting JUnit Tests

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.11 - Build # 15 - Fixed!

2018-12-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.11/15/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Wed, 05 Dec 2018 07:07:22 + Build duration: 1 min 54 sec and counting JUnit Tests

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.11 - Build # 12 - Fixed!

2018-12-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.11/12/ Project: stable-kf5-qt5 FreeBSDQt5.11 Date of build: Wed, 05 Dec 2018 07:07:25 + Build duration: 1 min 2 sec and counting

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-04 Thread Nathaniel Graham
ngraham added a comment. Did we decide not to move forward with the idea of a tooltip, or is that being done in another patch? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham, trickyricky26, #vdg,

D17360: Added "Transparent with light text" theme for Desktop Notes

2018-12-04 Thread Nathaniel Graham
ngraham added a comment. Thanks for the patch @IamMaxim! Can you provide your email address so we can land it with your authorship information? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D17360 To: IamMaxim, #plasma, davidedmundson Cc: abetts, ngraham,

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

2018-12-04 Thread Andres Betts
abetts added a comment. Thank you! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17354 To: ngraham, #plasma, #vdg, mart Cc: mvourlakos, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

2018-12-04 Thread Nathaniel Graham
ngraham updated this revision to Diff 46872. ngraham added a comment. - Move General section back to the top, where it belongs - Use a left label for the plugin section (currently bugged pending a Kirigami ptch: D17362 ) REPOSITORY R120 Plasma

D17360: Added "Transparent with light text" theme for Desktop Notes

2018-12-04 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D17360 To: IamMaxim, #plasma, davidedmundson Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17360: Added "Transparent with light text" theme for Desktop Notes

2018-12-04 Thread Nathaniel Graham
ngraham added a comment. https://bugs.kde.org/show_bug.cgi?id=386833 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D17360 To: IamMaxim, #plasma, davidedmundson Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D17360: Added "Transparent with light text" theme for Desktop Notes

2018-12-04 Thread Maxim Stepanov
IamMaxim added a comment. I've found a bug for that and added theme entry into preferences right-click menu. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D17360 To: IamMaxim, #plasma, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D17360: Added "Transparent with light text" theme for Desktop Notes

2018-12-04 Thread Maxim Stepanov
IamMaxim updated this revision to Diff 46870. IamMaxim edited the summary of this revision. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17360?vs=46865=46870 REVISION DETAIL https://phabricator.kde.org/D17360 AFFECTED FILES

D17362: [RFC] [FormLayout] Top-align item labels

2018-12-04 Thread Nathaniel Graham
ngraham created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Top-align FormLayout item labels so that they're aligned correctly for tall items. For an example of where this would be useful,

D17360: Added "Transparent with light text" theme for Desktop Notes

2018-12-04 Thread David Edmundson
davidedmundson added a comment. There's a bug number for this somewhere, can you have a look REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D17360 To: IamMaxim, #plasma, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D17361: [RFC] [FormLayout] fix item label alignment

2018-12-04 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY In git master, item labels are slightly mis-aligned. This patch is a crude and

D17359: Fix use of QRegularExpressionMatch

2018-12-04 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R845:5d3face3c1bb: Fix use of QRegularExpressionMatch (authored by fvogt). REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17359?vs=46866=46867 REVISION DETAIL

D17360: Added "Transparent with light text" theme

2018-12-04 Thread Maxim Stepanov
IamMaxim created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. IamMaxim requested review of this revision. REVISION SUMMARY This commit adds one more simple theme, for ones who prefer the dark background and want to put sticky notes on it. Before:

D17359: Fix use of QRegularExpressionMatch

2018-12-04 Thread Fabian Vogt
fvogt created this revision. fvogt added reviewers: Plasma, ivan. Herald added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY isValid is always true in this case, leading to the wrong error message being returned. TEST PLAN Opened the wizard, now it shows the

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

2018-12-04 Thread Nathaniel Graham
ngraham added a comment. OK, if I give the ColumnLayout a label, it mostly works, but the label is vertically centered rather than being top-aligned: F6455150: Needs to be top-aligned.png REPOSITORY R120 Plasma Workspace REVISION DETAIL

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-04 Thread Björn Feber
GB_2 added a comment. Waiting for https://phabricator.kde.org/D17355 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel,

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

2018-12-04 Thread Michail Vourlakos
mvourlakos added a comment. In D17354#371241 , @ngraham wrote: > In D17354#371239 , @zzag wrote: > > > Just wondering, shouldn't it look like > > > > Available plugins: [ ] Astronomical events

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

2018-12-04 Thread Andres Betts
abetts added a comment. Would you want to move the General section to the top and plugins second? In general, general labels maybe belong to the very top of a KCM? To me, it seems like a more logical progression. From all items to more specific items. REPOSITORY R120 Plasma Workspace

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

2018-12-04 Thread Nathaniel Graham
ngraham added a comment. In D17354#371239 , @zzag wrote: > Just wondering, shouldn't it look like > > Available plugins: [ ] Astronomical events > [ ] Holidays > > > ? That was my first thought too, but

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

2018-12-04 Thread Vlad Zagorodniy
zzag added a comment. Just wondering, shouldn't it look like Available plugins: [ ] Astronomical events [ ] Holidays ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17354 To: ngraham, #plasma, #vdg, mart Cc: zzag,

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

2018-12-04 Thread Nathaniel Graham
ngraham updated this revision to Diff 46855. ngraham added a comment. Make sure it's centered REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17354?vs=46854=46855 BRANCH improve-calendar-settings-layout (branched from master) REVISION DETAIL

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

2018-12-04 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Plasma, VDG, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 400663 FIXED-IN: 5.15.0 TEST PLAN Before: After: Everything still

D17347: Translate color scheme names

2018-12-04 Thread Kai Uwe Broulik
broulik added a comment. > making strings translatable does not break the string freeze I know but changing the names (and as such the order of in the list) of themes that haven't been translated forever I think isn't ideal for a stable or LTS. REPOSITORY R119 Plasma Desktop

D17347: Translate color scheme names

2018-12-04 Thread Burkhard Lück
lueck added a comment. @broulik thanks. this was commited to master, but should go into stable and lts. making strings translatable does not break the string freeze REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17347 To: broulik, #plasma, lueck,

D17347: Translate color scheme names

2018-12-04 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:4087961586e4: Translate color scheme names (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17347?vs=46836=46838 REVISION DETAIL

D17347: Translate color scheme names

2018-12-04 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, lueck. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 401136 FIXED-IN: 5.15.0 TEST PLAN The KCM reads e.g. `Name[de]=Honigwabe` but we

D17346: Support Bluetooth batteries

2018-12-04 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, bruns, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY F6454756: Screenshot_20181204_151718.png TEST

D17213: Add support for settings portal

2018-12-04 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes. Closed by commit R135:64002af69a86: Add support for settings portal (authored by jgrulich). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D16269: Show correct current download and upload speed

2018-12-04 Thread Alexander Volkov
volkov added a comment. The problem with this change is that speed is shown in bytes, not in bytes/s. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D16269 To: jgrulich, #plasma, broulik Cc: volkov, plasma-devel, ragreen, Pitel, ZrenBot,

D17213: Add support for settings portal

2018-12-04 Thread Jan Grulich
jgrulich added a comment. @broulik, may I ask you for review? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D17213 To: jgrulich, #plasma Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,