D17360: Added "Transparent with light text" theme for Desktop Notes

2018-12-05 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R114:0230b5f5e332: Added "Transparent with light text" theme for Desktop Notes (authored by IamMaxim, committed by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.

D17375: Don't automatically refresh if the user already asked apt to do so

2018-12-05 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Kubuntu, sitter, rikmills. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Just expect apt to do the right thing. BUG: 401810 REPOSITORY R134 Discover Softw

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-05 Thread David Edmundson
davidedmundson added a comment. > Local workarounds for toolkit bugs are .. I fully 100% agree on that principle, but in this specific case from my tech POV, option 1 is fine too. Sizing items is typically in the jurisdiction of the app using the component rather than the component

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-05 Thread Björn Feber
GB_2 added a comment. Ok, number two then. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-05 Thread Nathaniel Graham
ngraham added a comment. In D17323#371825 , @GB_2 wrote: > 2. Align "Height/Width" button contents on the left side F6458265: Panel Edit Mode Buttons (2).png This is the choice that basically just us

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-05 Thread Björn Feber
GB_2 added a comment. Because https://phabricator.kde.org/D17355 is currently not working properly, we have two options: 1. Small "Height/Width" button F6458263: Panel Edit Mode Buttons (1).png 2. Align "Height/Width" button contents on th

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

2018-12-05 Thread Eike Hein
hein added a comment. I'm no longer aware of bugs in this, please re-review it. Please have the latest version of @mart's D17265 applied or you may encounter weirdness from KWin's side. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kd

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

2018-12-05 Thread Eike Hein
hein updated this revision to Diff 46916. hein added a comment. Further fixes to sync & co - Adding a desktop could emit wrong model transactions (wrong container count was used to calculate append index). - `updateModifiedState` (previously `checkModifiedState`) now handles cases wher

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

2018-12-05 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Right now the componentchooser KCM's browser module has a really confusing setting ("In an ap

D17365: Round label width

2018-12-05 Thread Fabian Vogt
fvogt added a comment. > Hmm, the "After" pictured depicts terrible kerning. Take a look at "Discover" in particular. Is this really the trade-off we're faced with? It feels like there are upstream Qt bugs here. Yup, definitely. Font rendering in QML has some issues. FreeType hintin

D17365: Round label width

2018-12-05 Thread Nathaniel Graham
ngraham added a comment. Hmm, the "After" pictured depicts terrible kerning. Take a look at "Discover" in particular. Is this really the trade-off we're faced with? It feels like there are upstream Qt bugs here. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

2018-12-05 Thread Vlad Zagorodniy
zzag added a comment. Some issues that I saw while testing this patch: - with 2 rows and 6 virtual desktop, I get the following desktop layout (is it a bug in KWin core?) +---+---+---+---+---+ | | | | | | +---+---+---+---+---+ | | +---+ - if any vir

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-12-05 Thread Alex Debus
alexde added a comment. I would like to introduce another suggestion, which has not yet came up: If you don't want to blur everything, how about to only blur an rectangle underneath the login controls. That means a combination of early Plasma 5 > The early Plasma 5 login screen put a dar

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

2018-12-05 Thread Eike Hein
hein updated this revision to Diff 46895. hein added a comment. Revamp KWin restart handling The way a KWin restart is handled is now the same as the general "stay in sync with server if the user didn't make changes, other- wise stick to the user state and notify about the server-side

D17367: Update Void Linux URL in README.md

2018-12-05 Thread John Zimmermann
johnz created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. johnz requested review of this revision. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D17367 AFFECTED FILES README.md To: johnz Cc: plasma-devel, ragreen, Pitel,

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-12-05 Thread Richard Addison
raddison added a comment. > This patch adjusts the Breeze SDDM theme to remove the semi-permanently-blurred background, which has not been especially popular. Please produce methodological evidence of its unpopularity. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabric

D17217: Implement free memory notifier

2018-12-05 Thread Oleg Solovyov
McPain updated this revision to Diff 46892. McPain added a comment. Default limit: 25% -> 10% Fix typos Auto detect swap, removed "includeSwap" setting KSysGuard: show kill button (implemented in D17366 ) CHANGES SINCE LAST UPDATE https://phabricato

D17366: Implement "Kill" button when sysguard was invoked from freememorynotifier

2018-12-05 Thread Oleg Solovyov
McPain created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY If ksysguard was invoked from freememorynotifier directly, every process is displayed with its own kill button. In most "OOM-risky"

D17217: Implement free memory notifier

2018-12-05 Thread Oleg Solovyov
McPain added a comment. In D17217#367842 , @davidedmundson wrote: > There's also an alternative that I'd like to suggest: > According to https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt there's a system called "memory pressure" y

D17360: Added "Transparent with light text" theme for Desktop Notes

2018-12-05 Thread Shubham
shubham added a comment. Congrats on your first patch. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D17360 To: IamMaxim, #plasma, davidedmundson Cc: shubham, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, seb

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.11 - Build # 109 - Failure!

2018-12-05 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.11/109/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Wed, 05 Dec 2018 09:55:40 + Build duration: 4 min 8 sec and counting CONSOLE OUTPUT Started

D17365: Round label width

2018-12-05 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R119:3526334e8234: Round label width (authored by fvogt). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17365?vs=46884&id=46886 REVISION DETAIL https://phabric

D17365: Round label width

2018-12-05 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Cool! Stable branch pls REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D17365 To: fvogt, #plasma, broulik Cc: broulik, plasma-devel, ragr

D17365: Round folder view delegate and label positions

2018-12-05 Thread Fabian Vogt
fvogt updated this revision to Diff 46884. fvogt added a comment. Turns out the label width rounding is enough REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17365?vs=46882&id=46884 BRANCH master REVISION DETAIL https://phabricator.kde.org/D173

D17365: Round folder view delegate and label positions

2018-12-05 Thread Fabian Vogt
fvogt added inline comments. INLINE COMMENTS > broulik wrote in FolderItemDelegate.qml:66 > That's what this hideous code is actually supposed to do It doesn't work though - I'll check some more. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17365 To: fvogt,

D17365: Round folder view delegate and label positions

2018-12-05 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > FolderItemDelegate.qml:66 > // leading to blurry rendering. The Loader is offset to account for > this. > x: -main.x % 1 > y: -main.y % 1 That's what this hideous code is actually supposed to do REPOSITORY R119 Plasm

D17365: Round folder view delegate and label positions

2018-12-05 Thread Fabian Vogt
fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY Currently the delegates and especially the labels can be at non-integer positions. This results in ugly font rendering. TEST PLAN Before/aft