D17659: Set parent window for dialogs

broulik added a comment. +1 INLINE COMMENTS > utils.h:24 > + > +class Utils > +{ This might as well be a `namespace`? REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH Plasma/5.14 REVISION DETAIL https://phabricator.kde.org/D17659 To: volkov, jgrulich, apol Cc: bro

D17677: Add workaround for gtk file chooser filter patterns

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY Gtk can use filter patterns, looking like "*.[Pp][Nn][Gg]" to handle all possible lowercase/uppercase variants. This is unfortu

D17677: Add workaround for gtk file chooser filter patterns

jgrulich updated this revision to Diff 47829. jgrulich added a comment. Be more specific about the pattern REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17677?vs=47825&id=47829 BRANCH Plasma/5.14 REVISION DETAIL ht

D17658: Redraw the slider if modes have changed

amantia updated this revision to Diff 47830. amantia added a comment. - Show unconnected displayed at the left REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17658?vs=47779&id=47830 BRANCH rework_qml_part REVISION DETAIL https://phabricator.kde.org/D1

D17658: Redraw the slider if modes have changed

amantia updated this revision to Diff 47831. amantia added a comment. Undo last change REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17658?vs=47830&id=47831 BRANCH fix_null_size REVISION DETAIL https://phabricator.kde.org/D17658 AFFECTED FILES kcm

D17677: Add workaround for gtk file chooser filter patterns

jgrulich updated this revision to Diff 47833. jgrulich added a comment. Allow also patterns like '*.ab[cC]de[fF]' REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17677?vs=47829&id=47833 BRANCH Plasma/5.14 REVISION DETA

D17642: remove binding loop in KickoffItem

This revision was automatically updated to reflect the committed changes. Closed by commit R119:be189b0ce2b7: remove binding loop in KickoffItem (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17642?vs=47730&id=47837 REVISI

D17677: Add workaround for gtk file chooser filter patterns

davidedmundson added inline comments. INLINE COMMENTS > filechooser.cpp:287 > > QFileDialog *fileDialog = new QFileDialog(); > fileDialog->setWindowTitle(title); Given this is the plasma portal, it might be a good case to use the KFileWidget directly rather than have a proxy layer i

D17685: Notify also if modes have changedBackport for D17657Depends on D17657

amantia created this revision. amantia added a project: Plasma. amantia requested review of this revision. REVISION SUMMARY Will be needed in the KCM to correctly update the UI REPOSITORY R110 KScreen Library BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D17685 AFFECTE

D17686: Redraw the slider if modes have changed

amantia created this revision. amantia added a project: Plasma. amantia requested review of this revision. REVISION SUMMARY This can happen if a monitor was not configured at all, the KCM is shown when it first plugged in and the user selects to not configure it. In the UI it will appear wit

D17677: Add workaround for gtk file chooser filter patterns

jgrulich added inline comments. INLINE COMMENTS > davidedmundson wrote in filechooser.cpp:287 > Given this is the plasma portal, it might be a good case to use the > KFileWidget directly rather than have a proxy layer in the way which converts > filter strings back again. > > KFileWidget::setF

D17685: Notify also if modes have changed

davidedmundson added a comment. You seem to have multiple reviews open for the same thing. Can you close the outdated ones please. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D17685 To: amantia, #plasma, dvratil Cc: davidedmundson, plasma-devel, GB_2, rag

D17685: Notify also if modes have changed

amantia added a comment. I have on for master and one for Plasma 5.12, as we want this in 5.12 as well, if approved. Should I keep only one of them? REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D17685 To: amantia, #plasma, dvratil Cc: davidedmundson, plasm

D17689: Positioner: call initMaps even if m_enabled == false

McPain created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY see BUG: 401023 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17689 AFFECTED FILES plasma-deskt

D17677: Add workaround for gtk file chooser filter patterns

ngraham added a comment. The fixed bug is actually 399889 REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D17677 To: jgrulich, broulik Cc: ngraham, davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohame

D17689: [RFC] Positioner: call initMaps even if m_enabled == false

hein added a comment. Can you provide a description for this patch? What does it fix, why does it fix it? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17689 To: McPain, #plasma, hein, davidedmundson Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezh

D17685: Notify also if modes have changed

dvratil accepted this revision. dvratil added a comment. This revision is now accepted and ready to land. You can close the review for master and commit this to the stable branch, then merge stable to master. REPOSITORY R110 KScreen Library BRANCH Plasma/5.12 REVISION DETAIL https://p

D17592: Introduce a DelegateRecycler attached object

apol closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D17592 To: apol, #kirigami, mart Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17657: Notify also if modes have changed

dvratil added inline comments. INLINE COMMENTS > amantia wrote in output.cpp:583-585 > Good point, missed it. @dvratil any reason why it emits outputChanged and not > modesChanged? Actually setModes emits both, so maybe indeed it is easier to > just put modesChnaged there as well. I'm still cur

D17657: Notify also if modes have changed

amantia abandoned this revision. amantia added a comment. Will fix first in 5.12 and merge to master, as per https://phabricator.kde.org/D17685 REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D17657 To: amantia, dvratil Cc: davidedmundson, plasma-devel, GB_2,

D17686: Redraw the slider if modes have changed

dvratil accepted this revision. dvratil added a comment. This revision is now accepted and ready to land. Looks good to me. This whole thing could probably use some cleanup, but that's for another day :-) REPOSITORY R104 KScreen BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.k

D17685: Notify also if modes have changed

amantia closed this revision. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D17685 To: amantia, #plasma, dvratil Cc: davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17694: Support a tooltip on a MouseArea

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY MouseArea doesn't have hovered but it has containsMouse REPOSITORY R858 Qt Quick Controls 2: Desk

D17686: Redraw the slider if modes have changed

amantia closed this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D17686 To: amantia, #plasma, dvratil Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17659: Set parent window for dialogs

graesslin added a comment. In D17659#379007 , @apol wrote: > LGTM, I also missed this! > > Maybe it would make sense to add a TODO about implementing it for Wayland? Even better would be to just implement it for Wayland. https://api.k

D17658: Redraw the slider if modes have changed

amantia abandoned this revision. amantia added a comment. Abandoned in favor of https://phabricator.kde.org/D17686 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D17658 To: amantia, dvratil Cc: davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D17218: Fix removing first item in languages list

hein added reviewers: davidedmundson, broulik. hein added a comment. Ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17218 To: hein, #plasma, davidedmundson, broulik Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterber

D17592: Introduce a DelegateRecycler attached object

aacid added a comment. @apol you broke the build REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D17592 To: apol, #kirigami, mart Cc: aacid, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17677: Add workaround for gtk file chooser filter patterns

davidedmundson added inline comments. INLINE COMMENTS > jgrulich wrote in filechooser.cpp:287 > This can be done of course, but it will not fix this problem. It's reasonable > to use it directly and maybe add support for regular expressions in filters > to KIO, but this is something what will n

D17703: Fix KIOClient non-interactive mode handling renamed prompts

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY In the kdelibs to KF5 transition a factory class was adding for loading ren

D17652: Fix logic error in kioclient noninteractive argument handling

davidedmundson added a comment. There's a new twist! Even in non interactive mode we still got dialogs for file conflicts. See https://phabricator.kde.org/D17703 Because of this the current state isn't non-interactive. It's a horrible mess of both. Whatever we do will result in a