D17829: Make sure we don't override QIcon::themeName when we should not

2018-12-27 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY KirigamiPlugin is lives in a separate thread than QApplication and themeName initialization is a

[Breeze] [Bug 367696] konsole icon is almost invisible when I use breeze dark theme

2018-12-27 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=367696 --- Comment #4 from Kurt Hindenburg --- Git commit e1fde67a69c748b76f8210ac22f58e76b53d9717 by Kurt Hindenburg, on behalf of Nate Graham. Committed on 28/12/2018 at 03:27. Pushed by hindenburg into branch 'master'. Only show tab icon if the user has

D17815: [Wallpaper] Allow adding multiple images at once from the file picker dialog

2018-12-27 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R120:b9549351c2c7: [Wallpaper] Allow adding multiple images at once from the file picker dialog (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D17809: Check icon positions after move

2018-12-27 Thread Oleg Solovyov
McPain added inline comments. INLINE COMMENTS > positioner.cpp:418 > + */ > +while ((!isBlank(to) && from != to) || toIndices.contains(to)) { > to++; AFAIK, the first part of condition is "check if `to` is blank and if it's not, check whether we're not

D17809: Check icon positions after move

2018-12-27 Thread Oleg Solovyov
McPain updated this revision to Diff 48238. McPain added a comment. Fixed condition mistake CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17809?vs=48220=48238 REVISION DETAIL https://phabricator.kde.org/D17809 AFFECTED FILES containments/desktop/plugins/folder/positioner.cpp