D16856: [comicupdater] Fix last day check

2018-12-29 Thread Anthony Fieroni
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:28493251921b: [comicupdater] Fix last day check (authored by anthonyfieroni). REPOSITORY R114 Plasma Addons CHANGES

D16873: [comic] Request current identifier on date changed

2018-12-29 Thread Anthony Fieroni
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:fd19c36ec4e4: [comic] Request current identifier on data change (authored by anthonyfieroni). CHANGED PRIOR TO COMMIT

D17844: [RFC] Show installed and available versions of updates right there on the page

2018-12-29 Thread Nathaniel Graham
ngraham added a comment. Still RFC because the Available Version information isn't getting correctly set for PackageKit package updates: F6515740: broken.png It works fine for others though. I tried to fix it in this patch, but it didn't work. :(

D17844: [RFC] Show installed and available versions of updates right there on the page

2018-12-29 Thread Aleix Pol Gonzalez
apol added a comment. Looks good to me. Is it still RFC or you think it's good to go? I wonder if we can try to be a bit smart by only showing the postfix that changes on the "% -> %" bit, maybe it's not a great idea. I blame the clutter of the screenshot on #neon

D17864: Show tooltips for subcategories

2018-12-29 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Tooltips are already shown for both categories as well as top-level items at the category le

D17154: Go back to SCSS

2018-12-29 Thread Nathaniel Graham
ngraham added a comment. FWIW I've applied this and have been using it in my day-to-day, and so far I haven't found any problems. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D17154 To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd Cc: davidedmund

D17598: Improve "No internet connection!" error message

2018-12-29 Thread Nathaniel Graham
ngraham updated this revision to Diff 48372. ngraham added a comment. Add a line break REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17598?vs=47625&id=48372 BRANCH better-no-connectivity-error-message (branched from master) REVISION DET

D17844: [RFC] Show installed and available versions of updates right there on the page

2018-12-29 Thread Nathaniel Graham
ngraham updated this revision to Diff 48356. ngraham added a comment. Put both versions on the same line so it doesn't take up so much vertical space REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17844?vs=48315&id=48356 BRANCH show-vers

D17598: Improve "No internet connection!" error message

2018-12-29 Thread Shubham
shubham added a comment. It will look much better. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17598 To: ngraham, #discover_software_store, #vdg, apol Cc: shubham, pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensre

D17796: Show accurate checked state for system monitor configuration pages

2018-12-29 Thread Pavel Mos
pavelmos added a comment. In D17796#382974 , @ngraham wrote: > There we go, it works now! Code change looks sane to me. > > Please change the title to something more descriptive, such as "Show accurate checked state for system monitor configu

D17154: Go back to SCSS

2018-12-29 Thread David Edmundson
davidedmundson added a comment. > As a base, I used this repository: https://github.com/dirruk1/gnome-breeze Dirruk is also the author who moved this repo from SCSS to having all the assets, especially annoyingly that commit has no description on why. Would be good if we hear from him.