D17154: Go back to SCSS

bshah edited subscribers, added: bshah; removed: Sysadmin. bshah added a comment. (removing sysadmin from subscribers) REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D17154 To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd Cc: bshah, cgiboudeaux,

D17154: Go back to SCSS

ngraham added a comment. No worries! CMake can be a bit challenging. :) REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D17154 To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd Cc: cgiboudeaux, davidedmundson, bcooksley, #sysadmin, ngraham, jackg,

D17154: Go back to SCSS

gepardo added a comment. In D17154#384519 , @ngraham wrote: > The `install` target is installing to `./Breeze` and `./Breeze-Dark` in addition to the `CMAKE_INSTALL_PREFIX` location, which messes up the permissions in your source checkout if

D17154: Go back to SCSS

ngraham added a comment. The `install` target is installing to `./Breeze` and `./Breeze-Dark` in addition to the `CMAKE_INSTALL_PREFIX` location, which messes up the permissions in your source checkout if you do an in-source build and run `sudo make install`. REPOSITORY R98 Breeze for

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

ngraham added a comment. If folks really want, I can have a look at removing the feature entirely. However are we sure we don't want to keep it around as a fallback? It doesn't necessarily seem like a bad backup, it's just maybe not appropriate as a user-visible setting anymore in 2018.

D17154: Go back to SCSS

gepardo updated this revision to Diff 48462. gepardo added a comment. CMake fixes: - Compatibility with older versions - Add docs and copyright into FindSass.cmake REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17154?vs=48224=48462 BRANCH

D17154: Go back to SCSS

gepardo added inline comments. INLINE COMMENTS > cgiboudeaux wrote in FindSass.cmake:1 > Missing doc & license Which one should I choose? Is BSD 3-clause, that is used by //Extra CMake modules//, OK? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D17154 To:

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

ngraham updated this revision to Diff 48457. ngraham added a comment. Revert unintentional and unnecessary whitespace change REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17372?vs=48456=48457 BRANCH arcpatch-D17372 REVISION DETAIL

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

ngraham updated this revision to Diff 48456. ngraham added a comment. Initialize m_browserCombo before accessing it REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17372?vs=46914=48456 BRANCH arcpatch-D17372 REVISION DETAIL

D13849: WIP: Add fractional scaling to wayland scaling GUI

davidedmundson added a comment. Was uploaded so someone else could test the rest of the underlying stuff that's merged. It runtime requires Qt 5.12 for xdg-output which the shell needs for fullscreen, which means we can merge for Plasma 5.16 REPOSITORY R104 KScreen REVISION DETAIL

D13849: WIP: Add fractional scaling to wayland scaling GUI

fcucchetto added a comment. Is there a reason why this has been abandoned REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D13849 To: davidedmundson, #plasma Cc: fcucchetto, gvarsanyi, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D17154: Go back to SCSS

cgiboudeaux added inline comments. INLINE COMMENTS > CMakeLists.txt:14 > > -include(KDEInstallDirs) > +if(${CMAKE_VERSION} GREATER_EQUAL 3.12.0) > +find_package(Python3 COMPONENTS Interpreter REQUIRED) This doesn't exist in CMake 2.8.12. Use if(NOT CMAKE_VERSION VERSION_LESS 3.12.0)

D17598: Improve "No internet connection!" error message

ngraham added a comment. Not really. The text is not long, while the window size is user-adjustible so the empty space area can potentially be very large. REPOSITORY R134 Discover Software Store BRANCH better-no-connectivity-error-message (branched from master) REVISION DETAIL

D17598: Improve "No internet connection!" error message

shubham added a comment. @rooty yeah, it depends on the available space. The main motive should be full up the empty space. @ngraham Is there any possible representation where we can just eliminate or use up that empty space. REPOSITORY R134 Discover Software Store BRANCH

D17598: Improve "No internet connection!" error message

rooty added a comment. it might work on the left, but i think this is better because it takes up the entire pane, and is important enough to warrant doing so for example, F6517329: image.png F6517334: image.png

D17598: Improve "No internet connection!" error message

shubham added a comment. In D17598#384293 , @ngraham wrote: > In D17598#384289 , @shubham wrote: > > > Looking nice. Not being nitpicky, what's the default behaviour, the icon should be on top or

D17598: Improve "No internet connection!" error message

ngraham added a comment. In D17598#384289 , @shubham wrote: > Looking nice. Not being nitpicky, what's the default behaviour, the icon should be on top or to the free space on the left? There is no real rule here. It's more of "what

D17598: Improve "No internet connection!" error message

shubham added a comment. Looking nice. Not being nitpicky, what's the default behaviour, the icon should be on top or to the free space on the left? REPOSITORY R134 Discover Software Store BRANCH better-no-connectivity-error-message (branched from master) REVISION DETAIL

D17598: Improve "No internet connection!" error message

ngraham updated this revision to Diff 48441. ngraham added a comment. Rebase on master REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17598?vs=48440=48441 BRANCH better-no-connectivity-error-message (branched from master) REVISION

D17598: Improve "No internet connection!" error message

ngraham updated this revision to Diff 48440. ngraham added a comment. Tighten up the wording a tiny bit REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17598?vs=48439=48440 BRANCH better-no-connectivity-error-message (branched from

D17598: Improve "No internet connection!" error message

rooty added a comment. loving the icon, it really stresses the importance of checking whether your internet connection's working without being (too) imposing REPOSITORY R134 Discover Software Store BRANCH better-no-connectivity-error-message (branched from master) REVISION DETAIL

D17598: Improve "No internet connection!" error message

ngraham updated this revision to Diff 48439. ngraham added a comment. Add an icon per #VDG suggestion REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17598?vs=48408=48439 BRANCH