D13868: [KdePlasma-Addons/POTD/NOAA] Fixed the web address and fetched the picture from new address

2019-01-12 Thread Tagore Chandan Reddy
tagorechandanreddy added a comment. @ngraham My email address: tagore.chan...@gmail.com REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D13868 To: tagorechandanreddy, #plasma, davidedmundson Cc: ngraham, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel,

D18206: Improve the Look and Feel KCM

2019-01-12 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1 I think the use of an article is okay here since it's basically a tooltip that just happens to be inappropriately displayed as a title for other reasons. All those +1s add up

D18206: Improve the Look and Feel KCM

2019-01-12 Thread Root
rooty added a comment. +1 from me if you want you could drop the article by the way and make it "Choose Look and Feel theme" it's like "Configure Network Settings" vs "Configure the Network Settings" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18206

D18206: Improve the Look and Feel KCM

2019-01-12 Thread Chris Rizzitello
rizzitello added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18206 To: GB_2, #plasma, #vdg Cc: rizzitello, abetts, filipf, #vdg, plasma-devel, #plasma, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D18206: Improve the Look and Feel KCM

2019-01-12 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18206 To: GB_2, #plasma, #vdg Cc: abetts, filipf, #vdg, plasma-devel, #plasma, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol,

D18206: Improve the Look and Feel KCM

2019-01-12 Thread Filip Fila
filipf added a comment. I like this because the essence of what the user is doing in this kcm is choosing, rather than configuring. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18206 To: GB_2, #plasma, #vdg Cc: filipf, #vdg, plasma-devel, #plasma,

D18019: [Digital Clock] Add ability to set a custom date format string

2019-01-12 Thread Chris Holland
Zren added a comment. > D18155 Looking at the alternative patch, I've renamed the config key variable to `customDateFormat`. Most of the differences stem from not using a "variant" data type for `DigitalClock.qml`'s `dateFormat` variable. The `string

D18019: [Digital Clock] Add ability to set a custom date format string

2019-01-12 Thread Chris Holland
Zren updated this revision to Diff 49332. Zren edited the summary of this revision. Zren edited the test plan for this revision. Zren added a comment. - Rename config key from `dateFormatStr` and config TextField `dateFormatTextField` to `customDateFormat`. - Remove the "Color Format

D16945: Fix fallback to built-in ui

2019-01-12 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R133:dfd02160746b: Fix fallback to built-in ui (authored by graesslin). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16945?vs=45744=49330 REVISION DETAIL

D16943: Disable kcrash in greeter in same way as in KWin

2019-01-12 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R133:552932c8baab: Disable kcrash in greeter in same way as in KWin (authored by graesslin). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16943?vs=45629=49329

D18206: Improve the Look and Feel KCM

2019-01-12 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY The LnF KCM has some inconsistencies and doesn't always apply the KDE HIG, so this fixes that and

D18194: Fix autohide behaviour after dragging a panel

2019-01-12 Thread Steffen Coenen
scoenen added a comment. You can use this email address: stef...@steffen-coenen.de As for the potentially redundant code on X11, I am not sure if there is any benefit in changing it any further as it works as it is. It just checks if a mouseGrabberItem() is present which should never be

D17154: Go back to SCSS

2019-01-12 Thread Alexander Kernozhitsky
gepardo added a comment. > I would also scrap all the stuff about ~/.local Are there any strong reasons? Reasons for not removing `~/.local` are the following. KDE still doesn't have custom color schemes support for Breeze-GTK. But `build-theme.sh` allows to rebuild the theme with

D17154: Go back to SCSS

2019-01-12 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > build_theme.sh:89-98 > +COLOR_SCHEME="/usr/share/color-schemes/Breeze.colors" > + fi > +else > + THEME_NAME="${COLOR_SCHEME}" > + if [ -f "/usr/share/color-schemes/${COLOR_SCHEME}.colors" ]; then > +