D18401: [Look And Feel KCM] Use new icon

2019-01-19 Thread Andres Betts
abetts added a comment. +1 <3 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18401 To: ngraham, #vdg Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18401: [Look And Feel KCM] Use new icon

2019-01-19 Thread Nathaniel Graham
ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Use the new icon for the Look And Feel KCM that was just added to breeze-icons. This icon will be av

D18394: Add OTP support for openconnect VPN

2019-01-19 Thread Enrique Melendez
enriquem updated this revision to Diff 49911. enriquem added a comment. I addressed your comments, except the ones regarding macro definitions, since I am unsure thar applicable versions of openconnect have compatible parameters. I will find out and revisit the comment later CHANGES SINCE LA

D18394: Add OTP support for openconnect VPN

2019-01-19 Thread Pino Toscano
pino added a comment. Hi Enrique, I'm not a plasma-nm developer, however I provide some tips & hints regarding your patch. Other than what I noted already, there are few more things that apply in general: - make sure to respect the indentation: each level by 4 spaces with no ta

D18394: Add OTP support for openconnect VPN

2019-01-19 Thread Enrique Melendez
enriquem updated this revision to Diff 49906. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18394?vs=49899&id=49906 REVISION DETAIL https://phabricator.kde.org/D18394 AFFECTED FILES vpn/openconnect/CMakeLists.txt vpn/openconnec

D18395: Use new toolbox icon for "Tools" dropdown menu button

2019-01-19 Thread Nathaniel Graham
ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Icon will be available in Frameworks 5.55. This repo uses the same release schedule, so we can use i

D18394: Add OTP support for openconnect VPN

2019-01-19 Thread Enrique Melendez
enriquem created this revision. enriquem added a reviewer: jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. enriquem requested review of this revision. REVISION SUMMARY With this patch, One Time Password (OTP) support is added to the openconnect VPN settings an

D18392: [mobile/broadband] Port to SimpleKCM and FormLayout

2019-01-19 Thread Nicolas Fella
nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY This simplifies the code and ensures consistency with other FormLayout based KCMs REPOSITORY R116 Plasma Network Manag

D18381: Add tooltip to configure panel button

2019-01-19 Thread Nathaniel Graham
ngraham added a comment. Not all tooltips are this big, this is just the special `PlasmaCore.ToolTipArea` Tooltip. It does kind of bug me how different these types of tooltips look from the "standard" kind. They're much bigger and their backgrounds are light instead of dark. I wouldn't

D18381: Add tooltip to configure panel button

2019-01-19 Thread Hazem Salem
Codezela added a comment. why all tooltips are so big in windows and in gnome they are smaller and still readable what do u think REPOSITORY R119 Plasma Desktop BRANCH add-configure-panel-tooltip (branched from master) REVISION DETAIL https://phabricator.kde.org/D18381 To: GB_2,

D18381: Add tooltip to configure panel button

2019-01-19 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. +1 from me too. Makes sense for this particular application, and as a general principle, I think it should be mandatory for all icons-only buttons to have a tooltip so there's at least some explanatory text //somewhere//. REPOSITORY

D17784: Don't ignore default virtual devices

2019-01-19 Thread Stefanos Harhalakis
sharhalakis added a comment. Thanks for the review. Can you submit it for me? My KDE developer account is disabled, probably because of years of inactivity. REVISION DETAIL https://phabricator.kde.org/D17784 To: sharhalakis, broulik, drosca Cc: filipf, ngraham, cfeck, plasma-devel, jraleig

D18381: Add tooltip to configure panel button

2019-01-19 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I think this is a good idea. We've always done a rather poor job of telling new users how to modify the panel and this helps a bit. Now let's wait for input from #plasma

D18381: Add tooltip to configure panel button

2019-01-19 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Adds a tooltip to the configure panel button. F6556503: Configure Panel Tooltip.png

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

2019-01-19 Thread Gleb Popov
arrowd added a comment. Ping? Any chance to get this into 5.15? REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D18296 To: arrowd, #kde_applications Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D18375: Adjust Latte Dock to libtaskmanager API changes for Wayland

2019-01-19 Thread Michail Vourlakos
This revision was automatically updated to reflect the committed changes. Closed by commit R878:f6ce06f6ae83: Adjust Latte Dock to libtaskmanager API changes for Wayland (authored by scoenen, committed by mvourlakos). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.k