D18621: Add again a button to manually scan for wireless networks

2019-01-31 Thread Jan Grulich
jgrulich added a comment. If it wil be made configurable, you wouldn't be still able to use it, without depending on newer NM version. I don't see a big deal doing it this way: 1. Applet opened → request a scan 2. If the scan didn't go well, because we hit the 10s timout, go for an

D18621: Add again a button to manually scan for wireless networks

2019-01-31 Thread Valerio Pilo
vpilo added a comment. Let me be clear here - I don't really care about having this change merged, or having to rewrite it into something wholly different. I just want everyone to have their list of wifi networks to be up to date //when they need it//, that is, //when the nm applet is open//

D18607: Add a popup search bar to the plasma-nm applet

2019-01-31 Thread Valerio Pilo
This revision was automatically updated to reflect the committed changes. Closed by commit R116:684ee0c13bfb: Add a popup search bar to the plasma-nm applet (authored by vpilo). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18607?vs=5

Re: Force reset of Plasma-desktop 5.15

2019-01-31 Thread David Edmundson
Plasma/5.15 and Plasma/5.14 are both hard/reset. You will need to git reset --hard origin/Plasma/5.15 on your local branches Please confirm everything is all correct and that nothing has gone missing. Thanks David

D18182: Fix new file creation leading to dupe items on a fresh view

2019-01-31 Thread Nathaniel Graham
ngraham added a comment. You should resign as reviewer then (it's under the Add Action... menu button). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18182 To: hein, #plasma, McPain Cc: ngraham, davidedmundson, fvogt, plasma-devel, jraleigh, GB_2, ragreen,

D18607: Add a popup search bar to the plasma-nm applet

2019-01-31 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. Yep, I think this is fine. Shipit! REPOSITORY R116 Plasma Network Management Applet BRANCH vpilo/searchBar (branched from master) REVISION DETAIL https://phabricator.kde.org/D18607 To: vpilo, #vdg, #plasma, jgrulich, ngraham Cc:

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

2019-01-31 Thread Nathaniel Graham
ngraham added a comment. Can you provide your email address so we can land this patch for you with proper authorship information? Thanks! REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D15189 To: achauvel, #frameworks, dfaure, cfeck Cc: plasma-devel, antho

D18620: Display shortcut badges while holding Super

2019-01-31 Thread Michail Vourlakos
mvourlakos added a comment. In D18620#402904 , @mvourlakos wrote: > it is too low I will play with it sorry I meant too high, I would prefer a value between 500ms-800ms REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.

D18620: Display shortcut badges while holding Super

2019-01-31 Thread Michail Vourlakos
mvourlakos added a comment. In D18620#402853 , @trmdi wrote: > I've been thinking about the Meta behavior. Some ideas: > > - When the holding action is detected: just show Latte views with badges and do not activate the App Launcher if users

Force reset of Plasma-desktop 5.15

2019-01-31 Thread David Edmundson
Someone merged master into the 5.15 branch It needs to be force reset. Please don't push anything in either right now. David

D12278: [Colors KCM] Port to new design

2019-01-31 Thread Albert Astals Cid
aacid added a comment. Did this land in Plasma 5.15 on purpose or was it a mistake? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12278 To: broulik, #plasma, #vdg, davidedmundson Cc: aacid, GB_2, nicolasfella, mart, abetts, ngraham, davidedmundson, plasma-d

D18632: Port away from deprecated KIO::UDSEntry::insert()

2019-01-31 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Using replace for DesktopProtocol::prepareUDSEntry(), as we have no guarantee that certain fi

D18620: Display shortcut badges while holding Super

2019-01-31 Thread trmdi
trmdi marked 2 inline comments as done. trmdi added a comment. In D18620#402845 , @mvourlakos wrote: > @trmdi this is ok, you can merge it and afterwards we can discuss how the Meta behavior should be enabled/disabled/adjusted... > Meta is al

D18620: Display shortcut badges while holding Super

2019-01-31 Thread Michail Vourlakos
mvourlakos accepted this revision. mvourlakos added a comment. This revision is now accepted and ready to land. @trmdi this is ok, you can merge it and afterwards we can discuss how the Meta behavior should be enabled/disabled/adjusted... Meta is also used for showing Application Launcher

D18625: [plasmawindowed] Pick up KQuickAddons::QtQuickSettings

2019-01-31 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R120:ddde180ae922: [plasmawindowed] Pick up KQuickAddons::QtQuickSettings (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18625?vs=50594&

D18621: Add again a button to manually scan for wireless networks

2019-01-31 Thread Jan Grulich
jgrulich added a comment. In D18621#402832 , @davidedmundson wrote: > It's in 1.12. > > If that's not an option, it wouldn't be the end of the world to re-request a scan on a 2 second timer in case Handler::replyFinished->Handler::RequestSca

D18621: Add again a button to manually scan for wireless networks

2019-01-31 Thread David Edmundson
davidedmundson added a comment. It's in 1.12. If that's not an option, it wouldn't be the end of the world to re-request a scan on a 2 second timer in case Handler::replyFinished->Handler::RequestScan: It'll just retry until it passes then go back to the 15s. REPOSITORY R116 Plasma N

D18621: Add again a button to manually scan for wireless networks

2019-01-31 Thread Jan Grulich
jgrulich added a comment. In D18621#402768 , @davidedmundson wrote: > > I can find LastScan in the fd.o apidox, but not in NMQt... ?!? > > It doesn't seem to be there. So lets add it. It's not there because it's most likely one of rec

D18631: Fix warning

2019-01-31 Thread Aleix Pol Gonzalez
apol abandoned this revision. apol added a comment. Nope. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18631 To: apol, #plasma Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18626: [plasmoidviewer] Pick up KQuickAddons::QtQuickSettings

2019-01-31 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R118:ffa0cc8d956f: [plasmoidviewer] Pick up KQuickAddons::QtQuickSettings (authored by kossebau). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18626?vs=50595&id=506

D18631: Fix warning

2019-01-31 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D18631 AFFECTED FILES da

D18621: Add again a button to manually scan for wireless networks

2019-01-31 Thread Nathaniel Graham
ngraham added a comment. I'll note that keeping the user feeling in control is one of the bullet points on the homepage of our HIG : > //Always in control.// - It should always be clear what can be done, what is currently happening, and what has just happe

D18621: Add again a button to manually scan for wireless networks

2019-01-31 Thread David Edmundson
davidedmundson added a comment. > I can find LastScan in the fd.o apidox, but not in NMQt... ?!? It doesn't seem to be there. So lets add it. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18621 To: vpilo, #vdg, #plasma, jgrulich, ngrah

D18621: Add again a button to manually scan for wireless networks

2019-01-31 Thread Nathaniel Graham
ngraham added a comment. Again, I think this is a "the user doesn't feel in control" issue. If a feature of the software cannot automatically anticipate and meet user needs with 100% reliability, then the user must be provided with a method to self-serve for the cases where the software 's a

D18621: Add again a button to manually scan for wireless networks

2019-01-31 Thread Valerio Pilo
vpilo added a comment. In D18621#402717 , @jgrulich wrote: > In D18621#402712 , @vpilo wrote: > > > But there are legit cases where this timeout is way too long for no reason. > > > > If you clos

D18626: [plasmoidviewer] Pick up KQuickAddons::QtQuickSettings

2019-01-31 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY If having the need to use those settings with something else than the default, one also expec

D18625: [plasmawindowed] Pick up KQuickAddons::QtQuickSettings

2019-01-31 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY If having the need to use those settings with something else than the default, one also expec

D18621: Add again a button to manually scan for wireless networks

2019-01-31 Thread Jan Grulich
jgrulich added a comment. In D18621#402712 , @vpilo wrote: > But there are legit cases where this timeout is way too long for no reason. > > If you close the popup and reopen it before the NM timeout expires, then the first request will fail,

D18621: Add again a button to manually scan for wireless networks

2019-01-31 Thread Valerio Pilo
vpilo added a comment. Herald added 1 blocking reviewer(s): jgrulich. But there are legit cases where this timeout is way too long for no reason. If you close the popup and reopen it before the NM timeout expires, then the first request will fail, no attempt will be made at redoing the sc

D18182: Fix new file creation leading to dupe items on a fresh view

2019-01-31 Thread Oleg Solovyov
McPain added a comment. Somebody review this for me, please, I'm too far away from actually testing it REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18182 To: hein, #plasma, McPain Cc: davidedmundson, fvogt, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Zre