D18716: Add a SearchField component

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. If we are going to have a specialized line edit, I think it shouldn't be specific for search, but be a common component of things that we have to boilerplate too often as they are

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

jgrulich added a comment. That sounds like a bug in NetworkManager, because ActivatingConnection should be the one which will become PrimaryConnection, that's what the documentation says, that's the reason why we use it. If it's a NM bug, we still need a workaround. In your code, you

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.12 - Build # 69 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.12/69/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 04 Feb 2019 04:32:57 + Build duration: 23 min and counting JUnit Tests Name:

D18700: [Color Picker] Allow dragging color button to drag color

ngraham added a comment. Very nice, a lovely little productivity booster. Could `containsPress` be used to pass the event down to the button so we get visual feedback? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D18700 To: broulik, #plasma Cc: ngraham,

D18716: Add a SearchField component

ngraham added a comment. Nice, I give my permission for the re-licensing. INLINE COMMENTS > SearchField.qml:33 > +id: searchField > +property QtObject page > +property string currentSearchText @apol Is this still applicable if it's a re-usable component? REPOSITORY R169

D18716: Add a SearchField component

ognarb created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY This is based on the searchField from Discover. It's a sugestion from @ngraham and I find it's a great idea. Note: Because

D18715: [kstyle] Don't scale shadows on Wayland

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY The compositor scales shadows as well so we don't have to do anything. REPOSITORY R31 Breeze BRANCH

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas added a comment. In D18689#404502 , @jgrulich wrote: > This doesn't seem to be a correct fix. We should be using icon for whatever connection is primary, not only when primary connection is wifi / ethernet / modem / bluetooth. If you

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas added a comment. In D18689#404506 , @jgrulich wrote: > Correct fix would be to set icon for bridge connections in the last else branch at the end of setIcons() method, probably guarded with a condition whether the user has enabled

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

jgrulich added a comment. Correct fix would be to set icon for bridge connections in the last else branch at the end of setIcons() method, probably guarded with a condition whether the user has enabled virtual connections. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

jgrulich added a comment. This doesn't seem to be a correct fix. We should be using icon for whatever connection is primary, not only when primary connection is wifi / ethernet / modem / bluetooth. If you check NM on dbus, what is the primary connection there? Is it the bridge one?

KDE CI: Plasma » plasma-integration » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-integration/job/kf5-qt5%20FreeBSDQt5.12/7/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 03 Feb 2019 17:35:35 + Build duration: 2 min 38 sec and counting CONSOLE OUTPUT

D18701: [Icon Applet] Show busy indicator when launching app

broulik planned changes to this revision. broulik added a comment. Needs to set a timeout REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18701 To: broulik, #plasma Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D18701: [Icon Applet] Show busy indicator when launching app

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Provides some feedback when clicking the icon. TEST PLAN Placed a Dolphin icon plasmoid in my

D18700: [Color Picker] Allow dragging color button to drag color

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY One can already drag colors from the popup grid to applications but this wasn't possible with

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas updated this revision to Diff 50771. rthomas added a reviewer: Plasma. rthomas added a comment. Should have used '&&' in the if statement instead of '||'. We want to shift to the PrimaryConnection if the Device is not among Wifi, Ethernet, Modem and Bluetooth. Reason for

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

Codezela added a comment. i think we need to make the connection name in 5he context menu bold headr not the lite color it looks strange to me REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18504 To: vpilo, #vdg, jgrulich Cc: Codezela,

D18696: Update `libdbusmenuqt` and the AppMenu plugin

ntninja created this revision. ntninja added reviewers: Zren, majohnson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ntninja requested review of this revision. REVISION SUMMARY What the title says, synchronize the relevant bits of source code with upstream

D18682: Update Breeze Dark Look and Feel theme previews

This revision was automatically updated to reflect the committed changes. Closed by commit R31:2750e07e4e00: Update Breeze Dark Look and Feel theme previews (authored by GB_2). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18682?vs=50762=50766 REVISION DETAIL

D18681: Update Breeze Look and Feel theme previews

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ba642873f40f: Update Breeze Look and Feel theme previews (authored by GB_2). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18681?vs=50761=50765 REVISION

D18682: Update Breeze Dark Look and Feel theme previews

GB_2 updated this revision to Diff 50762. GB_2 added a comment. Improve Look and Feel theme previews REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18682?vs=50738=50762 BRANCH update-breezedark-lookandfeel-theme-previews (branched from master) REVISION

D18681: Update Breeze Look and Feel theme previews

GB_2 updated this revision to Diff 50761. GB_2 added a comment. Improve Look and Feel theme previews REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18681?vs=50737=50761 BRANCH update-breeze-lookandfeel-theme-previews (branched from master)